From 9b2f520b2df3869f5210041376b209945df812cb Mon Sep 17 00:00:00 2001 From: Wilken Rivera Date: Wed, 8 Dec 2021 04:13:16 -0500 Subject: [PATCH] Fix basic datasource acceptance test flakiness (#11438) This change sets a region on the test datasource config to fix intermittent InvalidAMIID.NotFound errors. Closes https://github.com/hashicorp/packer-internal-issues/issues/14 Failing results before change ``` > AWS_DEFAULT_REGION=us-west-1 make testacc === RUN TestAccInitAndBuildBasicAmazonAmiDatasource 2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider" 2021/12/07 20:40:05 Found region us-west-1 2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider" pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_amazon-ami_basic_datasource_test.txt Logs can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/packer_log_amazon-ami_basic_datasource_test.txt and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/amazon-ami_basic_datasource_test.pkr.hcl --- FAIL: TestAccInitAndBuildBasicAmazonAmiDatasource (9.87s) FAIL FAIL github.com/hashicorp/packer/acctest/plugin 10.326s ``` Passing results after change ``` > AWS_DEFAULT_REGION=us-west-1 make testacc === RUN TestAccInitAndBuildBasicAmazonAmiDatasource 2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider" 2021/12/07 20:47:28 Found region us-west-1 2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider" --- PASS: TestAccInitAndBuildBasicAmazonAmiDatasource (223.32s) PASS ``` --- acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl | 1 + 1 file changed, 1 insertion(+) diff --git a/acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl b/acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl index a634347f7..b3c469602 100644 --- a/acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl +++ b/acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl @@ -13,6 +13,7 @@ data "amazon-ami" "test" { root-device-type = "ebs" virtualization-type = "hvm" } + region = "us-west-2" most_recent = true owners = ["099720109477"] }