From 7ba913c4f311caa7212be9034c19b374cb5725c5 Mon Sep 17 00:00:00 2001 From: Megan Marsh Date: Wed, 23 Jan 2019 11:35:50 -0800 Subject: [PATCH] update contributing guidelines and make sure that the PR template links to them. --- .github/CONTRIBUTING.md | 9 +++++++-- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 87a822e91..2ab733774 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -129,8 +129,13 @@ to use `git push ...`. we want to understand your thought process. 4. If we have requested changes, you can either make those changes or, if you - disagree with the suggested changes, we can have a conversation about our reasoning and agree on a path forward. This may be a multi-step process. Our view is that pull requests are a chance to collaborate, and we welcome - conversations about how to do things better. + disagree with the suggested changes, we can have a conversation about our + reasoning and agree on a path forward. This may be a multi-step process. Our + view is that pull requests are a chance to collaborate, and we welcome + conversations about how to do things better. It is the contributor's + responsibility to address any changes requested. While reviewers are happy to + give guidance, it is unsustainable for us to perform the coding work necessary + to get a PR into a mergeable state. 5. Once all outstanding comments and checklist items have been addressed, your contribution will be merged! Merged PRs will be included in the next diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e6881a2d3..72c5bee09 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,11 @@ **DELETE THIS TEMPLATE BEFORE SUBMITTING** +In order to have a good experience with our community, we recommend that you +read the contributing guidelines for making a PR, and understand the lifecycle +of a Packer PR: + +https://github.com/hashicorp/packer/blob/master/.github/CONTRIBUTING.md#opening-an-pull-request + Describe the change you are making here! Please include tests. Check out these examples: