Properly return error when invalid instance state is found

12 years ago · 77dedd9eab
parent 7e970a8c08
commit 77dedd9eab
1 changed files with 1 additions and 2 deletions
--- a/builder/openstack/server.go
+++ b/builder/openstack/server.go
@ -75,8 +75,7 @@ func WaitForState(conf *StateChangeConf) (i interface{}, err error) {
 		}

 		if !found {
-			fmt.Errorf("unexpected state '%s', wanted target '%s'", currentState, conf.Target)
-			return
+			return nil, fmt.Errorf("unexpected state '%s', wanted target '%s'", currentState, conf.Target)
 		}

 		log.Printf("Waiting for state to become: %s currently %s (%d%%)", conf.Target, currentState, currentProgress)