diff --git a/builder/osc/chroot/builder.go b/builder/osc/chroot/builder.go index 1b5019653..88d1ebfc9 100644 --- a/builder/osc/chroot/builder.go +++ b/builder/osc/chroot/builder.go @@ -252,6 +252,10 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe &StepPreMountCommands{ Commands: b.config.PreMountCommands, }, + &StepMountDevice{ + MountOptions: b.config.MountOptions, + MountPartition: b.config.MountPartition, + }, ) // Run! diff --git a/builder/osc/chroot/builder_acc_test.go b/builder/osc/chroot/builder_acc_test.go index 0a65f74af..be28b3b76 100644 --- a/builder/osc/chroot/builder_acc_test.go +++ b/builder/osc/chroot/builder_acc_test.go @@ -8,9 +8,10 @@ import ( func TestBuilderAcc_basic(t *testing.T) { builderT.Test(t, builderT.TestCase{ - PreCheck: func() { testAccPreCheck(t) }, - Builder: &Builder{}, - Template: testBuilderAccBasic, + PreCheck: func() { testAccPreCheck(t) }, + Builder: &Builder{}, + Template: testBuilderAccBasic, + SkipArtifactTeardown: true, }) } @@ -22,9 +23,11 @@ const testBuilderAccBasic = ` "builders": [{ "type": "test", "region": "eu-west-2", - "source_omi": "ami-46260446", + "source_omi": "ami-99466096", "omi_name": "packer-test {{timestamp}}", - "omi_virtualization_type": "hvm" + "omi_virtualization_type": "hvm", + "device_path": "/dev/xvdf", + "mount_partition": "0" }] } ` diff --git a/builder/osc/chroot/device.go b/builder/osc/chroot/device.go index 4ae8bc789..f703b78ea 100644 --- a/builder/osc/chroot/device.go +++ b/builder/osc/chroot/device.go @@ -42,7 +42,7 @@ func AvailableDevice() (string, error) { // devicePrefix returns the prefix ("sd" or "xvd" or so on) of the devices // on the system. The "vd" prefix appears on outscale images. func devicePrefix() (string, error) { - available := []string{"sd", "xvd", "vd"} + available := []string{"sd", "xvd"} f, err := os.Open("/sys/block") if err != nil { diff --git a/builder/osc/chroot/step_link_volume.go b/builder/osc/chroot/step_link_volume.go index 09f00f03a..8c5b6d941 100644 --- a/builder/osc/chroot/step_link_volume.go +++ b/builder/osc/chroot/step_link_volume.go @@ -30,8 +30,7 @@ func (s *StepLinkVolume) Run(ctx context.Context, state multistep.StateBag) mult volumeId := state.Get("volume_id").(string) // For the API call, it expects "sd" prefixed devices. - //linkVolume := strings.Replace(device, "/xvd", "/sd", 1) - linkVolume := strings.Replace(device, "/vd", "/sd", 1) + linkVolume := strings.Replace(device, "/xvd", "/sd", 1) ui.Say(fmt.Sprintf("Attaching the root volume to %s", linkVolume)) _, err := oapiconn.POST_LinkVolume(oapi.LinkVolumeRequest{ diff --git a/builder/osc/chroot/step_mount_device.go b/builder/osc/chroot/step_mount_device.go new file mode 100644 index 000000000..51a150e19 --- /dev/null +++ b/builder/osc/chroot/step_mount_device.go @@ -0,0 +1,157 @@ +package chroot + +import ( + "bytes" + "context" + "fmt" + "log" + "os" + "path/filepath" + "strings" + + "github.com/hashicorp/packer/helper/multistep" + "github.com/hashicorp/packer/packer" + "github.com/hashicorp/packer/template/interpolate" +) + +type mountPathData struct { + Device string +} + +// StepMountDevice mounts the attached device. +// +// Produces: +// mount_path string - The location where the volume was mounted. +// mount_device_cleanup CleanupFunc - To perform early cleanup +type StepMountDevice struct { + MountOptions []string + MountPartition string + + mountPath string +} + +func (s *StepMountDevice) Run(_ context.Context, state multistep.StateBag) multistep.StepAction { + config := state.Get("config").(*Config) + ui := state.Get("ui").(packer.Ui) + device := state.Get("device").(string) + if config.NVMEDevicePath != "" { + // customizable device path for mounting NVME block devices on c5 and m5 HVM + device = config.NVMEDevicePath + } + wrappedCommand := state.Get("wrappedCommand").(CommandWrapper) + + var virtualizationType string + if config.FromScratch { + virtualizationType = config.OMIVirtType + } else { + //image := state.Get("source_image").(oapi.Image) + + //Is always hvm + virtualizationType = "hvm" + log.Printf("Source image virtualization type is: %s", virtualizationType) + } + + ctx := config.ctx + + ctx.Data = &mountPathData{Device: filepath.Base(device)} + mountPath, err := interpolate.Render(config.MountPath, &ctx) + + if err != nil { + err := fmt.Errorf("Error preparing mount directory: %s", err) + state.Put("error", err) + ui.Error(err.Error()) + return multistep.ActionHalt + } + + mountPath, err = filepath.Abs(mountPath) + if err != nil { + err := fmt.Errorf("Error preparing mount directory: %s", err) + state.Put("error", err) + ui.Error(err.Error()) + return multistep.ActionHalt + } + + log.Printf("Mount path: %s", mountPath) + + if err := os.MkdirAll(mountPath, 0755); err != nil { + err := fmt.Errorf("Error creating mount directory: %s", err) + state.Put("error", err) + ui.Error(err.Error()) + return multistep.ActionHalt + } + + //TODO: Check the symlink created + deviceMount := device + + log.Printf("[DEBUG] s.MountPartition = %s", s.MountPartition) + + if virtualizationType == "hvm" && s.MountPartition != "0" { + deviceMount = fmt.Sprintf("%s%s", deviceMount, s.MountPartition) + } + state.Put("deviceMount", deviceMount) + + ui.Say("Mounting the root device...") + stderr := new(bytes.Buffer) + + // build mount options from mount_options config, useful for nouuid options + // or other specific device type settings for mount + opts := "" + if len(s.MountOptions) > 0 { + opts = "-o " + strings.Join(s.MountOptions, " -o ") + } + mountCommand, err := wrappedCommand( + fmt.Sprintf("mount %s %s %s", opts, deviceMount, mountPath)) + if err != nil { + err := fmt.Errorf("Error creating mount command: %s", err) + state.Put("error", err) + ui.Error(err.Error()) + return multistep.ActionHalt + } + log.Printf("[DEBUG] (step mount) mount command is %s", mountCommand) + cmd := ShellCommand(mountCommand) + cmd.Stderr = stderr + if err := cmd.Run(); err != nil { + err := fmt.Errorf( + "Error mounting root volume: %s\nStderr: %s", err, stderr.String()) + state.Put("error", err) + ui.Error(err.Error()) + return multistep.ActionHalt + } + + // Set the mount path so we remember to unmount it later + s.mountPath = mountPath + state.Put("mount_path", s.mountPath) + state.Put("mount_device_cleanup", s) + + return multistep.ActionContinue +} + +func (s *StepMountDevice) Cleanup(state multistep.StateBag) { + ui := state.Get("ui").(packer.Ui) + if err := s.CleanupFunc(state); err != nil { + ui.Error(err.Error()) + } +} + +func (s *StepMountDevice) CleanupFunc(state multistep.StateBag) error { + if s.mountPath == "" { + return nil + } + + ui := state.Get("ui").(packer.Ui) + wrappedCommand := state.Get("wrappedCommand").(CommandWrapper) + + ui.Say("Unmounting the root device...") + unmountCommand, err := wrappedCommand(fmt.Sprintf("umount %s", s.mountPath)) + if err != nil { + return fmt.Errorf("Error creating unmount command: %s", err) + } + + cmd := ShellCommand(unmountCommand) + if err := cmd.Run(); err != nil { + return fmt.Errorf("Error unmounting root device: %s", err) + } + + s.mountPath = "" + return nil +}