From 5a8af5500ba4b91ce9526e019f03e2d39f331312 Mon Sep 17 00:00:00 2001
From: Adrien Delorme <adrien.delorme@icloud.com>
Date: Wed, 5 Sep 2018 10:27:02 +0200
Subject: [PATCH] random: optimize allocation & simplify loop

---
 common/random/string.go | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/random/string.go b/common/random/string.go
index 974714fd7..74c79bc90 100644
--- a/common/random/string.go
+++ b/common/random/string.go
@@ -25,8 +25,9 @@ func AlphaNumUpper(length int) string { return String(PossibleAlphaNumUpper, len
 
 func String(chooseFrom string, length int) (randomString string) {
 	cflen := len(chooseFrom)
-	for i := 0; i < length; i++ {
-		randomString += string(chooseFrom[rnd.Intn(cflen)])
+	bytes := make([]byte, length)
+	for i := range bytes {
+		bytes[i] = chooseFrom[rnd.Intn(cflen)]
 	}
-	return
+	return string(bytes)
 }