revert false economy WRT .ExtraArguments

provisioner/puppet-masterless/provisioner.go

@@ -90,7 +90,7 @@ var guestOSTypeConfigs = map[string]guestOSTypeConfig{
 			`{{if ne .ModulePath ""}}--modulepath='{{.ModulePath}}' {{end}}` +
 			`{{if ne .HieraConfigPath ""}}--hiera_config='{{.HieraConfigPath}}' {{end}}` +
 			`{{if ne .ManifestDir ""}}--manifestdir='{{.ManifestDir}}' {{end}}` +
-			"{{.ExtraArguments}} " +
+			`{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}` +
 			"{{.ManifestFile}}",
 		facterVarsFmt:    "FACTER_%s='%s'",
 		facterVarsJoiner: " ",
@@ -107,7 +107,7 @@ var guestOSTypeConfigs = map[string]guestOSTypeConfig{
 			`{{if ne .ModulePath ""}}--modulepath='{{.ModulePath}}' {{end}}` +
 			`{{if ne .HieraConfigPath ""}}--hiera_config='{{.HieraConfigPath}}' {{end}}` +
 			`{{if ne .ManifestDir ""}}--manifestdir='{{.ManifestDir}}' {{end}}` +
-			"{{.ExtraArguments}} " +
+			`{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}` +
 			"{{.ManifestFile}}",
 		facterVarsFmt:    `SET "FACTER_%s=%s"`,
 		facterVarsJoiner: " & ",

provisioner/puppet-server/provisioner.go

@@ -88,7 +88,7 @@ var guestOSTypeConfigs = map[string]guestOSTypeConfig{
 			`{{if ne .PuppetNode ""}}--certname='{{.PuppetNode}}' {{end}}` +
 			`{{if ne .ClientCertPath ""}}--certdir='{{.ClientCertPath}}' {{end}}` +
 			`{{if ne .ClientPrivateKeyPath ""}}--privatekeydir='{{.ClientPrivateKeyPath}}' {{end}}` +
-			"{{.ExtraArguments}} ",
+			`{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}`,
 		facterVarsFmt:    "FACTER_%s='%s'",
 		facterVarsJoiner: " ",
 	},
@@ -104,7 +104,7 @@ var guestOSTypeConfigs = map[string]guestOSTypeConfig{
 			`{{if ne .PuppetNode ""}}--certname='{{.PuppetNode}}' {{end}}` +
 			`{{if ne .ClientCertPath ""}}--certdir='{{.ClientCertPath}}' {{end}}` +
 			`{{if ne .ClientPrivateKeyPath ""}}--privatekeydir='{{.ClientPrivateKeyPath}}' {{end}}` +
-			"{{.ExtraArguments}} ",
+			`{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}`,
 		facterVarsFmt:    `SET "FACTER_%s=%s"`,
 		facterVarsJoiner: " & ",
 	},

website/source/docs/provisioners/puppet-masterless.html.md

@@ -140,7 +140,7 @@ cd {{.WorkingDir}} &&
 	{{if ne .ModulePath ""}}--modulepath='{{.ModulePath}}' {{end}}
 	{{if ne .HieraConfigPath ""}}--hiera_config='{{.HieraConfigPath}}' {{end}}
 	{{if ne .ManifestDir ""}}--manifestdir='{{.ManifestDir}}' {{end}}
-	{{.ExtraArguments}}
+	{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}
 	{{.ManifestFile}}
 ```
 
@@ -155,7 +155,7 @@ cd {{.WorkingDir}} &&
 	{{if ne .ModulePath ""}}--modulepath='{{.ModulePath}}' {{end}}
 	{{if ne .HieraConfigPath ""}}--hiera_config='{{.HieraConfigPath}}' {{end}}
 	{{if ne .ManifestDir ""}}--manifestdir='{{.ManifestDir}}' {{end}}
-	{{.ExtraArguments}}
+	{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}
 	{{.ManifestFile}}
 ```
 

website/source/docs/provisioners/puppet-server.html.md

@@ -119,7 +119,7 @@ cd {{.WorkingDir}} &&
 	{{if ne .PuppetNode ""}}--certname='{{.PuppetNode}}' {{end}}
 	{{if ne .ClientCertPath ""}}--certdir='{{.ClientCertPath}}' {{end}}
 	{{if ne .ClientPrivateKeyPath ""}}--privatekeydir='{{.ClientPrivateKeyPath}}' {{end}}
-	"{{.ExtraArguments}} "
+	{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}
 ```
 
 The following command is used if guest OS type is windows:
@@ -134,7 +134,7 @@ cd {{.WorkingDir}} &&
 	{{if ne .PuppetNode ""}}--certname='{{.PuppetNode}}' {{end}}
 	{{if ne .ClientCertPath ""}}--certdir='{{.ClientCertPath}}' {{end}}
 	{{if ne .ClientPrivateKeyPath ""}}--privatekeydir='{{.ClientPrivateKeyPath}}' {{end}}
-	"{{.ExtraArguments}} "
+	{{if ne .ExtraArguments ""}}{{.ExtraArguments}} {{end}}
 ```
 
 ## Default Facts