From 094a8840d840c66452300909d9e6fee77bec4d6f Mon Sep 17 00:00:00 2001 From: Paul Meyer Date: Wed, 25 Sep 2019 17:16:17 +0000 Subject: [PATCH] Improve comments for FillParameters --- builder/azure/arm/builder.go | 2 +- builder/azure/common/client/config.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/builder/azure/arm/builder.go b/builder/azure/arm/builder.go index 6fbb611d1..27bc32a4a 100644 --- a/builder/azure/arm/builder.go +++ b/builder/azure/arm/builder.go @@ -57,7 +57,7 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack ctx, cancel := context.WithCancel(ctx) defer cancel() - // FillParameters function will set the authType from supplied parameters set the subscription and tenant id. + // FillParameters function captures authType and sets defaults. err := b.config.ClientConfig.FillParameters() if err != nil { return nil, err diff --git a/builder/azure/common/client/config.go b/builder/azure/common/client/config.go index 5cdb0e8c0..96ca8c651 100644 --- a/builder/azure/common/client/config.go +++ b/builder/azure/common/client/config.go @@ -254,6 +254,8 @@ func (c Config) GetServicePrincipalTokens( return servicePrincipalToken, servicePrincipalTokenVault, nil } +// FillParameters capture the user intent from the supplied parameter set in authType, retrieves the TenantID and CloudEnvironment if not specified. +// The SubscriptionID is also retrieved in case MSI auth is requested. func (c *Config) FillParameters() error { if c.authType == "" { if c.useDeviceLogin() {