From 673a97290a31362a994a2e624f8c15cf0eceeb14 Mon Sep 17 00:00:00 2001 From: Lucas Bajolet Date: Fri, 27 May 2022 14:45:25 -0400 Subject: [PATCH 1/2] provisioner/powershell: remove unused variable The retryableSleep variable in the powershell provisioner was defined but never used, so we can safely rename it. --- provisioner/powershell/provisioner.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/provisioner/powershell/provisioner.go b/provisioner/powershell/provisioner.go index 9e762ea18..dd1d231bd 100644 --- a/provisioner/powershell/provisioner.go +++ b/provisioner/powershell/provisioner.go @@ -28,8 +28,6 @@ import ( "github.com/hashicorp/packer-plugin-sdk/uuid" ) -var retryableSleep = 2 * time.Second - var psEscape = strings.NewReplacer( "$", "`$", "\"", "`\"", From 71752c9e1eb5f44144b01abd21a16c96565c0398 Mon Sep 17 00:00:00 2001 From: Lucas Bajolet Date: Fri, 27 May 2022 14:46:25 -0400 Subject: [PATCH 2/2] powershell/provisioner: remove useless fmt.Sprintf The fmt.Sprintf statement in Provisioner.Provision took a plain string as parameter, without any arguments, making it futile to call. --- provisioner/powershell/provisioner.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provisioner/powershell/provisioner.go b/provisioner/powershell/provisioner.go index dd1d231bd..bfef4ca53 100644 --- a/provisioner/powershell/provisioner.go +++ b/provisioner/powershell/provisioner.go @@ -257,7 +257,7 @@ func extractScript(p *Provisioner) (string, error) { } func (p *Provisioner) Provision(ctx context.Context, ui packersdk.Ui, comm packersdk.Communicator, generatedData map[string]interface{}) error { - ui.Say(fmt.Sprintf("Provisioning with Powershell...")) + ui.Say("Provisioning with Powershell...") p.communicator = comm p.generatedData = generatedData