113 Commits (fa4de5fd36b8013aa240fbb4630df103db4141ed)

Author	SHA1	Message	Date
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance ... Change the G_VALUE from a INT64 to BOXED.	3 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	3 years ago
John Ralls	688832b5f8	Bug 798585 - segfault running sample script ... The root cause of which is that on recent releases of GLib (recent meaning 2.66 in the current Debian stable!) g_type_instance_get_private looks in the wrong place for the private data. When running the script in question it returned NULL and since the code didn't check for a valid pointer, it crashed. So this change replaces all calls to g_type_instance_get_private with the function [type_prefix]_get_instance_private() added in glib-2.36 except for two register2 files that have been removed from master; those are ignored to avoid unnecessary merge conflicts.	4 years ago
Robert Fewell	ce4768c357	Bug 798565 - Import map editor entry deletion ... When a top level bayesian entry is deleted, the book is not marked dirty and so the save button is not highlighted. Deleting individual entries did mark book dirty. Fixed in gnc_account_delete_all_bayes_maps by wrapping the deletion with xaccAccountBeginEdit/CommitEdit block.	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions ... gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm ... much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." ... This reverts commit 17a3f7fef2, reversing changes made to b8458d0732.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc ... Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
Christopher Lam	8d502fcdd8	Merge branch 'maint'	5 years ago
Christopher Lam	595e126a34	[account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr ... - will remove a second call to g_strstrip (g_strdup (str))	5 years ago
Christopher Lam	c5a6383b43	[account.cpp] fix - incomplete #1117 ... - init struct members properly to: is_unset and TriState::Unset - test acct kvp "equity-type" for "opening-balance" instead of "true" - cached account->color/sort_order/notes/filter gets strstripped similarly to previous behavior	5 years ago
Christopher Lam	3bf49ed8d7	[Account.cpp] GValue string must be unset	5 years ago
Robert Fewell	a9a3ed425a	Free Accounts on book close	5 years ago
Christopher Lam	eafc290034	Merge branch 'maint'	5 years ago
Christopher Lam	4c37f6d4ef	[account.cpp] gnc_g_list_stringjoin instead of repeated allocations	5 years ago
Christopher Lam	0420ae6a66	[account.cpp] refactor gnc_account_list_name_violations	5 years ago
Christopher Lam	67bd513514	[account.cpp] rewrite gnc_account_foreach_descendant_until in C++	5 years ago
Christopher Lam	17953441cb	[account.cpp] refactor gnc_account_foreach_descendant	5 years ago
Christopher Lam	5698b67bf5	[account.cpp] refactor gnc_account_lookup_by_code	5 years ago
Christopher Lam	09e2e7613c	[account.cpp] refactor gnc_account_lookup_by_name	5 years ago
Christopher Lam	bebc366e88	[account.cpp] refactor gnc_account_n_descendants	5 years ago
Christopher Lam	e6c33a39bc	[account.cpp] refactor gnc_account_get_descendants{_sorted}	5 years ago
Christopher Lam	d2db43019c	[account.cpp] internal function account_foreach_descendant ... fast and efficient	5 years ago
Simon Arlott	320df7e409	Use const return values for string cache ... This is a prerequisite for being able to return "" (which is const) and none of the returned values should ever be modified.	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
John Ralls	6aa35ea7fb	Better fix for bug 798204, doesn't break trading account selection.	5 years ago
Christopher Lam	c8a7b9edb3	[Account] g_value_unset	5 years ago
Christopher Lam	b25a444140	Merge branch 'maint'	5 years ago
John Ralls	4f030aac6e	Bug 798093 - Changing the symbol/abbreviation of a security... ... after the trading account was created breaks GnuCash. Revisited. The original changeset looked for a top level trading account and a namespace account in the transaction currency; if either of those accounts had been created in a different currency it would duplicate them. This commit will accept any such account regardless of commodity. If more than one exists it will prefer the one in the root currency if there is one, otherwise it will select the first one found.	5 years ago
John Ralls	2b48fd375d	Revert "Fix duplicate trading accounts." ... This reverts commit ed486a58a4.	5 years ago
John Ralls	ed486a58a4	Fix duplicate trading accounts. ... In many cases GnuCash would create a new trading account hierarchy when one already existed because gnc_account_lookup_by_type_and_commodity didn't check the account presented and didn't recurse down the account hierarchy correctly.	5 years ago
John Ralls	2258e7a44e	xaccAccountTypes was backwards ... vs. the documentation. The unit tests and dialog-account were similarly backwards, but the use in gnucash/import-export/ofx followed the docs.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
Robert Fewell	e535ba5411	Change some functions to use const gnc_commodity for gnc_pricedb	5 years ago
Robert Fewell	05507008c5	Add retrieval functions for price before the date given ... Add a new function, gnc_pricedb_convert_balance_nearest_before_price_t64 that retrieves the balance using the last price dated before a specified date like today for the preset value. This uses another new function gnc_pricedb_get_nearest_before_price to do the retrieval.	5 years ago
Robert Fewell	b54c30e03d	Bug 798148 - Chart of Accounts page Present(xxx) value wrong ... If for some reason you have price information in the future for a security, the present value is based on the price retrieved for the greatest date and not a price which is before the current date. To fix this use the 'xaccAccountGetBalanceAsOfDateInCurrencyRecursive' function.	5 years ago
Christopher Lam	87473ed5f9	Merge branch 'maint'	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ ... Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago