With the requirement for Gtk+ 3.22, the version checks dealing with
checking for version 3.20 or 3.22 are no longer required so these have
been removed in the source files.
This is in preparation of the final guile restructuring step:
install gnucash scm files directly in guile's default site module directory.
Internalizing json is done to prevent an install clash with a potentially
system installed guile-json module.
There are more, but these are most common ones.
There are also a number of urls that don't behave well when https, so those are skipped
At some point I have also started marking non-working URLs as [DEAD LINK], though
that's not a full coverage.
this is a compatibility hack to remove dependency on srfi-43 which is
not present on ubuntu 14.04. create a simplified vector-for-each
suitable for this module.
There are a very few left that need deeper study, but this gets
rid of most of the noise. For the most part it's just getting rid of
extra variables or removing an assignment that is always
replaced later but before any reads of the variable. A few are
discarded result variables.
We only used strfmon in one source file to generate three fixed format
strings. Instead of updating to a newer strfmon in borrowed I have
chosen to reimplement the string formatters for these strings in C++.
Note this is *not* a full c++ conversion of the full functionality
of assistant-loan. Only the string parsing has been redone.
When fixing related combo error a couple of critical errors were logged
for 'Function is not appropriate for this type of widget' which turned
out to be visibility properties so added them to stop error.
This will avoid a ninja-build from picking up a config.h generated by the autotools build
(in the root build directory). Picking up the wrong config.h may lead to all kinds of
subtle issues if the autotools run was done with different options than the cmake run.