62 Commits (cdd59d79d24b4bf46cc7baa830b600cc96cfd3aa)

Author	SHA1	Message	Date
John Ralls	83829e6513	Merge branch 'maint'	3 years ago
John Ralls	1020bde89c	Fix crashes in test-engine on Arch Linux. ... Root cause is mutating a list while it's iterating. We're able to protect it in two cases, have to copy it in xaccTransScrubGainsDate.	3 years ago
John Ralls	3d5e27982f	Merge branch 'maint'	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
Richard Cohen	9c6ad222a9	[-Wunused-function] - remove	3 years ago
Richard Cohen	ea2d3be217	Remove some unused variables with obviously no side effects	3 years ago
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... ... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
Christopher Lam	fd12d3900c	[Transaction.c] use heuristics to determine txn->txn_type	4 years ago
Christopher Lam	aa43c198c6	[Transaction.c] don't set TxnType kvp if it is the same as before ... will avoid dirtying the transaction.	4 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	001b34616f	[Transaction.c] GValue string must be unset	5 years ago
Robert Fewell	71d73beb6c	Original splits are not freed in xaccTransRollbackEdit ... At the beginning of a transactions edit, xaccTransBeginEdit is used and part of that duplicates the existing splits so that they can be restored if editing is cancelled. If cancelled, xaccTransRollbackEdit is used to restore the origin splits but if a split was not changed, the copy was not being freed so loop over the original split list and free them.	5 years ago
John Ralls	9062be3d47	Merge Simon Arlott's 'string-cache-fixes' into maint.	5 years ago
Simon Arlott	320df7e409	Use const return values for string cache ... This is a prerequisite for being able to return "" (which is const) and none of the returned values should ever be modified.	5 years ago
Simon Arlott	4132939612	Avoid leaking string cache entries for "" in Transaction and Split ... When g_object_new() is used, the strings that default to "" are added to the string cache. These are then not correctly removed when updating them with new values when cloning a Transaction/Split. Use CACHE_REPLACE instead of CACHE_INSERT.	5 years ago
John Ralls	601eb51361	Improve transaction sorting on effective num field. ... Inspired by PR #983. Transaction sorting on num broke down if the user had a non-numeric string or a number larger than an int in the effective num field (might be split-action if the option is set). The comparison first tries to use strtoull on the two strings and compares the results. If they're both nonzero and different then the numeric order is returned. If they're both nonzero but the same the unconverted parts of each are passed to g_utf8_collate; if either is 0 then the whole strings are passed to g_utf8_collate. strtoull will return 0 for a negative number.	5 years ago
John Ralls	68ec80e68d	Bug 798203 - g_assert fault while reversing transaction ... * Re-commit the original transaction to ensure that there aren't any stray trading splits. * If the original and cloned transactions have a different number of splits don't leak the cloned transaction. * Check that the cloned transaction isn't NULL before trying to invert it.	5 years ago
John Ralls	80d6749989	Bug 787813 - Price change from editing a transaction not reflected... ... in pricedb. Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.	5 years ago
Christopher Lam	92cd437562	[Transaction.c] g_value_unset to release GValue string	5 years ago
Dong Lin	75209c024f	Update price database for imported transactions ... When a transaction is added from the ledger, price database is updated properly. But if the transaction is imported, there is no price db update. This change adds the proper pricedb update in the import path (qfx/ofx/qif). Tested with make check	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ ... Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago
Christopher Lam	b2b8792110	prepend-and-reverse instead of O(N^2) append	5 years ago
Robert Fewell	7c1026783b	Change the document link KVP symbol to original name ... To maintain compatibility with any existing document link entries the old 'assoc-head' and 'asooc_uri' entries will be used for the gsetting and KVP entries.	6 years ago
John Ralls	db626de68a	Rename all Transaction and Invoice Association identifiers to DocLink. ... To better reflect the purpose and for consistency with other software (e.g. Libre Office).	6 years ago
Christopher Lam	00efc1696a	[Transaction.c] sanity check xaccTransGetAPARAcctSplitList ... prevent segfault if trans is NULL	6 years ago
Christopher Lam	c06191a656	Transaction.c: avoid slow g_list_nth_data	6 years ago
John Ralls	c23f3f05e3	Fix deprecated G_TYPE_INSTANCE_GET_PRIVATE and G_INLINE_FUNC ... with the function/declaration that they substituted. Note that this doesn't use the recommended new GObject creation macros because the class names in libgnucash/engine don't follow the gnome naming convention.	7 years ago
John Ralls	e6e2258a74	Bug 797356 - ninja check fails with GCC-9	7 years ago
Christian Stimming	eb9e45bc20	Sorting speed-up: Cache the bool value of Transaction's is_closing property. ... This value is queried on each comparison of split or txn sort function, which means it is called quite a lot. Avoiding the KVP lookup of this property gains a lot in terms of CPU cycles.	7 years ago
Robert Fewell	2634f23f87	Bug 767772 - Associated file with transaction is lost ... when moving entry between accounts When using the cut transaction option the 'associated file' value was not being pasted to the new transaction. Added scheme code to get this value and save it to new transaction when using 'cut/copy' and then 'paste' operations. When using the duplicate option, a dialogue allows you to keep the copied association or not. It does not get copied for autocomplete.	7 years ago
John Ralls	4ffeb3efac	Ensure that a dereferenced variable isn't NULL. ... Found by clang static analyzer.	8 years ago
Geert Janssens	11af81b51b	Bug 789674 - Close Book tool regression	8 years ago
Robert Fewell	d458e13a7f	Remove KVP for assoc_uri when passed an empty string ... Change xaccTransSetAssociation so if an empty string is passed the KVP entry is removed instead of leaving an empty stub.	8 years ago
John Ralls	284d6c1456	Fix travis failure try 2. ... stdint.h for Transaction.c too. Also get rid of unused timeval decl.	8 years ago
John Ralls	710b122b24	Bug 796940 - Invalid transaction date-posted KVP causes... ... date-posted to not be saved. Check the stored GDate for being in the GncDateTime range as well as the GDate range before returning it and check trans->date-posted against INT64_MAX instead of 0 before changing it.	8 years ago
Di Mang	893383ce9b	removing double semicolons at the end of lines	8 years ago
Geert Janssens	4e71629966	Fix memory leak in xaccTransRetDateDue	8 years ago
Geert Janssens	1117027f72	An empty GValue is interpreted as NULL reason, which is still a valid cache ... Ignoring this would make caching almost useless as there are typically only very few read-only transactions.	8 years ago
John Ralls	a19dcc7bd4	Fix crash when there's no TRANS_READ_ONLY_REASON slot. ... Unsetting an empty g_value raises a fatal error, causing tests to fail in some environments. g_free() handles NULLs itself, no need to protect it.	8 years ago
Geert Janssens	d069b67d48	Fix memory leak in xaccTransGetReadOnly ... In addition implement a cache for this value as suggested in the comments as this function is called on every transaction commit.	8 years ago
John Ralls	358cd979d9	Remove Timespec from the main engine classes (Transaction, Split, & Account.	8 years ago
John Ralls	c8b372e390	Convert GNC_TYPE_TIMESPEC to GNC_TYPE_TIME64, Kvp::Type::Timespec to Kvp::Type::Time64 ... They have to go together because of using gvalues to hide KVP from most of GnuCash.	8 years ago
Geert Janssens	c71204628d	Bug 795031 - 3.0 Crashes on loading when opening 2.6.19 file	8 years ago
John Ralls	6b49b3ba4c	Bug 792763 - deleting a transaction can cause a SIGSEGV ... Prevent a NULL transaction from crashing xaccTransCountSplits and prevent gnc_plugin_business_update_menus from calling it with a NULL transaction.	8 years ago
lmat	1f050fd1e5	Transaction members Timespec->time64	8 years ago
lmat	9a86dd222b	gncInvoice uses time64	8 years ago
lmat	f77369bb96	Removing timspec from some xml parsing ... And several other sprawling references that are connected in one way or another.	8 years ago