gnucash

Commit Graph

Author	SHA1	Message	Date
John Ralls	bbb4113a5a	Bug 798156 - glib 2.68.0 breaks gnucash Move all of the #include <glib> to before the extern "C" blocks so that the include guards will protect against headers inside the extern "C" block also including glib.h.	5 years ago
John Ralls	170502c6c5	Bug 797906 - GnuCash data file is locked after a "save-as"... to mysql database. It's more general, any save-as to a different backend type, i.e. xml->sql or sql->xml, left the previous book locked. Ensure that the session is ended and the book unlocked in the backend's destructor. This also fixes a memory leak in the SQL backend because the GncSqlConnection wasn't being deleted.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. glib headers should not be included with 'extern "C"'.	5 years ago
John Ralls	94a68dca7c	Bug 797983 - v4.2 report numbers change over gnucash restarts;... Price Database dropping user:price-editor entries. A wider problem: QofInstance was unmarking itself dirty as long as the backend raised an error and unconditionally marking itself non-infant. This matters because the SQL backend depends on infant status to decide whether to do an insert or update query; either will fail if the infant status is wrong. The price editor dialog clones a price having only its commodity set and GncSqlPriceBackend declines to save if the currency isn't set. Since the instance marked itself non-infant even though it wasn't saved subsequent commits tried to use an update query and since the price wasn't in the table that inevitably failed. Requiring that QofBackend::commit should doing the marking-clean required implementing it in the backends where it wasn't already.	6 years ago
Robert Fewell	d4e90132d9	Fix a missing mode == in 'Replace the three bool parameters to qof_session_begin to an enum'.	6 years ago
John Ralls	6a1cb5eecd	Replace the three bool parameters to qof_session_begin to an enum. For clarity. In so doing found the backend behavior a bit inconsistent so it's modified to do what the enum values indicate. In the course of changing the various calls I found some implementation errors in the back end and corrected them.	6 years ago
John Ralls	a320035f42	QofSession, QofBackend: Change book_id to uri. It's more descriptive and less likely to be confused with the book:id value in XML files that is the book's GUID. Also changed the QofSessionImpl::begin new_uri parameter from std::string to const char*. There's no point in allocating a string just to call new_uri.c_str() all over the place.	6 years ago
John Ralls	a3871d9ca1	Warn if can't lock for any reason other than that the file is locked already. And include the error string in the message.	7 years ago
John Ralls	e81bcf6e33	Fix the remaining static analysis warnings. Except two incorrect leak warnings and one about mktemp being insecure in the XML backend. See the respective comments about those.	7 years ago
John Ralls	faba7975ac	Fix a bunch of memory allocation errors found by clang static analysis.	7 years ago
Geert Janssens	83d14e1c1c	Restructure the src directory It is split into - /libgnucash (for the non-gui bits) - /gnucash (for the gui) - /common (misc source files used by both) - /bindings (currently only holds python bindings) This is the first step in restructuring the code. It will need much more fine tuning later on.	9 years ago

11 Commits (bfdec74a488b95dc41734553ef4d20b4e2dc5d2c)