gnucash

Commit Graph

Author	SHA1	Message	Date
John Ralls	44fc52f5c6	Fix unnecessary copy in range-for loop Flagged by new clang Apple version 12.	6 years ago
John Ralls	b8d514e157	Don't try to unlock the GncDbiSqlConnection when it was connected read-only. If it's locked it's not our lock.	6 years ago
John Ralls	6a1cb5eecd	Replace the three bool parameters to qof_session_begin to an enum. For clarity. In so doing found the backend behavior a bit inconsistent so it's modified to do what the enum values indicate. In the course of changing the various calls I found some implementation errors in the back end and corrected them.	6 years ago
John Ralls	bf55c30aeb	Fix most of the unused assignment errors from static analysis. There are a very few left that need deeper study, but this gets rid of most of the noise. For the most part it's just getting rid of extra variables or removing an assignment that is always replaced later but before any reads of the variable. A few are discarded result variables.	8 years ago
John Ralls	2f861bc2a4	Ensure all C++ class member raw pointers are default-initialized to nullptr.	8 years ago
John Ralls	333a14c0fd	Fix ubuntu build failure. %$^%$ C++11 initializer list behavior.	8 years ago
John Ralls	3b3074c28d	Bug 796117 - Connecting 3.1 to an existing mysql db drops all data Provide a backup recovery function that instead of dropping primaries and restoring backups merges the primaries and backups. This should handle a worst-case safe-save failure where the backup tables don't have a complete set of rows for some reason.	8 years ago
John Ralls	3e052e8dac	[DBI Backend] Rework backup-table management. Removes a public function, GncDbiSqlConnection::table_manage_backup that should have been private in the first place. Better encapsulates table renames and drops with private functions and handles cases where there exist some primary tables and some backup tables.	8 years ago
John Ralls	e23769f078	[DBI Backend] If there's a set error value use that to set the backend error.	8 years ago
John Ralls	464fdeeb26	[DBI Backend] Remove unused TableOpTypes.	8 years ago
John Ralls	cad6bb4272	Bug 792105 - Startup takes several minutes, take two. First, remove the unnecessary locale push & pop on <CT_TIME64>load. Second, the registry accesses were caused by using g_win32_get_locale to convert the Microsoft locale strings to POSIX ones. We don't care what kind of string we get as long as we can pass it back to setlocale, so remove that. Third, gnc_push/pop_locale were used only in backend/dbi in a very limited way and did much more than was necessary, so convert them to C++ inlines in gnc-backend-dbi.hpp that does only what we need them to.	8 years ago
John Ralls	d8c2f52447	Correct quoting for SQL backends. Only string values should be quoted in queries; in particular NULL isn't a string value and must not be quoted. Note that this is a less than perfect solution because it doesn't use the Database's quoting function and so doesn't escape quotes, linefeeds, or carriage returns inside the string. That's because the SQL generating logic is independent of the connection class and can't easily get to it.	9 years ago
Geert Janssens	83d14e1c1c	Restructure the src directory It is split into - /libgnucash (for the non-gui bits) - /gnucash (for the gui) - /common (misc source files used by both) - /bindings (currently only holds python bindings) This is the first step in restructuring the code. It will need much more fine tuning later on.	9 years ago

13 Commits (a4b1827793b146e9d0fd8db87c76cb5caa211dc6)