14 Commits (9bbe29b42d5068253dcf746e94de2b48f10f0d54)

Author	SHA1	Message	Date
Stefan Koch	0e3853bfb7	Fix undefined behaviour in collection_compare_cb function. ... The collection_compare_cb function set the user_data pointer to point to a local variable of the function. That pointer is then used in the (only) calling function qof_collection_compare to make decisions. This is undefined. It is likely not an actual problem because the stack depth of the qof_collection_foreach followed by collection_compare_cb is deeper than the qof_collection_get_data call (and others in between if any) that the stack data user data stays uncorrupted. But, it is undefined behavior, and could cause really subtle bugs if these there are code changes that have deeper stack between the setting and using. Also, using this local variable is not necessary, the qof_collection_compare function already sets up a variable local to its scope for this that the collection_compare_cb can use directly. This commit removes the local (to collection_compare_cb) variable and uses the one setup in qof_collection_compare. The full coverage test for qofid.cpp passed before and after this change.	1 month ago
Stefan Koch	a2cc9881df	Explicitly set the is_dirty attribute in qof_collection_new ... It is likely that the memory was zeroed anyway, but the explicitness makes it easier to read.	1 month ago
Stefan Koch	9079d87307	Remove unused qof_collection_from_glist function.	1 month ago
Christopher Lam	370a06fb61	[qofid.cpp] remove unnecessary struct	2 years ago
Christopher Lam	d21d6f9344	[qofid.cpp] qof_collection_foreach_sorted	2 years ago
Sherlock	f0d45de642	Resolve test assert.	2 years ago
Sherlock	8d6f748aca	Bug 799281 - Deleting a transaction may trigger a crash ... Update qof_collection_lookup_entity() to prevent returning instances marked to be destroyed.	2 years ago
Richard Cohen	1cec0cb3f3	Use internal extern "C" { ... } for C++ ... - removes warnings compiling swig engine ... [ 10%] Generating swig-engine.cpp .../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored), .../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'. .../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".	3 years ago
John Ralls	bbb4113a5a	Bug 798156 - glib 2.68.0 breaks gnucash ... Move all of the #include <glib> to before the extern "C" blocks so that the include guards will protect against headers inside the extern "C" block also including glib.h.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. ... glib headers should not be included with 'extern "C"'.	5 years ago
Bill Nottingham	592c3ad562	Fix building with link-time-optimization. ... Patch from Jeff Law (law@redhat.com): Rename one instance of struct _iterate to struct _qofid_iterate to avoid ODR problems with LTO	6 years ago
John Ralls	faba7975ac	Fix a bunch of memory allocation errors found by clang static analysis.	7 years ago
Geert Janssens	1238b9d8cd	Prevent gcc from searching config.h in the current directory ... This will avoid a ninja-build from picking up a config.h generated by the autotools build (in the root build directory). Picking up the wrong config.h may lead to all kinds of subtle issues if the autotools run was done with different options than the cmake run.	8 years ago
Geert Janssens	83d14e1c1c	Restructure the src directory ... It is split into - /libgnucash (for the non-gui bits) - /gnucash (for the gui) - /common (misc source files used by both) - /bindings (currently only holds python bindings) This is the first step in restructuring the code. It will need much more fine tuning later on.	9 years ago