2529 Commits (9bbe29b42d5068253dcf746e94de2b48f10f0d54)

Author	SHA1	Message	Date
Christopher Lam	3a2ac526a6	[gnc-commodity.cpp] improve gnc_commodity_compare ... ensure it is a stable sort	3 months ago
John Ralls	e5fe2f3e0e	Merge Stefan Koch's 'sk-unittest-qofid' into stable.	3 months ago
Stefan Koch	113af56272	fixup: Review comments about style of code.	3 months ago
Stefan Koch	7f0d66d439	fixup: Add the new test-qofid.cpp file the the source distribution.	3 months ago
Stefan Koch	be5933a1ec	fixup: Remove memory leaks in the test code.	3 months ago
Stefan Koch	0e3853bfb7	Fix undefined behaviour in collection_compare_cb function. ... The collection_compare_cb function set the user_data pointer to point to a local variable of the function. That pointer is then used in the (only) calling function qof_collection_compare to make decisions. This is undefined. It is likely not an actual problem because the stack depth of the qof_collection_foreach followed by collection_compare_cb is deeper than the qof_collection_get_data call (and others in between if any) that the stack data user data stays uncorrupted. But, it is undefined behavior, and could cause really subtle bugs if these there are code changes that have deeper stack between the setting and using. Also, using this local variable is not necessary, the qof_collection_compare function already sets up a variable local to its scope for this that the collection_compare_cb can use directly. This commit removes the local (to collection_compare_cb) variable and uses the one setup in qof_collection_compare. The full coverage test for qofid.cpp passed before and after this change.	3 months ago
Stefan Koch	6e9a20dfeb	Implement full test coverage of libgnucash/engine/qofid ... NOTE: This does not have full coverage because the "if (!target || !ent)" body in the collection_compare_cp function cannot be reached. There is too much safety in the rest of the system to test this error. NOTE: I made this a separate test from the test-engine so that I was able to check that it by itself could test the full coverage of the qofid.cpp file. If it was part of the larger test, I could have missed some parts that were covered incidentally elsewhere.	3 months ago
Stefan Koch	a2cc9881df	Explicitly set the is_dirty attribute in qof_collection_new ... It is likely that the memory was zeroed anyway, but the explicitness makes it easier to read.	3 months ago
Stefan Koch	9079d87307	Remove unused qof_collection_from_glist function.	3 months ago
Christopher Lam	334b015c19	[Account.h] gnc_account_get_earliest_date ... Returns posted date of earliest split, or INT64_MAX if the account has no splits. This may reflect the opening date of the account.	3 months ago
John Ralls	622c35cfaa	WORDS_BIGENDIAN needs to be a compile definition and checked with ifdef.	3 months ago
John Ralls	b028f50fa3	A better fix for gcc ptr->int casting pickiness.	3 months ago
John Ralls	1d9b80f7ff	gcc 15.2 is really picky about casting between ints of different sizes. ... So subvert the warnings with a union. Note that the exception is deliberatley unhandled: We want to crash out if there are high bits.	3 months ago
Robert Fewell	b5185e1823	Bug 799706 - Rename Namespace ... Add a rename namespace button to the Security editor that is enabled by the selection of a namespace row in the tree view.	3 months ago
Christopher Lam	c3e4f374a9	[account.cpp] gnc_account_child_index non-child acct should return -1 ... bugfix from 6cac9d0ebb	3 months ago
Christopher Lam	65d573889b	[gnc-locale-utils.cpp] don't need to strdup locale ... it's not freed later	3 months ago
John Ralls	be46171d02	Turn of deprecation warning for wstring_convert. ... Deprecated in C++17, no replacement until C++26.	3 months ago
John Ralls	1f6a0c019a	Fix uninitialized variable warning.	3 months ago
Christopher Lam	c4317b906b	Merge branch 'autoclear' into stable	4 months ago
John Ralls	942313d099	GncDateTime: New exceptions and a 32-bit time_t problem. ... Boost::date_time has changed to throwing a std::out_of_range instead of a boost::date_time::gregorian::bad_year when a date is outside of the 1400-9999 year range it can deal with. We also recently discovered that it will use the system localtime function when creating a new date which can lead to a 2038 failure. Use std::chrono to resolve that problem.	4 months ago
Christopher Lam	8d831d3501	[gnc-autoclear.cpp] gettext for abort messages	4 months ago
Christopher Lam	bcce7a88c0	[gnc-autoclear.cpp] upgrade GError to return code too	4 months ago
Christopher Lam	f893b046fb	[io-gncxml-v2.cpp] xmlGetProp must be xmlFreed	4 months ago
John Ralls	3a06602910	Fix Asan UB complaint about int64_t alignment. ... by doing endian_swap on the aligned local instead of the unaligned bytes of the memory mapped file.	4 months ago
Christopher Lam	4f655492ce	[sixtp-dom-parsers.cpp] g_date_free GDate leak ... missed out on refactor. previous code incorrectly used g_free.	4 months ago
John Ralls	34330c2a57	gncTaxTable: chain up to the correct parent function.	4 months ago
Bruce Schuck	f055c3c5a4	Added US Bonds (usbonds) to gnc-commodity.cpp ... New Finance::Quote module to get prices for series E, EE, or I bonds	4 months ago
Christopher Lam	455ea3e71a	[backend/xml] dom_tree_to_text returns std::optional<std::string>	4 months ago
Christopher Lam	e79db945b2	[backend/xml] use apply_xmlnode_text	4 months ago
Christopher Lam	753e435456	[sixtp-dom-parsers.h] add templated functions for node text ... * apply_xmlnode_text (node, f, optional default_val) retrieves text; and calls and returns f(text) on failure (i.e. node==null || node has no text), it returns default_val * apply_xmlnode_text (node, obj, f) retrieves text; and calls and returns f(obj, text) on success, it will return true, on failure it returns false	4 months ago
Christopher Lam	c80234341c	[gnc-euro.cpp] fix typo for bulgarian lev rate	4 months ago
Christopher Lam	349c208a6c	[guid.cpp] GncGUID* avoids temporary gnc::GUID, and better hash	4 months ago
John Ralls	6907d3648a	Bulgarian Lev (BGN) replaced by Euro 1 Jan 2026.	4 months ago
Christopher Lam	465959cc90	[sixtp-dom-parsers.cpp] dom_tree_to_gdate: GDate on the stack ... removing need for a goto to free the gdate.	4 months ago
Christopher Lam	7c955b452f	[sixtp-utils] string_to_num upgraded to use string_view ... so that it can parse const char* and std::string	4 months ago
Christopher Lam	cfc357a430	[backend/xml] fast string setters for acct/trans/split ... Avoids allocating/g_free temporary strings when DOM text exists. Replaces dom_tree_to_text() with dom_node_to_text() fast-path for Account, Transaction, and Split string setters.	4 months ago
Christopher Lam	a63a3e3ce3	[sixtp-dom-parsers.cpp] introduce dom_node_to_text for solo text node ... allocation-free returns const char* or nullptr	4 months ago
Christopher Lam	2f7e51cf2a	[sixtp-dom-parsers.cpp] Remove unnecessary commodity allocation during XML load ... dom_tree_to_commodity_ref() is called for every transaction or price. It created and destroyed a commodity only to read its namespace and mnemonic when loading books. Rewrite to avoid creating temporary commodity. dom_tree_to_commodity_ref_no_engine () is called when creating commodities. Introduce get_commodity_ns_mnemonic() to parse namespace/mnemonic directly, and use it in both code paths.	4 months ago
Christopher Lam	a57cd653e5	[backend/xml] dom_tree_to_guid returns std::optional<GncGUID> instead of GncGUID* ... therefore GncGUID is stack-allocated, removing the need for guid_free	4 months ago
Christopher Lam	2e3fd090ff	[gnc-autoclear.cpp] restore abort explanation message	4 months ago
Christopher Lam	722a455593	[guid.cpp] string->guid should disallow 'g' char ... off-by-1 error in alpha test. only 'a'-'f' should be allowed.	5 months ago
Christopher Lam	1cfda5a71a	[test-gnc-guid.cpp] use EXPECT_THROW ... instead of try..catch	5 months ago
Christopher Lam	cdb9dfa0ee	[guid.cpp] fast_string_to_guid: -1<<4 is UB, fix UB ... when parsing invalid chars, hi|lo would return -1. convert to unsigned to avoid UB.	5 months ago
Christopher Lam	3e4e334944	[guid.cpp] string->guid: parse into uuid data, avoids memcpy	5 months ago
Christopher Lam	534bea748f	[guid.cpp] Specialise guid<->32-byte string ... - string->guid has branch-lite unrollable loop, fallback to slow boost parser - guid->string uses lookup table - avoids creating several temporary heap-allocated std::strings	5 months ago
Christopher Lam	3c5a1801e2	[guid.cpp] fix guid==nullptr comparison retvals ... - if guid_1 guid_2 are both null they should return int(0) or bool(true)	5 months ago
John Ralls	7e5f559724	Merge Christian Wehling's 'improve_strings' into stable.	5 months ago
Christopher Lam	7c7c8b0992	[gnc-pricedb.cpp] plug leak when fiscal_end_date is null ... fiscal_end_date was assigned g_date_new but never freed. merge with invalid fiscal_end_date too.	5 months ago
Christopher Lam	04af7b5fa6	[qofobject.cpp] check col!=nullptr instead of obj ... because obj was already verified non-nullptr a few lines prior. this logic error present since original qofobject.c	5 months ago
Jaime Marquínez Ferrándiz	98772cc991	test-userdata-dir-invalid-home: Unset XDG_DATA_HOME ... On some test environments XDG_DATA_HOME may be configured with a path that actually exists, so we unset it to actually get the temporary directory.	5 months ago