2519 Commits (6e9a20dfebca6bbba8d9cfdeb6b4183a3d0fe364)

Author	SHA1	Message	Date
Christopher Lam	655bddda46	[account.cpp] comparing identical accts returns 0 ... bypassing many comparisons	6 months ago
Christopher Lam	001c690a81	[account.cpp] gnc_account_foreach_split forward loops only ... because the reverse iteration isn't used at all	6 months ago
Sherlock	e680a87a66	Bug 799682 - Unable to "Save As" (or open) a non-xml data file ... Fixes a generic bug in gnc_module_init_backend_dbi() when HAVE_LIBDBI_R is defined. Specifically, when the initial dbi_initialize_r() returns no drivers, the dbi_instance variable is still set.	6 months ago
Bruce Schuck	7cc6871d7f	Removed China Merchants Bank from quote sources. ... The Finance::Quote module is no longer working and will be removed in the next release.	6 months ago
Christopher Lam	5dad327f47	[qoflog.cpp] plug a gchar* leak	7 months ago
Christopher Lam	c8348fa4cf	[translog.cpp] use c++ for better cleanup	7 months ago
Christopher Lam	fcf2fc5f85	[gnc-prefs.cpp] plug gchar* leak ... namespace_regexp was never freed upon shutdown	7 months ago
Christopher Lam	5c5b32ab61	[gnc-prefs.cpp] convert to c++	7 months ago
Christopher Lam	a545c4f396	[fin.c] fix encoding to utf8	7 months ago
John Ralls	ebcd670ab5	Merge Bruce Schuck's 'addswissfundata' into stable.	7 months ago
John Ralls	dcb7a8c242	Fix GncDateTime tests on Windows.	8 months ago
John Ralls	6666027a9b	Coerce matching file separators for testing gnc_path_get_pkgsysconfdir ... g_build_filename claims that on Windows is uses the separator that last previously occurred in the parameters, but it looks only at the first character of each parameter to see if it's a separator. On Windows the leading character is a letter even on absolute paths so g_build_filename(sysconfdir, PROJECT_NAME, NULL) finds no separator and uses the Windows default "\\", but in the test function gnc_file_path_relative_part returns "/etc" so g_build_filename uses "/" for the project name separator. By explicitly inserting G_DIR_SEPARATOR_S before PROJECT_NAME we force the same separator and the test passes on Windows.	8 months ago
John Ralls	04d6601b74	Always write XML files with Unix line endings. ... So that file size comparisons in test-load-save-files pass on Windows.	8 months ago
John Ralls	6fab138647	Adjust tests to accommodate Win32 special cases.	8 months ago
John Ralls	1af9e33d81	[Tests] Fix filepath handling and temp directory location on Win32 builds.	8 months ago
John Ralls	6fda0321a7	Fix path environment for Guile and GncModule tests on Windows.	8 months ago
John Ralls	46972b3125	Set policy CMP0177 and follow the documented recommendations regarding DESTINATION paths.	8 months ago
John Ralls	58f3390dbc	Merge Sherlock's 'Bug 343711' into stable.	8 months ago
Sherlock	048dfa1232	Bug 343711 - Splits to Imbalance-USD do not disappear when zero-valued. ... To mitigate potential impact, the Imbalance split is only removed when the split transitions to zero value during the commit of the transaction and the split's memo and action have no value.	8 months ago
Sherlock	0e041af555	Bug 799652 - Invoice price decimal places ... Bug 799652 - Invoice price decimal places The "+ 2 places" should only be applied when force decimal is enabled. Update gnc-ui-util.cpp Update test-balsheet-pnl.scm Update test-ifrs-cost-basis.scm Update test-invoice.scm	8 months ago
Bruce Schuck	bd440d9eff	Added Swiss Fund Data AG to single_quote_sources. ... New F::Q source will be available in v1.67.	8 months ago
John Ralls	5f7017854b	Specialize get_row_value_from_object for int64_t. ... So that it doesn't try to pass the value in a pointer. That comes out badly on 32-bit systems.	9 months ago
John Ralls	4c81bc3ea3	[WIN32]Fix path problems prevneting test-backend-dbi from working.	9 months ago
John Ralls	54664359dc	Fix building tests on Win32. ... They don't pass, but at least they build and sort of run.	9 months ago
John Ralls	a773248939	Bug 799649 - Ensure that GnuCash does not crash when it converts a... ... foreign-currency transaction into a trading account transaction. Disable scrubbing while committing the new trading split, otherwise the recursed scrub will delete it causing a crash when GnuCash tries to populate it.	9 months ago
Christopher Lam	368b74c69c	[gnc-pricedb.cpp] plug leak from gnc_g_date_new_today	10 months ago
Christopher Lam	f3f917df38	[Transaction.cpp] use qof_instance kvp API for GDate	10 months ago
Christopher Lam	fac028133e	[gtest-xml-contents] test xaccTransGetDatePostedGDate from xml ... confirms xml read is valid	10 months ago
Christopher Lam	ab04715c91	[Transaction.cpp] use qof_instance kvp API for Time64, with bugfix ... fixes bug whereby xaccTransRetDateDue returns 0 if the kvp time64 stored is 0.	10 months ago
Christopher Lam	985f591830	[Transaction.cpp] small modification to xaccTransSetNotes	10 months ago
Christopher Lam	7e740babdf	[Transaction.cpp] small modification to xaccTransSetReadOnly ... if reason is "" then remove the kvp	10 months ago
Christopher Lam	23a2e091c7	[Transaction.cpp] use qof_instance kvp API for const char*	10 months ago
Christopher Lam	754a1eb42f	[utest-Account.cpp] use qof_instance kvp API for const char*	10 months ago
Christopher Lam	e48c293143	[Split.cpp] use qof_instance kvp API for GncGUID*	10 months ago
Christopher Lam	5fc64466a1	[Transaction.cpp] use qof_instance kvp API for GncGUID*	10 months ago
Christopher Lam	7e22685a1c	[Transaction.cpp] use qof_instance kvp API for int64_t	10 months ago
Christopher Lam	e28f314d43	[Split.cpp] use qof_instance kvp API for gnc_numeric	10 months ago
Christopher Lam	0cea3725a1	[Split.cpp] use qof_instance kvp API for const char*	10 months ago
Christopher Lam	ed4f72f3a7	[gnc-lot.cpp] use qof_instance kvp API for const char*	10 months ago
Christopher Lam	72869a393d	[gnc-commodity.cpp] use qof_instance kvp API for const char*	10 months ago
Christopher Lam	e7f05b9baa	[gnc-commodities.cpp] expose auto_quote_control kvp to test them	10 months ago
Christopher Lam	aa339b4674	[Transaction.cpp] use g_list_copy_deep	10 months ago
Christopher Lam	01366f425f	[gtest-load-and-test-datafile.cpp] add example .gnucash to test contents ... seed xml datafile to test stability of XML serialization routines	10 months ago
Christopher Lam	7f82098c11	[utest-Transaction.cpp] add test_xaccTransGetDateDue tests ... including currently (arguably) buggy behaviour if kvp time64 is 0...	10 months ago
Christopher Lam	584bc61192	[utest-Transaction.cpp] test actual kvp slots	10 months ago
Christopher Lam	c5a6341ab2	[utest-Transaction] add trans->notes tests	10 months ago
Christopher Lam	4e2189db53	[utest-Transaction.cpp] xaccTransGetDocLink with NULL doclink is NOP	10 months ago
John Ralls	d8c68cce9e	[gnc-locale-name] Use setlocale(LC_MONETARY, NULL) to retrieve name. ... Instead of setlocale(LC_ALL, NULL). The uses for the string either create an ICU locale or sort between German and US TXF reports. On some OSes where the user has different locales set for one or more categories LC_ALL produces a dump of all of the LC_FOO variables and their values. That's not useful for comparing to de_DE and it's too long for ICU, which crashes. Meanwhile in dialog-print-checks the RV of setlocale was ignored, rendering the call a no-op.	10 months ago
John Ralls	dc91b96874	Merge Bruce Schuck's 'rmfqmodules' into stable.	10 months ago
John Ralls	db883f972b	Bug 799623 - test-backend-dbi fails after 2038 ... The first-line cause of the bug was that the safe save was failing on SQLite3 because the backup tables weren't visible inside the transaction and that prevented them from being dropped. Commit the transaction before trying to drop the backup tables.	10 months ago
John Ralls	c1eb5a6980	[DBI Backend] Preserve int size when recovering from failed save-save. ... Delete all rows and copy merged rows back into program-created table instead of renaming the merge table. See https://bugs.gnucash.org/show_bug.cgi?id=799623#c6 for explanation.	10 months ago
John Ralls	60bc4ccab0	[test-dbi-backend] Test 64-bit integer insertion explicitly. ... https://bugs.gnucash.org/show_bug.cgi?id=799623 identified a problem with int64_t storage in SQLite3 by setting a date after 2038-01-23 whose time64 overflowed int32_t. But dates shouldn't be stored as time64s, they should be stored as ISO 8601 date-time strings. So fix the test to store the date correctly and to store the big int as an int64_t.	10 months ago
Bruce Schuck	1f4aade5d1	Modified gnc-commodity.cpp to match F::Q ... Modules Bloomberg.pm, Tiaacref.pm, Troweprice.pm removed	10 months ago
Christian Wehling	47b9bebcca	Improve translatable strings. ... These strings are labeled as "Source needs review" in Weblate.	10 months ago
Christopher Lam	48b1f51432	[gnc-unicode] bugfix strings compare equality should return 0	11 months ago
John Ralls	5ca4c8c528	[gnc-unicode] Use unicode_compare_internal for gnc_unicode_compare_identical ... instead of strcmp. strcmp does a byte-by-byte numerical comparison, not an alphabetical one (e.g. A > e). Also fix the transposed args in the strstr call in gnc_unicode_has_substring_identical.	11 months ago
Christopher Lam	a3eaac6585	[gnc-unicode.cpp] fix potential segfault ... locale was being g_freed prematurely	11 months ago
John Ralls	331fbf3dec	Merge John Ralls's branch 'bug799521' into stable	11 months ago
John Ralls	acfc8e6ec9	Merge branch 'bug797766' into stable	11 months ago
John Ralls	5941167132	Bug 797766 - Automatic decimal point doesn't work properly with... ... zeros when entering stocks. Preserve the decimal point when printing numbers with no decimal places to stop the auto-decimal code from triggering when exiting the field.	11 months ago
John Ralls	d7624ab75c	[Core Utils] Add ICU-based substring search. ... See https://unicode-org.github.io/icu/userguide/collation/string-search.html for a discussion of ICU's string search capabilities. This new file implements finding substrings and string comparisons at all but the quaternary strength, that being of somewhat rarefied utility.	11 months ago
Bruce Schuck	e761185d5c	Added new F::Q source to single_quote_sources. ... China Merchants Bank - cmbchina	11 months ago
Bruce Schuck	0ca5d1d956	Fixed comment about failover methods/multiple sources	11 months ago
Bruce Schuck	a707f8ea89	Modified quote sources to match current F::Q	11 months ago
John Ralls	71939be5fa	[test gnc-quotes] Allow quote time and now time to differ slightly. ... Prevents the occasional spurious test failure.	11 months ago
John Ralls	019fbb3f58	Bug 799490 - Error on start or opening a gnucash file: Can't parse the URL ... g_filename_from_uri can't handle # in paths but gnc_uri_get_path can.	12 months ago
John Ralls	910130c500	Bug 799506 - reconcile bad date pops to 1969 ... Ensure that qof_scan_date always returns a valid year, month, and day by converting the result of date scanning to a struct tm and normalizing it.	12 months ago
John Ralls	ebc407766b	Bug 799580 - Swiss currency symbol is displayed as SFr. instead of CHF ... The S is obsolete but Fr. is still widely used. This is the local symbol so users who want CHF can set it in the security editor.	12 months ago
Bill Sommerfeld	0407466789	Drop the definition of __EXTENSIONS__ from three files and instead ... move it to compiler options if on a platform that needs it.	12 months ago
John Ralls	889a4dde95	Mortgage assistant: Avoid crash when returning to the repayment page. ... And as a side benefit don't leak signal handlers for the repGncFreq changed signal. The crash occured because gnc_frequency_setup_recurrence first calls gnc_date_edit_set_gdate which emits a changed signal that, if it wasn't the first call to loan_rep_prep would call update_repayment_formula_cb and that would generate a new recurrences list. But the still running gnc_frequency_setup_recurrence still had a pointer to the old list and when it tried to manipulate it it would crash. This change disconnects the previous signal handler preventing the list from being replaced.	12 months ago
John Ralls	10d519544b	Merge Bill Sommerfeld's 'gnc-date-fix' into stable.	1 year ago
John Ralls	3770cb8131	Wrap include of gtest.h and gmock.h with a warning-silencing pragma. ... See https://github.com/google/googletest/issues/4701 The warnings cause the Arch Linux CI to fail because of -Werror.	1 year ago
John Ralls	e00eade735	Change boost version for boost::process changes to 1.86.0 ... That introduced a deprecation warning when including the unversioned boost::process headers. The warning breaks the Arch Linux CI because of -Werror.	1 year ago
Bill Sommerfeld	76254e050f	Fix build of test-gnc-date on systems without HAVE_STRUCT_TM_GMTOFF	1 year ago
John Ralls	940085a017	Remove unused include of libxml2/SAX.h ... It raises a deprecation warning in libxml2-2.14.0.	1 year ago
John Ralls	99f86d31ed	Bug 799594 - GnuCash 5.11 fails to build with boost 1.88 ... Boost Process 1.88 defaults to the new V2 API introduced in Boost 1.81. https://repology.org/project/boost/versions shows that distro support for boost 1.81 and later is spotty at best so we won't be able to migrate to v2 until that improves.	1 year ago
John Ralls	6712a4a5fb	gnc_relative_date_to_time64: Have only if statemen for period TODAY.	1 year ago
John Ralls	b5b2221e72	Test gnc-option-date variable fy start days. ... Leverages the FakePrefsBackend from the previous commit to change the fiscal year for testing. Makes now_t a defaulted parameter of gnc_relative_date_to_time64 so that we can inject different reference dates for testing.	1 year ago
John Ralls	cf369fb270	Add and use a fake preferences backend to set the fiscal year. ... This restores the expected precondition for the quarter tests of the Accounting Period being the current calendar year, replacing the today-relative quarter begin and end dates.	1 year ago
Sherlock	4e4dcf1758	Use the fiscal start day of the month for relative quarter reports ... Only the quarter's start month in reports is adjusted when Absolute is selected in the Start Date on the Accounting Period preferences. This branch adjusts both the quarter's start day and month when Absolute is selected or when Relative and Today, Start of this month, or Start of previous month are selected.	1 year ago
Robert Fewell	ad4c3f681d	Merge Simon Arlott 'jump-multiple-splits' into stable	1 year ago
Robert Fewell	6f722be642	Bug 799562 - Import Map Editor Non-Bayesian crashes gnucash ... Missing G_VALUE_INIT after recent change to function.	1 year ago
Christopher Lam	99506779e3	Bug 799565 - Reconcile date default doesn't update to reflect previous reconciliation. ... A one-word path error in xaccAccountClearReconcilePostpone. The commit 9172d1dd23 accidentally reverted in 90662d72a2, reapply	1 year ago
John Ralls	90662d72a2	xaccAccountDeleteAllTransactions: Avoid UAF crashes ... Chris Lam pointed out that the original algo would crash if a transaction had more than one split in the account being deleted. Deduplicate the transaction vector first to protect against that. Also suspend qof events for a 4x speedup.	1 year ago
John Ralls	0e15e12ea9	Improve GncNumeric(std::string) to handle unicode spaces.	1 year ago
John Ralls	1fa4f71f59	Fix gnc-numeric test failure on macOS 15.4 beta. ... Caused by Apple suddenly fixing ostreams to put the thousands separator in numbers when it's set in the locale.	1 year ago
John Ralls	058e2a196b	Bug 799564 - Decimal point confusions when getting stock quotes from aex ... Add parsing thousands-grouped numbers to GncNumeric(const std::string&).	1 year ago
John Ralls	9172d1dd23	Bug 799565 - Reconcile date default doesn't update to reflect… ... previous reconciliation. A one-word path error in xaccAccountClearReconcilePostpone.	1 year ago
John Ralls	bc7fafd4ad	Bug 799528 - Crash on account deletion (edit) ... New function xaccAccountDeleteAllTransactions. Delete all transactions before deleting the account; simply deleting the splits during account destruction isn't safe. In the particular case of an imbalance account the transaction commit after deleting a split just makes a new one.	1 year ago
Sherlock	f3b08ddefb	Bug 798946 - start/end of current/last quarter have off-by-one error	1 year ago
John Ralls	5b08f8f35c	Merge John Ralls's 'bug798958' into stable.	1 year ago
Alex Aycinena	d0ad95fe92	Correct bug introduced in commit 63deaad. affecting Edit->Tax Report Options and the US Income Tax Report	1 year ago
Simon Arlott	d924e3f624	Register preference "Jump action for multiple splits" ... Make the behaviour when the "Jump" operation encounters a transaction with more than two splits configurable. This can be configured as: * Do nothing (this is the default) * Use the split with the largest value * Use the split with the smallest value This makes it much easier to jump between accounts for stock transactions that include splits for fees and taxes, or dividend transactions that have a zero value split for the stock account.	1 year ago
Simon Arlott	6be4c3c363	Support for enums as GtkRadioButton preferences ... The "=" in the widget name will separate the pref name from the enum string value that is used when the radio button is activated. When the radio button is deactivated, its preference update is ignored because another button must have been made active.	1 year ago
John Ralls	a475172d8c	Bug 798946 - start/end of current/last quarter have off-by-one error	1 year ago
Christopher Lam	f6c73b15fb	use gnc_account_get_all_parents and std::mismatch	1 year ago
Christopher Lam	a2d7868dce	[Account.hpp] gnc_account_get_all_parents returns reversed path vector	1 year ago
Alex Aycinena	e8049a6491	Update Form/Schedule line references for 2024 for the US Income Tax Report	1 year ago
peter15914	deee65d0d4	Fix incorrect deallocation type ... Objects created with dom_tree_to_guid must be destroyed with guid_free.	1 year ago
John Ralls	c549e203cb	Bug 799449 - Save As... sequence from SQL to XML format does not... ... clear lock on the origin SQL book. GncDbiSqlConnection::unlock_database function errored out if the last dbi interaction resulted in an error, even if it was a harmless index out of range. Ignore index out of range errors.	1 year ago