1317 Commits (6e9a20dfebca6bbba8d9cfdeb6b4183a3d0fe364)

Author	SHA1	Message	Date
Przemysław Kryger	700f8ca125	Remove ellipses from multiple_quote_sources where lists are complete	2 years ago
Przemysław Kryger	2e734b3239	Add back cse - Colobmo Stock Exchange to single_quote_sources	2 years ago
Christopher Lam	10857219ab	[Account.cpp] refactor acc->balance_limit getters/setters	2 years ago
Christopher Lam	63deaad249	[Account.cpp] use newer qof_instance_get|set_path_kvp ... which do not require GValue dance small modification of xaccAccountSetLastNum behaviour with empty-string last_num	2 years ago
Christopher Lam	c0b2b761e9	[qofinstance.cpp] GValue on stack instead of heap	2 years ago
Christopher Lam	a26a6c4a6f	[qofinstance.cpp] add overloaded qof_instance_set|get_path_kvp ... these overloaded functions to kvp slots do not require GValue	2 years ago
Przemysław Kryger	5fc768711b	Update gnc-commodity.cpp for finance-quote 1.63	2 years ago
Christopher Lam	ecabcef084	[Account.cpp] small modification xaccAccountSetLastNum ... if last-num is empty-string, remove the slot. this makes the behaviour consistent with other slots.	2 years ago
Christopher Lam	d13f930a8c	[Account.cpp] tightening loops, less g_list_free	2 years ago
John Ralls	7b34971c87	Gnc-options-date: Make the accounting period struct tm empty... ... If the accounting period start-choice is anything but absolute instead of matching the accounting period month and day to the present month and day. The latter is a non-obvious hack that depends on gnc_accounting_period_fiscal_start() returning the present day if it's not set.	2 years ago
John Ralls	c584337c3a	Bug 799395 - relative date offset quarters occasionally wrong ... If the accounting period start month and the present month are the same the present month would be offset by 3. Don't do that.	2 years ago
John Ralls	a23506c88a	Add YH Finance (FINANCEAPI) API Key to Quotes infrastructure. ... And add financeapi to known sources.	2 years ago
Christopher Lam	ab641b31f8	[gnc-datetime] improve CSV date parser with ICU and boost ... 1. Add dateformat "Locale" with ICU; uses current locale for date parsing. ICU's locale date parser may parse "3 May 2023" or "2024年9月13日" (LC_TIME=zh_TW.utf8) and maybe others. 2. Augment d-m-y m-d-y and y-m-d with boost UK/US/ISO parsers. This allows CSV import of dates with months as words as "30 Sep 2023" or "May 4, 1978" or "2023-Dec-25". Note boost parser cannot recognise 2-digit years, therefore "30 Sep 24" is invalid.	2 years ago
Christopher Lam	d935edeea5	[gnc-date.cpp] deprecate gnc_difftime ... because it casts time64 to doubles	2 years ago
Christopher Lam	dc84e4d10c	[gnc-pricedb.h] remove unused gnc_pricedb_substitute_commodity	2 years ago
Christopher Lam	1718fa0b6e	[gnc-pricedb.h] remove unused gnc_pricedb_lookup_at_time64	2 years ago
Christopher Lam	a99491d034	[gnc-commodity.h] callers must free g_list ... callers to gnc_commodity_namespace_get_commodity_list and gnc_commodity_table_get_namespaces_list must free the GList.	2 years ago
John Ralls	514793d7a0	Bug 799389 - Crash when removing an account ... Destroying the split vector from front->back crashes halfway through because the iterators aren't updated as we remove items from the vector. Iterating in reverse works because the remaining elements aren't moved as we delete.	2 years ago
Christopher Lam	48f3842eaa	[Account.cpp] compare vectors with std::equal in xaccAccountEqual	2 years ago
Christopher Lam	f65f877098	[Scrub.cpp] don't create intermediate GHashTable and GList ... use unordered_set instead	2 years ago
John Ralls	5fe7a09e7d	Bug 799370 - Transaction Journal view cursor placement after commit to... ... transaction change. This also reverts commit 60ccca017 and fixes Bug 799347 in a different way that avoids the problems found during the investigation of 799370 and reported on gnucash-user.	2 years ago
Christopher Lam	88d8f63853	[Account.cpp] overload gnc_account_foreach_descendant takes std::function ... and separate account_foreach_descendant_sorted	2 years ago
Christopher Lam	5f17334395	[transaction.cpp] use std::swap instead of SWAP macro	2 years ago
John Ralls	60ccca017f	Bug 799347 - Edit account to make it sub account under other account ... Send QOF_EVENT_REMOVE on the child before actually removing it from the children vector so that the stored indexes are valid long enough to clear them.	2 years ago
John Ralls	ad7a51a6ef	Merge Chris Lam's 'acc-children-vector' into stable.	2 years ago
Robert Fewell	8bd7deb3dc	Reapply filter when number of sub-accounts change ... When viewing a register that displays sub-accounts, if the number of sub-accounts is changed, the query is rebuilt from the remaining sub-accounts but when a filter is being used it is not applied after. Fixed by checking the original query for a filter and if so applying that after query rebuilt.	2 years ago
Christopher Lam	a6463f9814	[utest-Account] add more balance limit tests	2 years ago
Christopher Lam	b7fde90411	[Account.cpp] xaccAccountStagedTransactionTraversal copies SplitsVec ... because create_transactions_for_instance which calls xaccAccountStagedTransactionTraversal will modify the splits	2 years ago
Christopher Lam	cd097d19ec	[Account.cpp] don't copy SplitsVec	2 years ago
Christopher Lam	119e257146	[Transaction|Split.cpp] Remove Reg2 unused functions	2 years ago
Christopher Lam	47791734bb	[SX-ttinfo.cpp] tidier, using c++ stl and algo	2 years ago
Christopher Lam	ddc7958801	[~qofchoice.cpp] remove, not useful ... because the options GLists are populated, but are never actually queried. The QOF_TYPE_CHOICE definition is moved to qofclass.h	2 years ago
Christopher Lam	d1807b6c15	[engine.i] move gnc_accounts_and_all_descendants to engine.i	2 years ago
Christopher Lam	6cac9d0ebb	[Account.cpp] priv->children is a vector<Account*>	2 years ago
Daniel Harding	c4d44ea024	Bug 799324 - Invalid free in gvalue_from_kvp_value() ... As of ddc3f28899, gvalue_from_kvp_value() takes a GValue pointer from the caller, which in some cases points to memory on the stack. If that is the case and the code also hits the default case in the switch statement, the unconditional g_slice_free() call will attempt to free stack memory, causing the program to abort. Fix by requiring the caller to always pass in a valid GValue pointer, making the caller responsible for freeing it if necessary. This also means that it is no longer necessary for gvalue_from_kvp_value() to return a value, so make it a void function.	2 years ago
Christopher Lam	6c7abb487d	[SX-ttinfo.hpp] convert to c++ header	2 years ago
Christopher Lam	7dc2e2e6f9	[SchedXaction.cpp] use c++ algo	2 years ago
Christopher Lam	55592efe25	[SchedXAction.cpp] convert to c++	2 years ago
Christopher Lam	109497d471	[SX-ttinfo.cpp] convert to c++	2 years ago
Christopher Lam	5b1bb1186f	[SX-book.cpp] convert to c++	2 years ago
Christopher Lam	e80249ce2b	[Account.cpp] gnc_account_remove_split shortcuts removing last split ... this speeds up book shutdown which empties the account splits in reverse chrono order.	2 years ago
Geert Janssens	c816d2b34f	Doxygen - minor cleanup of gnc-lot.h	2 years ago
Geert Janssens	e8d72ad53f	Doxygen - merge separate txt files into respective header files	2 years ago
Geert Janssens	6cd8e4e458	Doxygen - drop obvious cases of deprecated code	2 years ago
Geert Janssens	da12a212c3	Drop old migration script to split qof from engine	2 years ago
Geert Janssens	39aa5f9c09	Remove texi design document in engine ... It's extremely out of date and we no longer use it to keep track of our design decisions and suggestions. Only a section on KVP policy has been move into kvp_doc.txt as it may make sense there.	2 years ago
Geert Janssens	58b4ee35f0	Doxygen - drop several txt files that were included in ... docygen_mainpage.c None of them had useful information describing actual implementation concepts or details.	2 years ago
Geert Janssens	3c860737f1	Doxygen - fold business.txt file in the respective source files ... The file mostly had short descriptions that were very similar to the descriptions of business objects it referred to. The exception was an explanation of how the billing terms and tax tables handled their immutable copies. That bit has been moved to its own group under the Business group and is referenced from the BillTerm and TaxTables group. This commit also fixes rendering of the Address doxygen info and expands the BillTerm info to explain how proximo due dates work.	2 years ago
Christopher Lam	038405b370	Revert "[account.cpp] gnc_account_remove_split searches from the end" ... This reverts commit 5aff4fb57d. Was not tested properly...	2 years ago
Christopher Lam	5aff4fb57d	[account.cpp] gnc_account_remove_split searches from the end ... because removing the latest split is far more common (e.g. from ui or during book shutdown) than removing an early split.	2 years ago
Christopher Lam	370a06fb61	[qofid.cpp] remove unnecessary struct	2 years ago
Christopher Lam	fe2cdf42c7	[transaction.cpp] speed up book close	2 years ago
Christopher Lam	d21d6f9344	[qofid.cpp] qof_collection_foreach_sorted	2 years ago
Christopher Lam	7b46466ebd	[account.cpp] fix regression caused by 3f7a5a8267 ... whereby deleting an account and moving all splits to another account would segfault. make a copy of priv->splits and work on the copy rather than the original.	2 years ago
Christopher Lam	e54e9d8086	[account.cpp] use HashTable for splits ... reduces xml loading time from 3.5s to 3.1s, i.e. 11% improvement	2 years ago
Christopher Lam	b28ca9bdb4	use c++ placement new ... to initialize non-c++ object members	2 years ago
John Ralls	579da58a10	Merge Gwynn Ciesla's "Allow building with GCC 14.1" into stable.	2 years ago
Christopher Lam	2817ca195f	[test-commodities.cpp] test stability of c_str names	2 years ago
Christopher Lam	f67233b662	Bug 799305 - Crash when there is more than one unknown quote source for commodities ... instead of vector which requires reallocation, use a c++ linked list.	2 years ago
Christopher Lam	d867a9d18a	Merge branch 'TransactionP-hpp' into stable #1928	2 years ago
Christopher Lam	9e4b03f71b	[SplitP.hpp] rename to .hpp	2 years ago
Christopher Lam	1e1d21b716	[Transaction.hpp] rename to .hpp	2 years ago
Christopher Lam	ef8afedd09	[gnc-euro.cpp] use c++isms	2 years ago
Christopher Lam	3bc7ce606d	[gnc-euro.cpp] convert to c++	2 years ago
Christopher Lam	80997ee5b4	[gtest-gnc-euro] add rounding test	2 years ago
Christopher Lam	949c9c97c0	Bug 799300 - Nullpointer exception in gnc_quote_source_s ... avoids constructing std::string with nullptr	2 years ago
Christopher Lam	87dbbf25f8	[account.cpp] add gnc_account_foreach_until_date ... - uses binary search to find first split after date - for_each from earliest split to (but excluding) the above first split	2 years ago
John Ralls	9c18bc889c	Don't use Googletest internal API for unused decls.	2 years ago
Bruce P Schuck	d01aad68fb	Update gnc-commodity.cpp ... Fool.pm not working. Removed references to it from sources JSON structures.	2 years ago
Bruce Schuck	6696bf0a41	Updated QuoteSourceVec to match F::Q v1.59	2 years ago
Christopher Lam	0f791c474a	[Account.cpp][api] gnc_account_foreach_split takes std::function<void(Split*)>	2 years ago
Christopher Lam	871f669a19	[Account.cpp] explicitly destroy priv->splits ... better than 35b6fb767d	2 years ago
Christopher Lam	35b6fb767d	[Account.cpp] ensure priv->splits releases memory on shutdown	2 years ago
Christopher Lam	94368f4cb4	[Account.cpp] SplitsVec&, ensure xaccAccountGetSplitList is freed	2 years ago
Christopher Lam	2b71219766	[Account.cpp] remove obsolete comment	2 years ago
Christopher Lam	1b50c6261a	g_list_free xaccAccountGetSplitList	2 years ago
Christopher Lam	606da28d25	use xaccAccountGetSplitsSize	2 years ago
Christopher Lam	f70ee754fc	use xaccAccountGetSplits and gnc_account_find_split	2 years ago
Christopher Lam	3f7a5a8267	[Account.hpp][API] xaccAccountGetSplits and gnc_account_find_split	2 years ago
Christopher Lam	a54caaab61	[Account.cpp] GetBalanceAsOfDate gets std::function instead of bool	2 years ago
Christopher Lam	cc10b9a0b7	[SX-book.c] tidy for loop ... because splits will need to be g_list_free in a future commit	2 years ago
Christopher Lam	c1ee59c39b	[Account.h] size_t xaccAccountGetSplitsSize returns g_list_length (splits) ... which is easily replaced with vector.size()	2 years ago
Christopher Lam	f08e0f5b61	[policy.cpp] rewrite to avoid goto	2 years ago
Christopher Lam	2251bf8966	[Account.hpp] use std::optional for cached values ... whereby {} denotes uncached values	2 years ago
Sherlock	f0d45de642	Resolve test assert.	2 years ago
Sherlock	8d6f748aca	Bug 799281 - Deleting a transaction may trigger a crash ... Update qof_collection_lookup_entity() to prevent returning instances marked to be destroyed.	2 years ago
Christopher Lam	d100df7ef7	[AccountP.hpp] .h -> .hpp, remove extern "C" {} wrapper	2 years ago
Christopher Lam	a67e4651c3	[Query.cpp] convert to cpp	2 years ago
Christopher Lam	4d9836aac2	[TransLog.cpp] convert to cpp	2 years ago
Christopher Lam	093781c018	[policy.cpp] convert to cpp	2 years ago
Christopher Lam	f913bed7e6	[gnc-engine.cpp] convert to cpp	2 years ago
Christopher Lam	96f041a1d6	[cap-gains.cpp] convert to cpp	2 years ago
Christopher Lam	79b7267cdd	[cashobjects.cpp] convert to cpp	2 years ago
Christopher Lam	67d024c11f	[Scrub3.cpp] convert to cpp	2 years ago
Christopher Lam	6b5a4d7c11	[Scrub2.cpp] convert to cpp	2 years ago
Christopher Lam	ddfa664601	[Scrub.cpp] convert to cpp	2 years ago
Christopher Lam	dab32807ef	[engine/*.cpp] NULL -> nullptr changes ... It's the done thing	2 years ago
Christopher Lam	9a85eb4a2a	[engine/*.h] add extern "C" {} wrappers	2 years ago
Gwyn Ciesla	5132476a2f	Allow building with c++20 and greater/	2 years ago
Christopher Lam	4945db6b7d	[AccountP.h] remove struct members obsolete with 76014f18a0 ... forgot to remove	2 years ago
Christopher Lam	ba403e4a7c	[guid.hpp] GUID::from_string and is_valid_string takes a const char* ... boost::uuids::string_generator has operator()(const char*). thus we can avoid allocating std::string, with a consistent 4% speedup	2 years ago
Christopher Lam	cba7da30fd	[gnc-date.cpp] specialise iso-8601 parsing where TZ=+0000 ... - avoid allocating new TZPtr - parse y/m/d/h/m/s and construct PTime directly - avoid boost's time_from_string which creates an std::string	2 years ago
Christopher Lam	27c16517e9	[gnc-numeric.cpp] shortcut parsing num/denom as gnc_numeric ... The gnc_numeric is serialised as "num/denom" with no whitespace, and denom > 0. This function takes advantage of std::from_chars to parse it. The "num" serialisation is also optimised as a free side effect of this function.	2 years ago
Christopher Lam	11da03bc67	[gtest-gnc-numeric.cpp] test int64 limits for GncNumeric	2 years ago
John Ralls	af18ea598e	Bug 799093 - Cannot reconcile since v5.4 ... Covers the final case where having the reconcile window open and auto-completing a transaction then deleting the transaction before committing it leaves the transaction in the reconcile window. We need to signal that the account is modified even if it isn't because that's what the reconcile window is watching.	2 years ago
John Ralls	2db6988e25	Remove bogus include.	2 years ago
John Ralls	8ebac5b596	Bug 799213 - SIGSEGV caused by revising an auto completed transaction ... Calling xaccSplitDestroy without also calling xaccSplitCommitEdit then deleting the split list before calling xaccTransCommitEdit prevents xaccSplitCommitEdit from being called on the supposedly deleted splits. Not only does this leak them it leaves them in the book potentially with a dangling parent pointer.	2 years ago
Christopher Lam	229d9300cf	[engine-helpers.h] key is a const char* ... thus allowing compilation in cpp with stricter type checking	2 years ago
Christopher Lam	c345fc9d3c	add #ifdef __cplusplus extern "C" {} wrappers to .h files	2 years ago
Christopher Lam	6cb2eeeaa8	Merge branch 'more-engine-cpp' into stable #1866	2 years ago
John Ralls	226bfea108	Fix a bunch of UB errors from ASAN about mismatched function types. ... The casts fool the compiler but not the UB sanitizer.	2 years ago
John Ralls	7bd97f15d0	Fix transaction delete use-after-free, take 2. ... The problem with take 1 was that the duplicate split uses the same lot and account pointers without adding itself to those lists, causing checks in unit tests to fail.	2 years ago
John Ralls	8546aa975e	Revert "Fix two use-after-free issues found by address sanitizer." ... This reverts commit 4dbf803041. The use-after free errors are caused by the compiler reordering the steps in xaccSplitFree and Transaction's do_destroy. Unfortunately the corrections here caused trouble in other places, leading to test failures.	2 years ago
John Ralls	4dbf803041	Fix two use-after-free issues found by address sanitizer.	2 years ago
Christopher Lam	28cc26f207	[gnc-commodities.cpp] gnc_new_iso_codes is a std::unordered_map	2 years ago
Geert Janssens	00640f9ded	Replace naked for loops with C++ algorithms	2 years ago
Geert Janssens	0732436e44	A few NULL/nullptr related cleanups	2 years ago
Christopher Lam	17f422f97c	[gnc-commodity.cpp] convert quote_sources to vector ... - all quote sources are now vector - get_quote_source_from_type to convert QuoteSourceType to vector<gnc_quote_source> - the quote sources are modifiable, therefore cannot be const: see gnc_quote_source_set_fq_installed	2 years ago
John Ralls	266ae2a931	Bug 798946 - start/end of current/last quarter have off-by-one error ... Calculating the quarter offset when the current month is less than the beginning month of the fiscal year was inverted.	2 years ago
Christopher Lam	164453a858	[gnc-commodity.cpp] gnc_quote_source_get_index searches index ... we can now remove init	2 years ago
Christopher Lam	5d16d025a6	[gnc-commodity.cpp] gnc_quote_source_s is a cpp class ... ... this ensures the new_quote_sources vector now doesn't leak anymore.	2 years ago
Christopher Lam	346499ae04	[gnc-commodity.cpp] gnc_quote_source_set_fq_installed takes a StrVec ... instead of a GList* of strdup'd chars	2 years ago
Christopher Lam	47a1a56f16	[gnc-commodity.cpp] fq_version is a std::string ... thus can free itself on exit	2 years ago
Christopher Lam	f49c2735e3	[gnc-commodity.cpp] initialize quote_sources at compile-time	2 years ago
Christopher Lam	d488faacb2	[gnc-commodity.cpp] Convert to cpp	2 years ago
Vincent Lucarelli	f5b7bf3401	removed old_internal_name from gnc_quote_source_s (deprecated)	2 years ago
Christopher Lam	9035391907	[test-commodities.cpp] add some tests for gnc_quote_sources	2 years ago
Christopher Lam	03c5309666	[gnc-lot.cpp] convert to cpp	2 years ago
Christopher Lam	7d8d8f83be	[Recurrence.cpp] convert to cpp	2 years ago
Christopher Lam	783c3df3c0	[Transaction.cpp] convert to cpp	2 years ago
Christopher Lam	fc5d7f872e	[Split.cpp] convert to cpp	2 years ago
Christopher Lam	698cc23051	Add #ifdef __cplusplus extern "C" {} wrappers to .h files	2 years ago
Christopher Lam	928f9245e6	[gtest-gnc-numeric] add operator comparisons ... with example int64 numbers	2 years ago
Christopher Lam	9782918586	[account.cpp] add more account metadata - assoc account ... the tag denotes the type of associated account eg. "dividend" "capgains" "cash" "fees"	2 years ago
John Ralls	c87d480b0d	Move gnc_list_formatter from gnc-date to gnc-ui-util. ... It has nothing at all to do with dates.	2 years ago
John Ralls	b2fa3ef106	Bug 799210 - Bad encoding of accented chars in account names in... ... "Import CSV" wizard In MSWin the UnicodeString(char*) ctor assumes that the input string is encoded in the current codepage, but the input to gnc_list_formatter is encoded in UTF8. Use the static class function UnicodeString::fromUTF8 instead.	2 years ago
John Ralls	e22a57ad26	Merge John Ralls's 'asan' into stable.	2 years ago
John Ralls	6834cb5025	Implement coverage option ... To use pass -DCMAKE_BUILD_TYPE=Debug or Asan -DCOVERAGE=ON and build as usual, then do ninja lcov-initialize && ninja check && ninja lcov-collect. The result will be a directory, <Builddir>/Coverage containing lcov tracefiles, including an aggregate file gnucash.info which you can use for further processing. It will also report an overall summary. Note that only C/C++ files are included. There's one more target, lcov-generate-html, that you can run after lcov-collect. It will generate a simple website in <Builddir>/Coverage-HTML showing coverage by source directory (the directories in <Builddir> have coverage for generated files). Each directory path is a clickable link to a page that shows coverage for each source file; the filenames link to a page for each showing which lines have been exercised.	2 years ago
John Ralls	6bc12898a8	GncDate: Remove now-superfluous base parameter.	2 years ago
John Ralls	1e289cb2b8	GncDate: Remove pointless normalize_month function. ... Suggested by Sherlock.	2 years ago
John Ralls	966cef19aa	Bug 799156 - normalize_struct_tm() does not normalize seconds,... ... minutes, and hours correctly. Fix proposed by Sherlock.	2 years ago
John Ralls	5005c3cac8	Merge Sherlock's 'bug799151' into stable.	2 years ago
Sherlock	ae8492d73a	Update test-gnc-date.c	2 years ago
Sherlock	5a7b6e9814	Bug 799151 - gnc_date_get_last_mday () does not account for,,, ... leap years correctly.	2 years ago
Sherlock	07e94b4222	Bug 799152 - normalize_reldate_tm() does not handle dates with... ... months greater than 11 or less than -11 correctly.	2 years ago
John Ralls	d8dacb86b2	Bug 799143 - FTBFS on 32bit architectures ... Fix misuse of GUINT_TO_POINTER in 5e09b66.	2 years ago
John Ralls	92de074e49	Bug 799144 - Date Completion is broken after 5.4 upgrade ... strptime will reasonable return false for an incomplete date but it still fills in the parts of the struct tm that it understands, so bail out of qof_scan_date_internal when it fails only if all three fields are present.	2 years ago
John Ralls	ed4921271c	Bug 799134 - Fails to build with GCC 14 (‘find_if’ is not a member... ... of ‘std’; did you mean ‘find’)	2 years ago
Christopher Lam	1d26d99ddb	[gnc-budget] use std::optional<gnc_numeric> instead of bool+gnc_numeric ... more expressive	2 years ago
John Ralls	dd0b72cdb5	Fix global array index out of range. ... Tests must set the account type to avoid errors in xaccAccountOrder.	2 years ago