13 Commits (4f655492cef214b3a6d6033adc05091eab791ccd)

Author	SHA1	Message	Date
Christopher Lam	7ce4198c20	rename string_to_gnc_numeric to gnc_numeric_from_string	3 years ago
Richard Cohen	958e9a4d6f	Valgrind: fix "Invalid read" in test-exp-parser ... The pointer passed to the gfec exception handler is not valid after the exception handler ends ==382525== Invalid read of size 1 ==382525== at 0x484B050: memcpy@GLIBC_2.2.5 (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==382525== by 0x531AB67: __printf_buffer_write (Xprintf_buffer_write.c:39) ==382525== by 0x5322CD4: __printf_buffer (vfprintf-process-arg.c:501) ==382525== by 0x53465F3: __vasprintf_internal (vasprintf.c:102) ==382525== by 0x499C8C1: g_vasprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==382525== by 0x4969BE0: g_strdup_vprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==382525== by 0x494B2F6: g_logv (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==382525== by 0x494B7A2: g_log (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==382525== by 0x4862862: func_op (gnc-exp-parser.c:342) ==382525== by 0x485D381: primary_exp (expression_parser.c:1222) ==382525== by 0x485CE0F: multiply_divide_op (expression_parser.c:1028) ==382525== by 0x485CC33: add_sub_op (expression_parser.c:968) ==382525== Address 0xad387ec is 764 bytes inside a block of size 766 free'd ==382525== at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==382525== by 0x4861D9B: gfec_apply (gfec.c:145) ==382525== by 0x4862813: func_op (gnc-exp-parser.c:339) ==382525== by 0x485D381: primary_exp (expression_parser.c:1222) ==382525== by 0x485CE0F: multiply_divide_op (expression_parser.c:1028) ==382525== by 0x485CC33: add_sub_op (expression_parser.c:968) ==382525== by 0x485C9DE: assignment_op (expression_parser.c:886) ==382525== by 0x485C101: parse_string (expression_parser.c:605) ==382525== by 0x4862F07: gnc_exp_parser_parse_separate_vars (gnc-exp-parser.c:535) ==382525== by 0x4862D60: gnc_exp_parser_parse (gnc-exp-parser.c:475) ==382525== by 0x10A963: run_parser_test (test-exp-parser.c:94) ==382525== by 0x10AB99: run_parser_tests (test-exp-parser.c:144) ==382525== Block was alloc'd at ==382525== at 0x4843738: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==382525== by 0x4A81473: scm_realloc (in /usr/lib/x86_64-linux-gnu/libguile-3.0.so.1.5.0) ==382525== by 0x4AEEF70: scm_to_utf8_stringn (in /usr/lib/x86_64-linux-gnu/libguile-3.0.so.1.5.0) ==382525== by 0x55AA71F: gnc_scm_to_utf8_string (gnc-guile-utils.c:42) ==382525== by 0x4861D4E: gfec_apply (gfec.c:136) ==382525== by 0x4862813: func_op (gnc-exp-parser.c:339) ==382525== by 0x485D381: primary_exp (expression_parser.c:1222) ==382525== by 0x485CE0F: multiply_divide_op (expression_parser.c:1028) ==382525== by 0x485CC33: add_sub_op (expression_parser.c:968) ==382525== by 0x485C9DE: assignment_op (expression_parser.c:886) ==382525== by 0x485C101: parse_string (expression_parser.c:605) ==382525== by 0x4862F07: gnc_exp_parser_parse_separate_vars (gnc-exp-parser.c:535)	3 years ago
John Ralls	758bd7b656	Merge branch 'maint'	6 years ago
Christopher Lam	6de712b501	[gnc-exp-parser] don't crash when gnc:fn returns non-number ... if gnc:fn returns anything other than a number, abort rather than crash	6 years ago
Geert Janssens	90aa539908	app-utils - make gnc-expression-parser responsible for its own cleanup ... It already ensured it would initialize on first use. It can as well register the hooks it needs for its cleanup directly itself instead of depending on the module loading system to do so.	6 years ago
Geert Janssens	53f59f7794	RptCleanup - Restructure installation of gnucash scm files ... These files were installed fairly ad-hoc into the share/gnucash/scm directory making it hard to get an idea of where each file comes from. The files are now structured as follows: - any scm file authored by gnucash should go in share/gnucash/scm/gnucash or below - most scm modules will be directly in that directory - each module that comes with support files will get a subdirectory named after the module's base name. For example next to engine.scm there will be directory named engine for all support files of the engine module - scm files that are not modules, but are loaded by modules go into <module-dir>. For example gnc-utils.scm loads gnc-menu-extensions.scm so that file will be installed in gnc-utils/gnc-menu-extensions.scm - the report system is our largest module and only part of the restructuring is done at this point. It will be refined further in future commits. The same restructuring is also done for the compiled files.	7 years ago
John Ralls	bf55c30aeb	Fix most of the unused assignment errors from static analysis. ... There are a very few left that need deeper study, but this gets rid of most of the noise. For the most part it's just getting rid of extra variables or removing an assignment that is always replaced later but before any reads of the variable. A few are discarded result variables.	8 years ago
John Ralls	faba7975ac	Fix a bunch of memory allocation errors found by clang static analysis.	8 years ago
John Ralls	720acddff2	Restore fin.scm, incorrectly removed earlier. ... But put it in app-utils where it's used and load it explicitly.	8 years ago
Geert Janssens	a784dd5784	Add support for guile 2.2	8 years ago
Geert Janssens	1238b9d8cd	Prevent gcc from searching config.h in the current directory ... This will avoid a ninja-build from picking up a config.h generated by the autotools build (in the root build directory). Picking up the wrong config.h may lead to all kinds of subtle issues if the autotools run was done with different options than the cmake run.	9 years ago
Geert Janssens	ae75bc963f	Rewrite several file path routines to use boost::filesystem ... This is a basis for moving .gnucash to a more modern location for application specific user data (following the xdg spec).	9 years ago
Geert Janssens	83d14e1c1c	Restructure the src directory ... It is split into - /libgnucash (for the non-gui bits) - /gnucash (for the gui) - /common (misc source files used by both) - /bindings (currently only holds python bindings) This is the first step in restructuring the code. It will need much more fine tuning later on.	9 years ago