gnucash

Commit Graph

Author	SHA1	Message	Date
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit `a8e6a59`	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. Xcode-13.3 errors without it.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	759376eb13	c++options: Fix multicolumn report	4 years ago
John Ralls	b5d0c42505	c++options: Put copyright and FSF header comment on gnc-optiondb.i.	4 years ago
John Ralls	e9b850cca5	c++options: Correct Scheme serialization of type bool.	4 years ago
John Ralls	66f9fc81c7	c++options: Implement serialization for GncOwner.	4 years ago
John Ralls	0ce841d4ce	c++options Fix Scheme bindings for QofQuery options.	4 years ago
John Ralls	216b483e26	c++options SCM bindings Rewrite save_scm_value to branch on type. Instead of GncOptionUIType, mostly. We still need to do that to tell apart commodities and currencies from other QofInstances. Allows compile-time dispatch for most types.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. The saved option files being Scheme executables.	5 years ago
John Ralls	00c2e99d2e	Convert the Scheme RelativeDatePeriod lookup table to a std::vector. From a Scheme alist. The vector can be used to find the scheme symbol as a direct lookup, which isn't possible with an alist, and can be searched for the Scheme symbol match more quickly than an alist can.	5 years ago
John Ralls	bed44f404f	Remove the always questionable Scheme generation and parsing code. It's more reasonable to do that in Scheme than in C++.	5 years ago
John Ralls	a487ca3f98	Improve template conditional readability with custom traits values.	5 years ago
John Ralls	10381d42e0	Fix color option handling. Read and write color options the way legacy code does. Pass only values with no alpha to gdk_rgba_parse because it fails if a hex-string has alpha.	5 years ago
John Ralls	3d1812aacd	Explicitly cast a value to the decltype of get_value(). Can't always rely on implicit conversion working.	5 years ago
John Ralls	474bc360f4	Improve converting vectors to SCM lists.	5 years ago
John Ralls	1cd2cf211c	Specialize QofInstance* options set_value, catch validation exceptions. GncOptionValue<const QofInstance>.get_value() returns a QofInstance but reports store them as strings, either commodity mnemonics or GUIDs. Specialize set_value/set_default_value from scheme to handle those possibilities. GncOptionValidatedValue throws an invalid_argument exception if it's fed an invalid argument. Catch that so that it doesn't crash the program.	5 years ago
John Ralls	1af97ebb9a	Implement registering/unregistering/calling change callbacks. Drives reloading the report when the Apply or OK button is pressed.	5 years ago
John Ralls	0f02236ebe	Fix gcc warnings.	5 years ago
John Ralls	18997db720	Separate GncOptionAccountValue into GncOptionAccountListValue and GncOptionAccountSelValue. They have different get_value() return types so can't cohabit comfortably.	5 years ago
John Ralls	05ac056449	Make separate option type for GncOwner. GncOwner is not a QofInstance subclass.	5 years ago
John Ralls	67dab6b320	Remove business-options.scm and business-prefs.scm. Their functions have been reimplemented elsewhere.	5 years ago
John Ralls	a1af86ed40	Implement gnc:generate-restore-forms, gnc-optiondb-save-to-scheme.	5 years ago
John Ralls	bbe74aa086	Remove tooltips from multichoice option values. This is the c++options equivalent to `02a6a0ae` and `e1525721`.	5 years ago
John Ralls	52ef53a405	Implement multichoice selection options.	5 years ago
John Ralls	27670a6e98	Make the 'pixel and 'percent SCM symbols C++ constants. Improves efficiency and conciseness.	5 years ago
John Ralls	f66a918be4	Implement GncOptionValue<const QofQuery*> QofQuery isn't a QofInstance and doesn't have a GUID.	5 years ago
John Ralls	0a8f66ee90	Fold GncOptionGncOwnerValue into GncOptionValue<const QofQuery*>. Reflecting the way Scheme options handles it.	5 years ago
John Ralls	7d0cdf7c94	Handle #f input to option typemap(in)s.	5 years ago
John Ralls	86a2f1551f	Implement gnc-make-date-option.	5 years ago
John Ralls	693e966bf9	Extract Scheme date handling functions and apply them. Including in RelativeDatePeriodVec typemap, making it work correctly.	5 years ago
John Ralls	42185c0ec8	typemap for std::size_t Unaccountably missing from swig_guile.	5 years ago
John Ralls	5c74337810	Add function GncOption::set_default_value. Allows reports to derive from other reports and then change the option default values to suit. If they change only the values and not the defaults then it's possible to create saved report configs that don't include the options whose values are changed to the base report's default value. See https://bugs.gnucash.org/show_bug.cgi?id=642292.	5 years ago
John Ralls	e7309f077b	Replace gnc_make_option<gnc_commodity> with gnc_make_commodity_option. To handle cases where we try to create commodity options with a symbol as the default instead of a gnc_commodity.	5 years ago
John Ralls	3aa86ca992	QofInstance* needs a typemap to match the from/to SCM logic.	5 years ago
John Ralls	4a305998e4	GncOptionDateValue set_value_from_scm: 'else' required.	5 years ago
John Ralls	43cd81ba78	Fix a couple of RangeValue retrieval issues.	5 years ago
John Ralls	9bd3baff63	Change the reldate_values alist from a static to a singleton. A static has to be initialized at library load and Guile isn't necessarily running then. The singleton gets evaluated at runtime only if the getter is called from Guile.	5 years ago
John Ralls	534a7c2893	GncOptionMultichoiceValue allow setting a default selection. Instead of arbitrarily using the first allowed value. Also update tests for the Scheme type addition to GncMultichoiceOptionChoices, intercept more cases where the value needs to be transformed, and go back to emitting a string instead of throwing in GncOptionMultichoiceValue::get_value when m_values has more than one value.	5 years ago
John Ralls	c62b526ba0	Implement scm_to_value<bool>.	5 years ago
John Ralls	efc7346490	Implement scm_to_value<GncOptionAccountList>.	5 years ago
John Ralls	f20c358ce1	Return a pair in scheme for GncOptionRangeValue<int>. This is a bit of a hack to handle PlotSize options. They're the only RangeValues that use ints; the rest use doubles because the control is a GtkSpinButton and that uses doubles. The chart code expects a pair with either 'pixel or 'percent saying what to put in front of the number. We hack that too: if value <= 100 then it's percent because 100px is about 3cm on modern monitors and 15mm on HiDPI ones. Bigger numbers are pixels.	5 years ago
John Ralls	b5c0477143	Use the SWIGGED pointer for the SCM value of QofInstance* Values. This effectively reverts b7dd7f. Note that two cases aren't handled because the types aren't GObjects and so don't have type macros to decipher them: GncOwner and QofQuery. Since they're not GObjects they're obviously not QofInstances either and we need to rethink this value type a bit.	5 years ago

1 2

100 Commits (47904a858ea10aeeb4fbf8deade1d2cfa320736f)