847 Commits (341f2102635c73858d2abba05ab0e0990c47ecaf)

Author	SHA1	Message	Date
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. ... Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. ... Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups ... - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq ... That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor ... The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch ... And add a third overload to fetch only a single quote	4 years ago
Geert Janssens	bf357315fd	finance-quote-wrapper - implement check and fetch in one file via command line switches ... This obsoletes gnc-fq-check as the same function can now be performed with 'finance-quote-wrapper -v'	4 years ago
Geert Janssens	fbf9aecd25	Use GncQuotes in transfer dialog	4 years ago
Geert Janssens	a00bce168c	GncQuotes - cache default currency	4 years ago
Geert Janssens	fcbe6cf10c	Add code to parse json data returned by our F::Q wrapper ... This code will convert the json data into GncPrice objects and add them to the pricedb, effectively doing what price-quotes.scm does. A few notable remarks: - still requires plenty of cleaning up. This is the first proof of concept - like the original scm based code, this parser completely ignores timezone information. As it wasn't used before and nobody complained, it may not be that important. Or it can be implemented later. - price-quotes.scm would first check if a price already existed in the pricedb and try to update that one instead of adding one (only if the old price's type is inferior). However that is redundant as gnc_pricedb_add_price does the same check. So I have omitted this extra check from GncQuotes. - currency quotes can be inverted. I have slightly changed the way to handle this. The perl wrapper code will simply set an "inverted" flag in that case, but will otherwise not swap currency and commodity as it used to be the case. On parsing, the inversion flag will cause the GncNumeric that's parsed from the price to be inverted. As it's still a GncNumeric that shouldn't result in any loss of precision, while keeping prices in the db always in the default currency.	4 years ago
Geert Janssens	6ecc1ef73f	GncQuotes - switch to Pimpl idiom ... That allows the private implementation to pass a number of variables based on various boost libraries. It's better to not have them in the public interface to keep compilation times down.	4 years ago
Geert Janssens	65ae46426b	GncQuotes - add parameterized construction ... For all but the basic check a book is required. Might as well be able to pass it directly and store a reference to it. That will simplify member function declarations.	4 years ago
Geert Janssens	3685e5de73	Factor out the async call to perl ... This will allow us to reuse it for several F::Q commands, like check, fetch,...	4 years ago
Geert Janssens	6ce91d7f49	Drop the single quotes instance code for now ... I have been reading on singleton implementations and there appears to be a lot of pushback against those. We can revisit this if it turns out performance degrades significantly by running the F::Q check multiple times.	4 years ago
Geert Janssens	616a672d52	Rewrite boost::process call to properly capture both stdout and stderr ... The previous version of the code could only capture one but not both at the same time.	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
Geert Janssens	1d94887a0b	Rewrite gnc_commodity_table_get_quotable_commodities as gnc_quotes_get_quotable_commodities ... It only makes sense in that context.	4 years ago
Geert Janssens	466db526b2	Move source files for GncQuotes to app-utils ... It will depend on functions in that library. This can probably be fixed by cleaning up app-utils, but that's not the topic of this feature.	4 years ago
John Ralls	283a5b7ce9	Fix dist, files moved	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
John Ralls	f24f29830b	[options] Change std::cerr stream output to PWARN. ... Remove temporary diagnostic.	4 years ago
Christopher Lam	3e02859277	Merge branch 'maint'	4 years ago
Christopher Lam	b7a3652de7	[date-utilities] avoid report crash if start>end date	4 years ago
John Ralls	087501d316	Bug 798262 - Scheduled transactions with blank amounts do not get created. ... Handle template transactions that don't have any splits with empty credit and debit strings and those having no set transaction account. Set the concrete transaction commodity to the first found of: The template transaction's commodity The commodity of the first split with a credit or debit string The commodity of the first split.	4 years ago
John Ralls	410db42df0	Test case where the template txn doesn't have a set currency.	4 years ago
John Ralls	229f6f5e85	Fix gdate adjustments.	4 years ago
Simon Arlott	4c1fc1d555	Bug 798262 - Add test case for basic scheduled transactions ... Test these scheduled transactions: * 2 splits with fixed amounts "123" * 2 splits with fixed amounts "0" * 2 splits with empty amounts "" Verify that automatically created scheduled transactions exist.	4 years ago
Christopher Lam	6ba912ee0d	Merge branch 'maint'	4 years ago
Christopher Lam	de7a63082b	[gnc-sx-instance-model] leaks: free temporal_state ... it's a simple struct containing GDate and int	4 years ago
Christopher Lam	ad27be333e	[gnc-sx-instance-model] prepend GList loops instead of append	4 years ago
John Ralls	8b07ac88cd	[options] Add "key" to the register-option documentation blocks.	4 years ago
John Ralls	e29ab5336f	[options] Remove key and doc_string from gnc_register_query_option. ... It's always used as an internal option with no UI component so it doesn't use them.	4 years ago
John Ralls	6faaf3b427	[options] Provide a const char* value flavor for register_commodity ... And register_currency_option	4 years ago
John Ralls	1ff844c195	[options] Fix implementation of gnc_register_owner_option ... To take an owner-type parameter and to set the UIType accordingly.	4 years ago
John Ralls	aa0b0921f4	[options] Add a function to check if an option is internal. ... Instead of relying on the legacy underscore-section-name hack.	4 years ago
John Ralls	da0eff2cac	[options] Implement widget-changed callbacks. ... Enables full functionality for complex-boolean and multichoice-callback options. Note that setter-function callback isn't used in any GnuCash code so it is not implemented and is not present in the register-callback functions.	4 years ago
John Ralls	552aa438ff	[options] Implement gnc_register_internal_option.	4 years ago
John Ralls	0e9ed8cf0a	[options] Provide float variants to gnc_register_plot_size_option.	4 years ago
John Ralls	0213787a2f	[options] Enable registering an absolute date option.	4 years ago
John Ralls	cf2870b71a	[options] Change RelativeDate and Multichoice index type to uint16_t. ... From size_t because clang thinks that std::is_same_v<size_t, time64> is true and we need to differentiate the handling of the two.	4 years ago
John Ralls	0b2d14ee72	Fix distribution for expressions target.	4 years ago
Christopher Lam	b94440b16a	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	ea56d67797	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	bfa0fd1819	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	f0ac8d69b2	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	67a1b7a873	[gnc-sx-instance-model] free GHashTable keys when destroying	4 years ago
Christopher Lam	ebf3439558	[gnc-sx-instance-model] free some GHashTable keys & Values	4 years ago
Christopher Lam	7c2a249511	[gnc-sx-instance-model.c] refactor Scrub function ... This scrubbing function calls xaccTransRollbackEdit which is leaky. Instead of trying to fix xaccTransRollbackEdit which requires superhuman skills, it's easiest to track the changes separately in a GList, and use xaccTransBeginEdit/xaccTransCommitEdit only if necessary.	4 years ago
Christopher Lam	c16840b840	more leaks because qof_instance_get returns a new char*	4 years ago
John Ralls	f4c27d4494	Move gnc_ui_account_get_tax_info_string to gnc-locale-tax.c ... To prevent a circular dependency between libgnc-app-utils and libgnucash-guile.	4 years ago
John Ralls	3e2f7bc66a	Create separate shared library for expression parser and SX instance model. ... These functions depend on both libgnc-app-utils and libgnucash-guile, creating a circular dependency when the app-utils bindings are added to libgnucash-guile.	4 years ago
John Ralls	47904a858e	Fix distcheck in master. ... Several gnc-optiondb dependencies left out of tarball.	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	564d73a553	Bug 798531 - Selecting "Print" from the file menu on a report... ... crashes gnucash Ensure that every call to gnc_prefs_get_string correctly handles both a NULL or empty string return value without crashing or leaking.	4 years ago
Christopher Lam	a5cae6c5eb	Don't export undefined functions	4 years ago
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos ... With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit a8e6a59	4 years ago
Robert Fewell	db6a8f809b	Tax Tables combo does not set the active one ... Fixed by correcting spelling of tax table qof type, should 'gncTaxTable'. Also fixed setting tax table combo to 'none' when page reset button used.	4 years ago
Robert Fewell	0b67a91217	Fix the option GncOptionRangeValue ... The GncOptionRangeValue can be used with integers or doubles, the default being doubles. When used for setting the plot width/height, integers are used so all ValueTypes need to be integers other wise the when create_range_spinner is used you end up with the upper_bound value being G_MAXDOUBLE, a 309 character wide spin button. To differentiate the two, use 'set_alternate(true)' for integers.	4 years ago
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting ... The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. ... Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. ... In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes ... For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Robert Fewell	ae220b86a4	[C++options] Fix Ubuntu test failure.	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	29bdd9b526	[C++options] Fix Ubuntu test failure.	4 years ago
John Ralls	1fddf70e21	[C++options] Fix previous month and previous quarter at the end of March ... . Because March has more days than February the previous month offset was getting normalized back to the current month--th 29 February this year is really 1 March, so normalizing before setting the day caused begin/end previous month to return the begin/end of the current month. That probably happened on the 31st of May, July, October, and December as well, I just hadn't managed to test on those days. Switching the normalization to after calculating the day of the month broke the previous quarter calculation because now the month was out of range, so normalize month & year first.	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. ... No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. ... For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
Christopher Lam	cf1282501e	Use original guile variable names changed in #1073 ... The changes 09296dfb96, 1373233cd0 and 189db58e6 had caused inconsistencies. Best restore original guile variable names using underscore, bound to strings instead of functions returning strings.	4 years ago
Christopher Lam	5993ebf4d4	Merge branch 'maint'	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. ... Xcode-13.3 errors without it.	4 years ago
John Ralls	572cb6b1d1	Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp. ... Puts it closer to its points of use and removes it with its Scheme dependency from libgnucash.	4 years ago
John Ralls	e63baa6270	Merge Bob Fewell's 'rtl' into maint.	4 years ago
Robert Fewell	f8fc796c95	Bug797501 - Currency symbols in Hebrew (RTL) language ... When Gnucash is run in Hebrew which is a RTL language, on the accounts page the tree view is displaying the required number as the following... TreeView entry is '1,500.00 ₪' or '-1,500.00 ₪' TreeModel string is '₪ 1,500.00‬' or '₪ 1,500.00-‬' This seems to be down to the GTK 'Unicode Bidirectional Text Algorithm' which is changing the representation of the model string based on the first strongly typed character, in this case the Israeli shekel sign. To fix this, when creating the displayed monetary amount insert a BiDi ltr isolate uni-character at the start of the string.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. ... Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	09296dfb96	Drop commodity-table.scm, no longer required after adjusting qif-dialog-utils	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. ... Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	65bd860249	Fix relative_date_to_time64 calculations. ... Where the date requested extends beyond the start or end of the year.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. ... That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	11225d9741	c++options: Remove gnc:options-data	4 years ago
John Ralls	16dc15964c	c++options: Remove the callback registration functions.	4 years ago
John Ralls	759376eb13	c++options: Fix multicolumn report	4 years ago
John Ralls	18edc17541	c++options remove stray debugging comment.	4 years ago
John Ralls	b5d0c42505	c++options: Put copyright and FSF header comment on gnc-optiondb.i.	4 years ago
John Ralls	a700701cd3	c++options: Remove three unused test functions. ... Scheme serialization is now tested in test-option-gnc-scheme-output.scm.	4 years ago
John Ralls	eb0bd4f998	c++options: Remove unneeded C++20 header and resolve ambiguous call.	4 years ago
John Ralls	a3f50586df	c++options: More thorough testing of scheme serialization.	4 years ago
John Ralls	6cd88c230c	c++options: Create bool or string internal options when possible. ... There's no need to save internal options as SCM when we support the underlying type in C++.	4 years ago
John Ralls	e9b850cca5	c++options: Correct Scheme serialization of type bool.	4 years ago
John Ralls	66f9fc81c7	c++options: Implement serialization for GncOwner.	4 years ago
John Ralls	0ce841d4ce	c++options Fix Scheme bindings for QofQuery options.	4 years ago
John Ralls	216b483e26	c++options SCM bindings Rewrite save_scm_value to branch on type. ... Instead of GncOptionUIType, mostly. We still need to do that to tell apart commodities and currencies from other QofInstances. Allows compile-time dispatch for most types.	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	947c061989	C++options: Create QofQueryValue trait.	4 years ago
John Ralls	f26014a04e	c++options: QofInstanceValue: Protect against crashes when m_value is nullptr.	4 years ago
John Ralls	95b973f792	Bug 798352 - Decimal Precision when Entering Mutual Fund Transaction ... Let xaccParseAmount parse up to 12 decimal places instead of 8.	4 years ago
Christopher Lam	33b6dfc6ce	[options.scm] addendum ca6604c93 gnc:make-budget-option ... selection-budget changed from budget object to guid, handle other uses as appropriate.	4 years ago
Christopher Lam	ca6604c93c	[options.scm] Addon previous commit... need to initialize with guid	4 years ago
Christopher Lam	5a812ca1eb	[options.scm] gnc:make-budget-option stores guid instead of object ... because object may become stale if UI is used to delete it, leading to stale pointer and segfault. storing guid is safer, and will return null if budget is deleted.	4 years ago
Christopher Lam	91b1d291a5	[3/3][gnc-ui-util.c] Remove unused functions ... These functions were used to (optionally) reverse amounts according to whether the feature GNC_FEATURE_BUDGET_UNREVERSED was set. They are now obsolete because code will now assume feature is set for all loaded datafiles.	4 years ago
John Ralls	269249378f	c++options fix setting account-selection widget from option.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. ... And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
John Ralls	dd7feb9988	options.scm: Remove second license comment.	5 years ago
John Ralls	74fd716afb	Clarify gnc_relative_date_to_time64 helper functions.	5 years ago
John Ralls	f6c9e63e3d	Fix PR comments so far. ... Except for gnc-option-date's normalize_tm and set_day_and_time.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	96b09ded9f	Doxygen documentation for new options classes.	5 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. ... The saved option files being Scheme executables.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	f813f7cd14	[gnc-autoclear] Move autoclear algorithm into gnome-utils	5 years ago
Geert Janssens	bdb06479e8	GSettings - fix GObject warning when old prefs-version is unset ... This will happen when current master (future 5.0) has been run at least once.	5 years ago
Geert Janssens	09b3ce2382	Revert "Add structure to map migrated preferences to old ones" ... This reverts commit c6103a5c17.	5 years ago
Geert Janssens	806d0b3157	Revert "GSettings - make most of the api private" ... This reverts commit 26b2d7ca78.	5 years ago
Geert Janssens	1d4673ed2a	Revert "GSettings - rework internal helper functions to use more C++" ... This reverts commit 24fa289952.	5 years ago
Geert Janssens	24fa289952	GSettings - rework internal helper functions to use more C++	5 years ago
Geert Janssens	26b2d7ca78	GSettings - make most of the api private ... All preference calls should happen via the gnc_prefs_... apis. The gnc_gsettings_... apis are an internal implementation of this.	5 years ago
Geert Janssens	c6103a5c17	Add structure to map migrated preferences to old ones ... This can be used to keep both in sync in the period between initial migration and eventual obsolence. Note only non-obsoleted, migrated preferences are tracked. We don't want to resync preferences that have been obsoleted (reset). That would nullify the whole idea of making them obsolete for future removal. This commit only adds the mapping, synching will follow in a future commit.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
Geert Janssens	9a465fc359	GSettings - add 'deprecate' and 'obsolete' conversions for user preferences ... 'deprecate' is technically a noop. It serves to remind maintainers the 'deprecated' preference is to be obsoleted in the next major release. 'obsolete' goes one step further in that it will cause gnucash to reset the preference, effectively clearing the value stored in the preferences backend. This is the final phase of a preference. Following this it will be completely removed from the GSettings schema in the next major release. Notes * 'deprecate' and 'migrate' are related. Both are a reminder the preference is to be obsoleted in the next major release. 'deprecate' does only that though while 'migrate' will also trigger a copy of the old value to a new location in the databse. * This commit readds a couple of preferences that had been removed in the past to be able to properly obsolete them (and to test the obsoleting code)	5 years ago
Geert Janssens	64576f7d27	GSettings - widen scope from 'migration' to 'transformation' ... This commit mostly changes descriptions and variable names to use the more generic terms 'transformations' or 'conversions'. 'migration' is only one possible transform, future commits will add others. There are no functional changes in this commit other than a logic inversion in parse_one_release_node. It now checks for nodes named 'migrate' rather than for nodes not named 'migrate' (the code is adapted accordingly to match this logic change).	5 years ago
John Ralls	29e7b07ed3	Remove superflous schema_source left over from pasting.	5 years ago
John Ralls	8bfa5a63f2	[gsettings] Avoid crash from settings schema not being registered.	5 years ago
Geert Janssens	2a7566cc40	Win32 - drop conditional code never reached ... We had hardcoded HAVE_HTMLHELPW to always be true so the fallback code that's only reached when it is false was never reached. Time to drop this dead code.	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Geert Janssens	8ea52ae212	GSettings - run data model transations while setting up ... This makes sure all schema changes are in effect before the first consumer can query them. For example this will prevent a one-time re-occurrence of the tip of the day dialog the first time the new migrations are run.	5 years ago
Geert Janssens	f1802b6fdf	GSettings Upgrade - add code to migrate settings ... The rules for migration are read from an xml file. This file was prepared in a previous commit. Future settings 'data model' changes can reuse this code by simply adding migration rules in the xml file. This replaces the hardcoded rules that were currently in place to migrate a few settings from 2.6 and older to 3.0. These rules are no longer meaningful as we require users to migrate from one major release series to the immediate next one. So by the time the new migration rules in this commit are applied by users they should already have run gnucash 3.x at least once. That run should have taken care of the pre-3.0 migration actions.	5 years ago
Geert Janssens	f21c7b6e90	GSettings - define old prefix and check settings for the presence of both prefixes while normalizing	5 years ago
Geert Janssens	a203c5b2d5	GSettings - drop logic to relocate our settings ... This was ported from GConf, but GSettings doesn't work that way. Settings locations are defined at compile time and can't be relocated at run time (unless you make all of the settings explicitly relocatable. That however is not how GSettings is meant to be used.)	5 years ago
Geert Janssens	d1113a4534	GSettings - build as cpp	5 years ago
Geert Janssens	02fbf217f6	GSettings Upgrade - change schema prefix from org.gnucash to org.gnucash.GnuCash ... The latter is the prefix format prescribed by gsettings itself. The former never was an issue until flatpak decided to not accept the shorter prefix when requesting a settings migration from host system to flatpak sandbox. In order to allow for migration, keep the old schema around in org.gnucash.GnuCash.deprecated.gschema.in While we're at it, make the new prefix an internal implementation detail. There's no need for it to be visible to the rest of the gnucash code.	5 years ago
Geert Janssens	6674b1bb6b	Cleanup - minimal glib=2.56.1 - drop all conditionals on older versions	5 years ago
John Ralls	74d0630867	Bug 798237 - Logging during XML file loading degrades performance... ... significantly Modify the DEBUG and PINFO macros to return unless qof_log_check is true. Replace almost all direct calls to g_debug and g_message with DEBUG and PINFO respectively. Track the highest logging level sent to qof_log_set_level to provide a short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by always being DEBUG. Net result: 33% improvement in xml load times.	5 years ago
Christopher Lam	017ab06939	Merge branch 'maint'	5 years ago
John Ralls	cd0d50aac1	Deprecate date options with a time of day setting. ... Removing the only use, an example in hello-world.scm. GnuCash doesn't use this value in any of its own report options and the feature will be removed in GnuCash 5. Related to bug 798297 Pref "Use 24-hour clock" obsolete?.	5 years ago
John Ralls	00c2e99d2e	Convert the Scheme RelativeDatePeriod lookup table to a std::vector. ... From a Scheme alist. The vector can be used to find the scheme symbol as a direct lookup, which isn't possible with an alist, and can be searched for the Scheme symbol match more quickly than an alist can.	5 years ago
John Ralls	bed44f404f	Remove the always questionable Scheme generation and parsing code. ... It's more reasonable to do that in Scheme than in C++.	5 years ago
John Ralls	a487ca3f98	Improve template conditional readability with custom traits values.	5 years ago
John Ralls	62ab148a3e	Output a pair when writing relative date values to scheme file. ... So that the can be properly recognized on input.	5 years ago
John Ralls	b3f96701a0	GncOptionAccountListValue: Make setter param cv match template.	5 years ago
John Ralls	b361582cf2	Ensure option UI is sorted: Tabs by names, items by keys.	5 years ago
John Ralls	10381d42e0	Fix color option handling. ... Read and write color options the way legacy code does. Pass only values with no alpha to gdk_rgba_parse because it fails if a hex-string has alpha.	5 years ago
John Ralls	97a317b50c	Ensure that alpha values in colors aren't passed to html. ... html color tags don't like them.	5 years ago
John Ralls	3d1812aacd	Explicitly cast a value to the decltype of get_value(). ... Can't always rely on implicit conversion working.	5 years ago
John Ralls	474bc360f4	Improve converting vectors to SCM lists.	5 years ago
John Ralls	1cd2cf211c	Specialize QofInstance* options set_value, catch validation exceptions. ... GncOptionValue<const QofInstance*>.get_value() returns a QofInstance* but reports store them as strings, either commodity mnemonics or GUIDs. Specialize set_value/set_default_value from scheme to handle those possibilities. GncOptionValidatedValue throws an invalid_argument exception if it's fed an invalid argument. Catch that so that it doesn't crash the program.	5 years ago
John Ralls	852b2ffc2e	Handle bare currency mnemonics, catch invalid GUID string exceptions.	5 years ago
John Ralls	e43ff93279	Fix some overly-long lines.	5 years ago
John Ralls	1af97ebb9a	Implement registering/unregistering/calling change callbacks. ... Drives reloading the report when the Apply or OK button is pressed.	5 years ago
John Ralls	86da12d844	Use RGB instead of RGBA for color set for color	5 years ago
Christopher Lam	eafc290034	Merge branch 'maint'	5 years ago
John Ralls	86d7637160	Handle GncOptionMultichoiceValue::set_value parameters ... that don't match the get_value return type.	5 years ago
John Ralls	b6622a386b	Pick up option aliases recently added in maint.	5 years ago
John Ralls	a97b3e0c6d	Don't let C code destroy the ODB, it's owned by Guile.	5 years ago
John Ralls	a2e1a3e1b8	Extract the GncOptionDB* from the Scheme dispatch function closure. ... Scheme code keeps the GncOptionDB in a closure. Extract it for C/C++ use. Ownership remains with the closure, don't free the GncOptionDB*.	5 years ago
John Ralls	99eaa81a28	Fix parse of commodity namespace from scheme istream. ... Just ignore 2 instead of ignoring 1 twice. No ifdef required.	5 years ago
Christopher Lam	a5edacf0fc	[options.scm] Rename option name to "Levels of Subaccounts" ... Original name "Show Accounts until level". Add backward compatibility missed in 08f490ee98	5 years ago
John Ralls	0bd9033bb3	Move includes of glib and gtk out or extern C in new cpp files.	5 years ago
John Ralls	0f02236ebe	Fix gcc warnings.	5 years ago
John Ralls	18997db720	Separate GncOptionAccountValue into GncOptionAccountListValue and GncOptionAccountSelValue. ... They have different get_value() return types so can't cohabit comfortably.	5 years ago
John Ralls	dd8e8b4efa	Evaluate the getter for making invoice options.	5 years ago
John Ralls	05ac056449	Make separate option type for GncOwner. ... GncOwner is not a QofInstance subclass.	5 years ago
John Ralls	9d150b1ae7	Always set budget option to default budget.	5 years ago
John Ralls	f5d8d508ee	Create the GncOptionVariant's GncOptionValue in place. ... Saves a temporary, prevents premature unprotecting of Scheme objects.	5 years ago
John Ralls	c034a26ae7	Protect stored scheme option values from the garbage collector.	5 years ago
John Ralls	67dab6b320	Remove business-options.scm and business-prefs.scm. ... Their functions have been reimplemented elsewhere.	5 years ago
John Ralls	a1af86ed40	Implement gnc:generate-restore-forms, gnc-optiondb-save-to-scheme.	5 years ago
John Ralls	c34986dad4	Change gnc:new-options to return a fake dispatch function. ... To placate test-report.scm	5 years ago
John Ralls	3f89d063eb	Evaluate default function in gnc:make-account-sel-limited-option.	5 years ago
John Ralls	6eb5dfed51	make-internal fail if there is a ui_item, not if there isn't.	5 years ago
John Ralls	29a2365fdf	Avoid infinite recursion when the alias changes only the section name.	5 years ago
John Ralls	7885353fe3	Bring option aliases up to date.	5 years ago
John Ralls	bbe74aa086	Remove tooltips from multichoice option values. ... This is the c++options equivalent to 02a6a0ae and e1525721.	5 years ago
John Ralls	7c6ecafd61	Rewrite options.scm to wrap options.hpp functions where needed.	5 years ago
John Ralls	52ef53a405	Implement multichoice selection options.	5 years ago
John Ralls	7239eb809a	Test more natural way of designating relative dates.	5 years ago
John Ralls	23461f1d6c	The value of a list-option is a list. Duh.	5 years ago
John Ralls	12f8df1eab	Fix test failure: Clear the stream before reusing it.	5 years ago
John Ralls	be322a0d7c	Group GncOptionMultChoiceValue::set_multiple with set_default_multiple. ... Better readability.	5 years ago
John Ralls	27670a6e98	Make the 'pixel and 'percent SCM symbols C++ constants. ... Improves efficiency and conciseness.	5 years ago
John Ralls	a94f69d6e0	Pretty up some SFINAE formatting for easier reading.	5 years ago
John Ralls	0f8446a1bb	Remove some no longer needed diagnostics.	5 years ago
John Ralls	f66a918be4	Implement GncOptionValue<const QofQuery*> ... QofQuery isn't a QofInstance and doesn't have a GUID.	5 years ago
John Ralls	0a8f66ee90	Fold GncOptionGncOwnerValue into GncOptionValue<const QofQuery*>. ... Reflecting the way Scheme options handles it.	5 years ago
John Ralls	418eb06620	Remove GncOptionDateValue::set_default_value(size_t) ... Because it's ambiguous with set_default_value(time64).	5 years ago
John Ralls	7d0cdf7c94	Handle #f input to option typemap(in)s.	5 years ago