gnucash

Commit Graph

Author	SHA1	Message	Date
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	a700701cd3	c++options: Remove three unused test functions. Scheme serialization is now tested in test-option-gnc-scheme-output.scm.	4 years ago
John Ralls	a3f50586df	c++options: More thorough testing of scheme serialization.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. The saved option files being Scheme executables.	5 years ago
Christopher Lam	f813f7cd14	[gnc-autoclear] Move autoclear algorithm into gnome-utils	5 years ago
John Ralls	00c2e99d2e	Convert the Scheme RelativeDatePeriod lookup table to a std::vector. From a Scheme alist. The vector can be used to find the scheme symbol as a direct lookup, which isn't possible with an alist, and can be searched for the Scheme symbol match more quickly than an alist can.	5 years ago
John Ralls	bed44f404f	Remove the always questionable Scheme generation and parsing code. It's more reasonable to do that in Scheme than in C++.	5 years ago
John Ralls	0bd9033bb3	Move includes of glib and gtk out or extern C in new cpp files.	5 years ago
John Ralls	18997db720	Separate GncOptionAccountValue into GncOptionAccountListValue and GncOptionAccountSelValue. They have different get_value() return types so can't cohabit comfortably.	5 years ago
John Ralls	bbe74aa086	Remove tooltips from multichoice option values. This is the c++options equivalent to `02a6a0ae` and `e1525721`.	5 years ago
John Ralls	7239eb809a	Test more natural way of designating relative dates.	5 years ago
John Ralls	23461f1d6c	The value of a list-option is a list. Duh.	5 years ago
John Ralls	12f8df1eab	Fix test failure: Clear the stream before reusing it.	5 years ago
John Ralls	d9984f75ab	Update test-gnc-optiondb.scm for not renaming the RelativeDatePeriod enums.	5 years ago
John Ralls	534a7c2893	GncOptionMultichoiceValue allow setting a default selection. Instead of arbitrarily using the first allowed value. Also update tests for the Scheme type addition to GncMultichoiceOptionChoices, intercept more cases where the value needs to be transformed, and go back to emitting a string instead of throwing in GncOptionMultichoiceValue::get_value when m_values has more than one value.	5 years ago
John Ralls	d41292fddd	Make set_selectable a GncOptionsGtkUIItem member function. Callable from the option object with set_ui_item_selectable and from Scheme as gnc-option-db-set-option-selectable-by-name.	5 years ago
John Ralls	18b83874fd	Another bit of Remove test-option-utils	5 years ago
John Ralls	cb7270cafe	Fix myriad gcc10 complaints.	5 years ago
John Ralls	ea835b31b7	Provide GncOptionPtr& overloads for register-option functions. Simplifies and makes safer calls from Scheme and C++ by not requiring a raw pointer.	5 years ago
John Ralls	8c77ce967b	Implement and test obsolete option name aliasing.	5 years ago
John Ralls	90b8fce59f	Fix build after merge.	5 years ago
John Ralls	85db341afe	Remove test-option-utils It no longer works. Since that's all that test-app-utils called, delete it too.	5 years ago
John Ralls	21398dfda1	Testing fixups for using GncOptionDB* in register_option functions.	5 years ago
John Ralls	6feb92d4e8	Provide scheme function new-gnc-optiondb. Wraps creating a GncOptionDBPtr, freeing up gnc_option_db_new() to return a GncOptionDB* for use in C code. Convert gnc_option_db_new() calls in gtest-gnc-optiondb to call std::make_unique() as well.	5 years ago
John Ralls	f9e136dbac	Get the spelling of GncMultichoiceOptionEntry consistent.	5 years ago
John Ralls	3b4785e744	Convert GncOptionSection from a std::pair to a class. Provides find_option(const char*) and foreach_option(func) for easy iteration. find_option and find_section now return plain const ptrs instead of std::optionals. Much less cumbersome though the compiler won't nag if you forget the nullptr check.	5 years ago
John Ralls	5fd53c94de	Provide GncOption::GetLimits for setting a NUMBER_RANGE spin button.	5 years ago
John Ralls	a995343a8b	Provide for multiple selections in GncOptionMultichoiceValue To support the GncOptionUIType::LIST. This UI type is unused in GnuCash code but might be used in user custom reports.	5 years ago
John Ralls	ac0e7063c7	Move the GncOptionUIType and dirty members to GncOptionUIUtem. Even though it makes the class not pure virtual any more it is necessary behavior common to all possible subclasses.	5 years ago
John Ralls	3200bd4966	Add a multiselect boolean member to GncOptionAccountValue. To support a variation available in dialog-options. Even though it's not used in any GnuCash code nor documented anywhere it might be in some custom reports.	5 years ago
John Ralls	6c8e0e23f7	Redesign GncOptionDateValue. After getting a better understanding of how it interacts with dialog-options and finding some additional scheme API needing implementation (exposed only in hello-world.scm, but possibly used in user-written reports). Creates a new file-pair, gnc-options-date.[ch]pp to separate the creation of the static structs with the type info and strings for the various RelativeDatePeriod values from the already too large gnc-option-impl. Although the result is a rather C-ish design the alternative with classes or template specializations would be more complicated and offer no benefit. Implements the permissible_values functions of GncOptionMultichoiceValue for GncDateValue and provides for absolute, relative, and both UI values for the three widget configs afforded by dialog-options.	5 years ago
John Ralls	102f36c3be	Provide more than one Date UI type to match options available in dialog-option.c Also differentiates begin-period and end-period controls.	5 years ago
John Ralls	99c2c5e439	GncOptionUIItem from the GncOptionVariant classes to GncOption. Separating the UI from the data model. Note that the GncOptionVariant classes still have a GncOptionUIType member to ensure that a GncOptionUIItem of the right type is attached.	5 years ago
John Ralls	1bea809cec	Remove the UI interface from GncOptionDB. UI operations occur only in dialog-option so there's no need to expose them from GncOptionDB.	5 years ago
John Ralls	cbf7d70ecd	Integrate gnc-option into app-utils. Includes converting swig-app-utils-guile to c++.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	aa246d3096	Make implementation classes and template code visible only in app-utils. So only GncOption and the GncOptionDB free-function interface are public. We don't want to expose template headers widely, it would blow up compilation times and might lead to one definition rule violations.	5 years ago
John Ralls	20b3ef8a89	Handle some minor differences between libc++ (clang) and libstdc++ (gcc).	5 years ago
John Ralls	cd6ccbe331	Fix account-tree double-free in scheme test when built with gcc. Oddly when built with clang it doesn't exhibit the crash.	5 years ago
John Ralls	691cb0992e	Follow change in loading method for engine's guile bindings.	5 years ago
John Ralls	cbd0607e80	Implement load and store options from/to book options.	5 years ago
John Ralls	ffc6866406	Changes to accommodate moving guile engine bindings to bindings/guile. Plus for changing targets gncmod-engine and gncmod-app-utils to gnc-engine and gnc-app-utils.	5 years ago
John Ralls	76172af239	Implement saving and loading OptionDB items to/from scheme and key-value string representations.	5 years ago
John Ralls	7ccba53739	Add stream functions to_scheme and from_scheme to GncOption. These add or parse the textual noise needed to replicate the Scheme options' serialization technique of saving scheme forms for saving report options and then evaluating those forms to restore the option values. Required for backward saved-reports compatibility.	5 years ago
John Ralls	1ea3822665	More operator <</>> Fixups.	5 years ago
John Ralls	98ca190700	Fix commodity in/out to use namespace & mnemonic instead of GUID.	5 years ago
John Ralls	4b997cd025	Fixups for GncOptionDateValue better design.	5 years ago
John Ralls	b2fb57d39e	Fix GncOption::set_value() to work with GncOptionDateValue::set_value(RelativeDatePeriod). Adjusting tests as necessary.	5 years ago
John Ralls	4dcf4a0e6a	Test GncOptionRangeValue as a GncOption. Better representation of how it will be used.	5 years ago
John Ralls	4cabd6c052	Change the GncOptionMultichoiceValue test to use a GncOption. Requires exposing the permissible values functions to GncOption.	5 years ago
John Ralls	e2a36a8be3	Expose function validate to GncOption and test it on GncOptionValidatedValue.	5 years ago
John Ralls	6df516dfcd	Clean up the commodity/currency tests with a better fixture class.	5 years ago
John Ralls	52d0ec5290	Change GncOptionDateValue design to better match usage. Added advantage that it handles (not correctly, but in the same way as the old code) the ambiguity between a period starting or ending with the stored value "relative . today".	5 years ago
John Ralls	883127a59d	Implement operators >> and << on GncOption.	5 years ago
John Ralls	b95ea2c4aa	Add Account-list options.	5 years ago
John Ralls	399573a89d	Fix multichoice test construction.	5 years ago
John Ralls	12c5b94430	New scheme function gnc_option_default_value.	5 years ago
John Ralls	3f576671aa	Adapt GncOptionMultiChoiceValue to support list options. Main change adds a value field to the constructor to set the value and default value.	5 years ago
John Ralls	2f2ac99944	Replace the direct wrapping of GncOptionDB-set-option-string-foo. With a simple type-free function gnc_option_set. This mirrors the current (gnc:option-set(gnc:lookup-option... and takes care of SCM type conversion.	5 years ago
John Ralls	252ba9b477	Change GncOptionDB::lookup_option to gnc_option_value(). The old gnc:lookup-option returned the option object so that it could be manipulated rather than getting its value; gnc_option_value replicates the behavior of (gnc:option-value (gnc:lookup-option)).	5 years ago
John Ralls	ff7b263a5f	Fix up and test the int specialization of GncOptionRangeValue. Not sure yet that a double one is really needed.	5 years ago
John Ralls	3dc4bc2377	Implement GncOptionDateValue.	5 years ago
John Ralls	435667e8fe	Implement GncOptionMultichoiceValue Replaces GncOptionValue<GncMultiChoiceOptionChoices> because having the vector as the value obviously wouldn't work and besides it needs additional functions.	5 years ago
John Ralls	8eedcb6d6d	Extract all SCM functions to gnc-optiondb.i. So that it can be moved to bindings/ when gnc-module-load-begone is ready.	5 years ago
John Ralls	16d1f0655b	Get libswig-gnc-optiondb to install in the right place on Windows.	5 years ago
John Ralls	cee3cdaff9	Instantiate GncOption::set_option for guile, initial types string and int. For proof-of-concept. Guile obviously doesn't know about templates.	5 years ago
John Ralls	c5fac51a8b	Change the type of OptionUIItem's m_ui_item from void* to GncOptionUIItem. A locally-opaque class wrapping whatever sort of widget ptr one needs. Thanks, warlord!	5 years ago
John Ralls	3296212aef	Sketch out the rest of the option types. Minimal implentation to get it to compile and pass tests, not functional yet.	5 years ago
John Ralls	0a13b4c518	Fix up the SWIG wrapper for GncOptionDBPtr. Thanks to Flexo@stackoverflow for https://stackoverflow.com/questions/27693812/how-to-handle-unique-ptrs-with-swig 5 years later, why isn't this in SWIG yet?	5 years ago
John Ralls	4146251cc7	Add GncOptionUIItem manipulation to GncOptionDB.	5 years ago
John Ralls	6ccb9dbb9e	Use a std::unique_ptr<GncOptionDB> instead of a raw ptr. Passing references to it to the gnc_register_option functions. Not tested yet with SWIG, might not work. Includes introducing fixtures to gtest-gnc-optiondb.cpp.	5 years ago
John Ralls	41ef2c5d44	Add OptionUIItem composition class to GncOption. Provides a type and a raw pointer member with accessors. The type is one of enum GncOptionIUType and is either VOID (for internal options that don't get UI items) or one of the widget types specified in dialog-option.c or business-options-gnome.c.	5 years ago
John Ralls	083e5b93df	Replace the CRTP class GncOptionBase with direct calls in its former children. Benefit of CRTP too limited to accept the cost of understanding it.	5 years ago
John Ralls	2ee0edaa16	Use targets instead of variables for GncOption* tests.	5 years ago
John Ralls	ade7fc8b6e	Initial SWIG of GncOptionDB and Scheme tests. This class will be heavily used by reports so we need to ensure SWIG and Scheme compatibility from the start.	5 years ago
John Ralls	f3eee511e8	Add free functions to create a new GncOptionDB and to register options. The objective of the free functions is to hide the GncOption from language bindings so that the GncOptions can be moved into the GncOptionDB instead of having shared ptrs splattered around the heap. Nearly all access to the options can then be mediated through the GncOptionDB container. Note that gnc_option_db_new creates the GncOptionDB on the heap and returns a raw ptr, so it's up to the creator of the GncOptionDB to call delete on it when it's no longer needed.	5 years ago
John Ralls	455d3c2d60	Add GncOptionDB class.	5 years ago
John Ralls	13b94d2370	Test integer options, calling get_value with wrong type.	5 years ago
John Ralls	d88ec0dc1b	Replace the gnc_make_foo_option free functions with a template ctor. The free functions will reappear for GncOptionDB. This is to avoid having to pass naked pointers to Scheme with the attendant object lifetime issues.	5 years ago
John Ralls	01dc70cc60	Add GncOption accessors for Classifier strings.	5 years ago
John Ralls	b6fd844774	Wrap GncOptionValue/GncOptionValidatedValue in Boost::Variant. To provide a single type for containers.	5 years ago
John Ralls	c0ba3e2706	[C++ Options] Begin Implementation for basic and validated options.	5 years ago
John Ralls	c49b45d8f1	Finish the glib 2.67 fixes for CI tests.	5 years ago
Geert Janssens	e9dfd0d9ea	Still more fixes for Arch ci failure	5 years ago
Geert Janssens	cb04365013	More fixes for Arch ci failure	5 years ago
John Ralls	7a7c26f87e	Move glib and gtk includes out of extern C for tests. Needed to compile with glib 2.67 and later.	5 years ago
Micha Lenk	9386b276e5	Make prototypes static for autoclear unit test With the explicit prototypes not marked as static unit test builds on Debian Buster (using buster-backports) fail with error: testing::internal::ParamGenerator<TestCase*> gtest_InstantiationAutoClearTestAutoClearTest_EvalGenerator_() was declared extern and later static [-fpermissive] According to the comment preceding the declaration the only intent of the explicit prototype (in newer versions of googletest implicitly defined by the GTEST macros) seems to be to silence a warning which would cause a build failure on Ubuntu 18.04 when using -Werror. Builds on Debian unstable seem to build just fine without this explicit declaration, hence I consider it safe to just drop it. However, builds on Ubuntu 18.04 then fail (see above). Making the prototypes as static should make both build environments happy.	5 years ago
John Ralls	c8c58bf349	Add test_autoclear_SOURCES to the dist list for inclusion in the tarball.	5 years ago
Christopher Lam	59ec912928	[modularise] (gnucash app-utils)	5 years ago
Cristian Klein	69789b2b93	[auto-tests] Stick to CodingStandard for member variables	6 years ago
Cristian Klein	f26215feae	[auto-tests] Fix misspelling	6 years ago
Cristian Klein	e5378b2048	[auto-clear] Make test more future-proof with GoogleTest	6 years ago
Cristian Klein	982cf86deb	[auto-clear] Fix test with googletest 1.8	6 years ago
Cristian Klein	9d4c0b05db	[auto-clear] Improve #include style	6 years ago
Cristian Klein	1cf7defee8	[auto-clear] Address feedback	6 years ago
Cristian Klein	9bf550d38f	[auto-clear] Include test for ambiguous cases	6 years ago
Cristian Klein	5cd777b673	[auto-clear] Fix test: Add xaccAccountBeginEdit / xaccAccountCommitEdit	6 years ago

1 2 3 4

200 Commits (341f2102635c73858d2abba05ab0e0990c47ecaf)