747 Commits (232dd765620cc291dd8a9bdd147656ecc1f0861b)

Author	SHA1	Message	Date
Richard Cohen	78ec20515b	Remove some unused variables - and the initialization ... - checked that any side effects were irrelevant	3 years ago
Richard Cohen	ea2d3be217	Remove some unused variables with obviously no side effects	3 years ago
Christopher Lam	85c2491664	Merge branch 'maint'	3 years ago
John Ralls	7bb14b9caa	Merge Richard Cohen's 'use-reference-for-loop' into master	3 years ago
Richard Cohen	d8f45f2443	Use const references for for-loops to avoid unnecessary copies ... Found by clazy - clazy-range-loop-reference	3 years ago
John Ralls	ce3447e6ea	Bug 798740 - Build fails with gcc 13 ... Protect against passing an lseek failure rv to read().	3 years ago
Christopher Lam	119356752f	Merge branch 'maint'	3 years ago
luzpaz	67ab9e90d2	Fix some typos	3 years ago
John Ralls	f6919e60a7	Merge Richard Cohen's 'cleanup' into master.	3 years ago
John Ralls	046e4a156e	Silence Clang deprecation warnings about sprintf.	3 years ago
Richard Cohen	1cec0cb3f3	Use internal extern "C" { ... } for C++ ... - removes warnings compiling swig engine ... [ 10%] Generating swig-engine.cpp .../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored), .../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'. .../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".	3 years ago
Richard Cohen	19bbde7000	Fix some typos	3 years ago
richardcohen	8044f79f75	Silence the boost (<1.76) warning message ... from .../gnucash-4.8/libgnucash/app-utils/gnc-quotes.cpp:33: /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ The issue was fixed in boost 1.76, but, e.g ubuntu 22.04 has boost 1.74	3 years ago
John Ralls	fed4daf4e7	[c++ quotes] Make sure to include all of the required Boost libraries. ... Also Boost-iostreams needs winsock but doesn't tell Cmake, so explicitly add it to the link list.	3 years ago
John Ralls	31d79e3004	Merge Bob Fewell's 'bug798673' into master.	3 years ago
John Ralls	b8c0673526	Merge branch 'maint'	3 years ago
Robert Fewell	7536fcaf2f	Change the balance limit icon if both limits are zero ... When higher and lower limits are zero, when used for a a suspense account, change the icon to 'dialog-warning'. This type of use is to indicate that a non zero balance exists.	3 years ago
Robert Fewell	a15c6f81b3	Allow the balances of sub accounts to be used in limits	3 years ago
Robert Fewell	60ab654d2b	Add account balance test functions to gnc-ui-balance	3 years ago
John Ralls	b4bab92da2	Bug 798664 - Result of 'gnucash --nofile' is marked dirty ... Don't create a new book in the new-user dialog unless the user says to. Don't automatically create a new book when retrieving default commodities because the retrieve might be requested in a context like the Preferences dialog when there is no book. Some report tests relied on requesting the default commodity creating the book, so in those tests ensure that the book is created first.	3 years ago
John Ralls	fae5de80d3	Undo unintended change in Bug 798679 commit.	3 years ago
John Ralls	fd2761bd68	Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields ... Control character check doesn't need normalization, the control character codepoints aren't graphic and so can't be composed nor have compatible equivalents.	3 years ago
Geert Janssens	98251d59a6	Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed ... Apparently it was a failure on our side to properly look up requested gsettings schema.	3 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
John Ralls	14a0ea4ed3	[price-quotes] Sort and format source list.	4 years ago
John Ralls	1a906b00aa	[price-quotes] Enable gnucash-cli to retrieve preferences on macOS. ... By embedding a minimal Info.plist with a bundle ID into the executable. This necessitated a change to binreloc because the unix-style install depended on there being a bundle ID only when the program was run from an application bundle.	4 years ago
John Ralls	2767587874	[price-quotes] Fix setting alphavantage API key.	4 years ago
John Ralls	7f2a09a69f	[price-quotes] Handle short error strings from finance-quote-wrapper. ... This keeps the translation work in GnuCash and improves the error signalling in gnc-quotes.	4 years ago
John Ralls	50c72b4f88	[price-quotes] Remove m_ready and usable() from GncQuoteSource. ... GncQuoteSource ctor throws if something is wrong so usable is always true.	4 years ago
John Ralls	7d93774dd2	[price-quotes] Throw instead of returning if there aren't any commodities to quote. ... So that the user gets sees an error instead of silent failure.	4 years ago
John Ralls	81d4ea9550	[price-quotes] Remove F::Q version format check. ... We don't care what the version string looks like as long as there is one.	4 years ago
John Ralls	c78fe37ff7	[price-quotes] General typo fixes and code cleanup.	4 years ago
John Ralls	70c9d4c9e3	[price-quotes] Fix version retrieval. ... Plus there's no need for a "not found" version string because GncQuotes construction will throw if Finance::Quote isn't correctly installed. No object, nothing to call version() on.	4 years ago
John Ralls	97e730b8d8	[price-quotes] Reformat test quote response strings to one line per quote.	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" ... With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	e817091de1	[price-quotes] Warn only once if the AlphaVantage Key isn't set. ... And check the environment if it's not in preferences.	4 years ago
John Ralls	d97ea77762	[price quotes] Add report member function to display quote information to stdout. ... Instead of creating price instances in the database.	4 years ago
John Ralls	6ffb0bb633	[price-quotes] Report quote fetch failures to the user.	4 years ago
John Ralls	4c47e91180	[price-quotes] Implement error codes for currency and quote failures.	4 years ago
John Ralls	6db7800ca5	[price-quotes] Doxygen docs.	4 years ago
John Ralls	29ce925646	[price-quotes] Test the other fetch overloads and quote values.	4 years ago
John Ralls	b5bc6463a3	[price-quotes] Rework date-time handling. ... A check of the F::Q modules found that the only ones that return a quote time return a bogus one and do so only to mollify GnuCash. Since there's no good way to determine the TZ of the exchange originating the quote there's no good way to decide if the quote is current or from a previous market session, so we just punt and use a time of 16:00 for all quotes.	4 years ago
John Ralls	19064093d2	[price-quotes] Remove m_comm_vec and m_fq_answer. ... Passing the intermediate values comm_vec and quote_str on the stack instead.	4 years ago
John Ralls	734fb6ce2a	[price-quotes] Switch error handling to exceptions. ... Allows for cleaner code with less state, less coupling of the GncQuotes class, and better transfer of error messages to client code. Also translates some error messages for presentation to users.	4 years ago
John Ralls	d307295076	[price-quotes] Paramaterize GncMockQuoteSource construction. ... So we can have different results passed back for different tests.	4 years ago
John Ralls	2b87066687	[price-quotes] Extract some static functions. ... To get GncQuoteImpl::parse_one_quote to a reasonable size.	4 years ago
John Ralls	a82c72cfb9	[price-quotes] Remove level of indirection when parsing quote data.	4 years ago
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. ... To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago