1796 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)

Author	SHA1	Message	Date
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting ... The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. ... Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. ... In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Alex Aycinena	e381e70638	reverse commit d48937c. See discussion in Bug #79769.	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Alex Aycinena	d48937cf9c	Bug #79769 - Allow US Income Tax txf code 296 (Returns and allowances) to be shown and assignable for both income and expense type accounts.	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes ... For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions ... gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm ... much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Frank H. Ellenberger	2298590316	Merge PR #1309 into maint	4 years ago
Christopher Lam	736d223198	Merge branch 'maint-progress3' into maint #1312	4 years ago
Christopher Lam	0c4d438a0e	[kvp-frame.cpp] expose iterator, skip inexistent frame	4 years ago
Christopher Lam	aab33954e7	[gnc-numeric.cpp] Reduce logging level of gnc_numeric exception message ... Exceptions are expected in some use cases.	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Christopher Lam	6a668df168	[qofutil.h] don't recurse includes	4 years ago
Robert Fewell	ae220b86a4	[C++options] Fix Ubuntu test failure.	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	26b009c0f4	Bug 798500 - FTBFS (tests failure) on armhf ... Ensure the transition_times are correctly aligned for their sizes before attempting to copy them into the transitions vector.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
John Ralls	29bdd9b526	[C++options] Fix Ubuntu test failure.	4 years ago
John Ralls	1fddf70e21	[C++options] Fix previous month and previous quarter at the end of March ... . Because March has more days than February the previous month offset was getting normalized back to the current month--th 29 February this year is really 1 March, so normalizing before setting the day caused begin/end previous month to return the begin/end of the current month. That probably happened on the 31st of May, July, October, and December as well, I just hadn't managed to test on those days. Switching the normalization to after calculating the day of the month broke the previous quarter calculation because now the month was out of range, so normalize month & year first.	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	03cbbd1cd1	Merge branch 'maint'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. ... No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. ... For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
Christopher Lam	4a75baa4c6	[gnc-xml-backend.cpp] gchar* must be freed after use. ... It is used as a constructor for std::string which makes a copy but doesn't take ownership.	4 years ago
Christopher Lam	cf1282501e	Use original guile variable names changed in #1073 ... The changes 09296dfb96, 1373233cd0 and 189db58e6 had caused inconsistencies. Best restore original guile variable names using underscore, bound to strings instead of functions returning strings.	4 years ago
Christopher Lam	5993ebf4d4	Merge branch 'maint'	4 years ago
Christopher Lam	5388cc8e2c	[kvp-frame.cpp] minor speedups ... reserve vector, cache iterator from m_valuemap.find for reuse immediately afterwards.	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. ... Xcode-13.3 errors without it.	4 years ago
John Ralls	572cb6b1d1	Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp. ... Puts it closer to its points of use and removes it with its Scheme dependency from libgnucash.	4 years ago
John Ralls	e63baa6270	Merge Bob Fewell's 'rtl' into maint.	4 years ago
Robert Fewell	f8fc796c95	Bug797501 - Currency symbols in Hebrew (RTL) language ... When Gnucash is run in Hebrew which is a RTL language, on the accounts page the tree view is displaying the required number as the following... TreeView entry is '1,500.00 ₪' or '-1,500.00 ₪' TreeModel string is '₪ 1,500.00‬' or '₪ 1,500.00-‬' This seems to be down to the GTK 'Unicode Bidirectional Text Algorithm' which is changing the representation of the model string based on the first strongly typed character, in this case the Israeli shekel sign. To fix this, when creating the displayed monetary amount insert a BiDi ltr isolate uni-character at the start of the string.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. ... Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Christopher Lam	0052e3e483	[gnc-pricedb] add user:stock-transaction price source	4 years ago
John Ralls	c1001e6641	Better wording for tax table changed info message.	4 years ago
John Ralls	d841b322d0	Merge Frank Ellenberger's 'Bug684507' into maint.	4 years ago
John Ralls	ce2b89fd8c	[business]Add diagnostic messages to GncEntry and GncInvoice.	4 years ago
John Ralls	916caa25f2	Integrate Windows gzopen differences so that only one ifdef is needed. ... Clarifies code.	4 years ago
John Ralls	250b4ed733	Remove stray line left from earlier refactoring.	4 years ago
Robert Fewell	7e299cb2b0	Remove print statement left in commit c3f8daa	4 years ago
John Ralls	8ef8d3807c	Silence spurious conditional uninitialized warning in gnc-owner-sql.cpp.	4 years ago
John Ralls	93f5e23cf5	Open gzfile if thread creation fails.	4 years ago
John Ralls	9ad24321b4	Remove investment-type namespaces. ... Leave it to users to categorize their non-currency commodities. In the QIF importer default non-classifiable commodities to GNC_COMMODITY_NS_NONCURRENCY.	4 years ago
Frank H. Ellenberger	09296dfb96	Drop commodity-table.scm, no longer required after adjusting qif-dialog-utils	4 years ago
Frank H. Ellenberger	c7f842c081	Bug 684507 - commodity namespace should be localized	4 years ago
Christopher Lam	bd4a457040	Merge branch 'maint-lightning-budget' into maint #1248	4 years ago
Christopher Lam	a47413860a	Factor out GValue access for setters and getters	4 years ago
Christopher Lam	8f845df934	Factor out make_period_[data|note]_path	4 years ago
Christopher Lam	919f392c7a	Use kvp C++ interface rather than GValue	4 years ago
Christopher Lam	6c4c2512db	Use C++ STL instead of GLib	4 years ago
Christopher Lam	9088acabd8	[gnc-budget.cpp] convert to c++	4 years ago
John Ralls	81b9a02235	Bug 798458 - Build failure with gcc 12 ... Refactor try_gz_open to return a std::pair<FILE*, thread>. That removes the need for the threads hash-table and wait_for_gzip(). The cause of the gcc12 error was that we were using the thread's pipe's FILE* as the key to the hash-table and had to close it before calling wait_for_gzip(file) to remove the thread from the hash-table. gcc12 considers that a use-after-free. It happens to be wrong, but removing the need for it results in a cleaner implementation as well as silencing the warning.	4 years ago
John Ralls	67e8c317da	[xml backend] Extract functions to make gz_trhead_func more readable.	4 years ago
Christopher Lam	56cc021d33	Merge branch 'maint'	4 years ago
Alex Aycinena	a2825d33a1	Update Form/Schedule line references for 2021 for the US Income Tax Report	4 years ago
Christopher Lam	c1c198c9ff	Merge branch 'maint'	4 years ago
Christopher Lam	f0de54ac7a	Merge branch 'maint-798406' into maint #1240	4 years ago
Christopher Lam	8bc080b96d	[gnc-budget] store budget kvp data onto memory upon first call. ... then each getter will retrieve from memory rather than backend's kvp.	4 years ago
Christopher Lam	ef8d812d3f	[utest-Budget] test data retention when modifying budget num_periods	4 years ago
Christopher Lam	87b0a41e9b	[Split.c] return price==0 instead of 1, if !split, or amt==0	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
Christopher Lam	f7ee644695	Amendment to 73822f97a [1/2] use heuristics to scrub budget signs ... Testing income<0 to conclude "none reversal" is likely a more sound strategy than testing liability>0.	4 years ago
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. ... Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	65bd860249	Fix relative_date_to_time64 calculations. ... Where the date requested extends beyond the start or end of the year.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. ... That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	11225d9741	c++options: Remove gnc:options-data	4 years ago
John Ralls	16dc15964c	c++options: Remove the callback registration functions.	4 years ago
John Ralls	759376eb13	c++options: Fix multicolumn report	4 years ago
John Ralls	18edc17541	c++options remove stray debugging comment.	4 years ago
John Ralls	b5d0c42505	c++options: Put copyright and FSF header comment on gnc-optiondb.i.	4 years ago
John Ralls	a700701cd3	c++options: Remove three unused test functions. ... Scheme serialization is now tested in test-option-gnc-scheme-output.scm.	4 years ago
John Ralls	eb0bd4f998	c++options: Remove unneeded C++20 header and resolve ambiguous call.	4 years ago
John Ralls	a3f50586df	c++options: More thorough testing of scheme serialization.	4 years ago
John Ralls	6cd88c230c	c++options: Create bool or string internal options when possible. ... There's no need to save internal options as SCM when we support the underlying type in C++.	4 years ago
John Ralls	e9b850cca5	c++options: Correct Scheme serialization of type bool.	4 years ago
John Ralls	66f9fc81c7	c++options: Implement serialization for GncOwner.	4 years ago
John Ralls	0ce841d4ce	c++options Fix Scheme bindings for QofQuery options.	4 years ago
John Ralls	216b483e26	c++options SCM bindings Rewrite save_scm_value to branch on type. ... Instead of GncOptionUIType, mostly. We still need to do that to tell apart commodities and currencies from other QofInstances. Allows compile-time dispatch for most types.	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	947c061989	C++options: Create QofQueryValue trait.	4 years ago
John Ralls	f26014a04e	c++options: QofInstanceValue: Protect against crashes when m_value is nullptr.	4 years ago
John Ralls	95b973f792	Bug 798352 - Decimal Precision when Entering Mutual Fund Transaction ... Let xaccParseAmount parse up to 12 decimal places instead of 8.	4 years ago
Christopher Lam	33b6dfc6ce	[options.scm] addendum ca6604c93 gnc:make-budget-option ... selection-budget changed from budget object to guid, handle other uses as appropriate.	4 years ago
Christopher Lam	ca6604c93c	[options.scm] Addon previous commit... need to initialize with guid	4 years ago
Christopher Lam	d740ac1cb0	Merge branch 'budget-option-stores-guid' into maint PR #1207	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." ... This reverts commit 17a3f7fef2, reversing changes made to b8458d0732.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
John Ralls	17a3f7fef2	Merge Stefan Bayer's 'SepaInternalTransfer' into maint.	4 years ago
Christopher Lam	5a812ca1eb	[options.scm] gnc:make-budget-option stores guid instead of object ... because object may become stale if UI is used to delete it, leading to stale pointer and segfault. storing guid is safer, and will return null if budget is deleted.	4 years ago
Christopher Lam	91b1d291a5	[3/3][gnc-ui-util.c] Remove unused functions ... These functions were used to (optionally) reverse amounts according to whether the feature GNC_FEATURE_BUDGET_UNREVERSED was set. They are now obsolete because code will now assume feature is set for all loaded datafiles.	4 years ago
Christopher Lam	73822f97a9	[1/2][Scrubbudget.c] use heuristics to scrub budget signs ... If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set, check and fix budget amount signs. Previously budgets were created with assumption that sign reversal was set to credit amounts. A heuristic approach is used: - if budgeted expense is negative, conclude sign reversal is "Income and Expense" - if budgeted liability is positive, conclude sign reversal is "None" - otherwise conclude sign reversal is "Credit Accounts" The above is calibrated to (hopefully) prefer sign reversal of Credit Accounts.	4 years ago
Christopher Lam	6070aecd69	[2/3][gnc-features.c] add & expose gnc_features_set_unused ... same as gnc_features_set_used but removes feature	4 years ago
Christopher Lam	5dab33694f	[1/3][qofbook.cpp] add & expose qof_book_unset_feature ... same as qof_book_set_feature but removes feature item	4 years ago
John Ralls	269249378f	c++options fix setting account-selection widget from option.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. ... And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
Christopher Lam	88ecf8dd17	Merge branch 'maint'	4 years ago
John Ralls	dd7feb9988	options.scm: Remove second license comment.	4 years ago
John Ralls	d1fe359e47	gnc_numeric_to_decimal: Change can't round warning to a debug. ... Routinely used as a check so a warning isn't appropriate.	4 years ago
John Ralls	74fd716afb	Clarify gnc_relative_date_to_time64 helper functions.	4 years ago
John Ralls	f6c9e63e3d	Fix PR comments so far. ... Except for gnc-option-date's normalize_tm and set_day_and_time.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	96b09ded9f	Doxygen documentation for new options classes.	5 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. ... The saved option files being Scheme executables.	5 years ago
John Ralls	ff04ad3785	Bug 798346 - crashes when running check & repair ... Don't scrub trading accounts for imbalances, see the comment in the commit for why.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	79d8ef0299	Revert b5f5129f7 using gnc_list_length_cmp	5 years ago
Christopher Lam	3dfdf60608	[gnc-glib-utils] Define and export gnc_list_length_cmp	5 years ago
Christopher Lam	b5f5129f7d	Shortcut g_list_length comparison against small numbers ... It's more efficient to test node && node->next etc when testing GList length against small numbers	5 years ago
Christopher Lam	f813f7cd14	[gnc-autoclear] Move autoclear algorithm into gnome-utils	5 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc ... Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
Geert Janssens	bdb06479e8	GSettings - fix GObject warning when old prefs-version is unset ... This will happen when current master (future 5.0) has been run at least once.	5 years ago
John Ralls	5a8cbf4193	Bug 798325 - New Currency for Venezuela (VED) ... Add latest Venezuelan revaluation of the Bolivar Soberano, following the ISO notation replacing VES (which the Venezualan central bank is keeping) with VED and the exchange code (ditto) with 926.	5 years ago
Christopher Lam	f40dbb8c28	Avoid unnecessary g_list_length in equality functions	5 years ago
Christopher Lam	f0970c8eb4	[gnc-features] don't repeatedly g_strconcat gchars*	5 years ago
Christopher Lam	31a0300abe	[Recurrence.c] avoid repeated calls to g_list_length	5 years ago
Christopher Lam	b480600dc8	[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls	5 years ago
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal ... Also need to change PWARN which causes test failure, to PINFO	5 years ago
Geert Janssens	09b3ce2382	Revert "Add structure to map migrated preferences to old ones" ... This reverts commit c6103a5c17.	5 years ago
Geert Janssens	806d0b3157	Revert "GSettings - make most of the api private" ... This reverts commit 26b2d7ca78.	5 years ago
Geert Janssens	1d4673ed2a	Revert "GSettings - rework internal helper functions to use more C++" ... This reverts commit 24fa289952.	5 years ago
Geert Janssens	24fa289952	GSettings - rework internal helper functions to use more C++	5 years ago
Geert Janssens	26b2d7ca78	GSettings - make most of the api private ... All preference calls should happen via the gnc_prefs_... apis. The gnc_gsettings_... apis are an internal implementation of this.	5 years ago
Geert Janssens	c6103a5c17	Add structure to map migrated preferences to old ones ... This can be used to keep both in sync in the period between initial migration and eventual obsolence. Note only non-obsoleted, migrated preferences are tracked. We don't want to resync preferences that have been obsoleted (reset). That would nullify the whole idea of making them obsolete for future removal. This commit only adds the mapping, synching will follow in a future commit.	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account ... Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... ... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
Geert Janssens	9a465fc359	GSettings - add 'deprecate' and 'obsolete' conversions for user preferences ... 'deprecate' is technically a noop. It serves to remind maintainers the 'deprecated' preference is to be obsoleted in the next major release. 'obsolete' goes one step further in that it will cause gnucash to reset the preference, effectively clearing the value stored in the preferences backend. This is the final phase of a preference. Following this it will be completely removed from the GSettings schema in the next major release. Notes * 'deprecate' and 'migrate' are related. Both are a reminder the preference is to be obsoleted in the next major release. 'deprecate' does only that though while 'migrate' will also trigger a copy of the old value to a new location in the databse. * This commit readds a couple of preferences that had been removed in the past to be able to properly obsolete them (and to test the obsoleting code)	5 years ago
Geert Janssens	64576f7d27	GSettings - widen scope from 'migration' to 'transformation' ... This commit mostly changes descriptions and variable names to use the more generic terms 'transformations' or 'conversions'. 'migration' is only one possible transform, future commits will add others. There are no functional changes in this commit other than a logic inversion in parse_one_release_node. It now checks for nodes named 'migrate' rather than for nodes not named 'migrate' (the code is adapted accordingly to match this logic change).	5 years ago
John Ralls	29e7b07ed3	Remove superflous schema_source left over from pasting.	5 years ago
John Ralls	8bfa5a63f2	[gsettings] Avoid crash from settings schema not being registered.	5 years ago
Christopher Lam	10c1223df2	Merge branch 'maint-progress' into maint #1150	5 years ago
Geert Janssens	2a7566cc40	Win32 - drop conditional code never reached ... We had hardcoded HAVE_HTMLHELPW to always be true so the fallback code that's only reached when it is false was never reached. Time to drop this dead code.	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Geert Janssens	8ea52ae212	GSettings - run data model transations while setting up ... This makes sure all schema changes are in effect before the first consumer can query them. For example this will prevent a one-time re-occurrence of the tip of the day dialog the first time the new migrations are run.	5 years ago
Christopher Lam	c0736a1a04	Merge branch 'maint-leaks' into maint #1135	5 years ago
Geert Janssens	f1802b6fdf	GSettings Upgrade - add code to migrate settings ... The rules for migration are read from an xml file. This file was prepared in a previous commit. Future settings 'data model' changes can reuse this code by simply adding migration rules in the xml file. This replaces the hardcoded rules that were currently in place to migrate a few settings from 2.6 and older to 3.0. These rules are no longer meaningful as we require users to migrate from one major release series to the immediate next one. So by the time the new migration rules in this commit are applied by users they should already have run gnucash 3.x at least once. That run should have taken care of the pre-3.0 migration actions.	5 years ago
Geert Janssens	f21c7b6e90	GSettings - define old prefix and check settings for the presence of both prefixes while normalizing	5 years ago
Geert Janssens	a203c5b2d5	GSettings - drop logic to relocate our settings ... This was ported from GConf, but GSettings doesn't work that way. Settings locations are defined at compile time and can't be relocated at run time (unless you make all of the settings explicitly relocatable. That however is not how GSettings is meant to be used.)	5 years ago
Geert Janssens	d1113a4534	GSettings - build as cpp	5 years ago
Geert Janssens	02fbf217f6	GSettings Upgrade - change schema prefix from org.gnucash to org.gnucash.GnuCash ... The latter is the prefix format prescribed by gsettings itself. The former never was an issue until flatpak decided to not accept the shorter prefix when requesting a settings migration from host system to flatpak sandbox. In order to allow for migration, keep the old schema around in org.gnucash.GnuCash.deprecated.gschema.in While we're at it, make the new prefix an internal implementation detail. There's no need for it to be visible to the rest of the gnucash code.	5 years ago
Geert Janssens	6674b1bb6b	Cleanup - minimal glib=2.56.1 - drop all conditionals on older versions	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions ... dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	73ad5b1265	[gnc-glib-utils] use g_stpcpy instead of gnc_strcat ... g_stpcpy will use stpcpy wherever available.	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
John Ralls	1d8983191d	Fix runaway sed error.	5 years ago
John Ralls	824b515430	Fix qoflog's comments to reflect a preference for the macros over GLib functions.	5 years ago
John Ralls	74d0630867	Bug 798237 - Logging during XML file loading degrades performance... ... significantly Modify the DEBUG and PINFO macros to return unless qof_log_check is true. Replace almost all direct calls to g_debug and g_message with DEBUG and PINFO respectively. Track the highest logging level sent to qof_log_set_level to provide a short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by always being DEBUG. Net result: 33% improvement in xml load times.	5 years ago
John Ralls	574f567b62	Refactor GncXmlBackend::get_file_lock. ... Moving all of the error-handling to it for better clarity and simplicity. Drop the unnecessary stat call, open will fail with EEXIST if there's already a lock file. Provide specific messages for file system failures.	5 years ago
John Ralls	d7eae0664f	[gz_open] Use compress and write consistent with calling functions.	5 years ago
Christopher Lam	15852031d4	[utest-account.cpp] increase test coverage ... adds getter/setter tests for xaccAccountSetLastNum xaccAccountSetTaxUSCode xaccAccountSetTaxUSPayerNameSource	5 years ago
John Ralls	c3f8daaf7d	Bug 798250 - Gnucash permanent hang on save while loading report ... Prevent WebKit's fork from getting a copy of the pipe's file descriptors and so keeping the pipe from closing. Thanks to Simon Arlott for recognizing the FD duplication.	5 years ago
Christopher Lam	017ab06939	Merge branch 'maint'	5 years ago
John Ralls	edad194389	Bug 798180 - Update to macOS Big Sur 11.3 breaks Finance Quote ... Added new dependency Test2 to gnc-fq-update. This is a second-order dependency of Finanance::Quote that CPAN doesn't seem to recognize on its own.	5 years ago
John Ralls	cd0d50aac1	Deprecate date options with a time of day setting. ... Removing the only use, an example in hello-world.scm. GnuCash doesn't use this value in any of its own report options and the feature will be removed in GnuCash 5. Related to bug 798297 Pref "Use 24-hour clock" obsolete?.	5 years ago
John Ralls	8ab8642e76	Fix leak of trading_splits list in xaccTransClearTradingSplits	5 years ago
John Ralls	1387d5f960	Fix unchecked ptr dereference. ... First crash in Bug 798225.	5 years ago
John Ralls	ab24c34660	Merge Simon Arlott's 'free-template-root' into maint.	5 years ago
Simon Arlott	4a8acf3fb2	Free template root accounts on book end ... The template root should be unset so that it's destroyed when the book is ending. This is required to free all the template accounts and referenced strings. The scheduled transactions themselves need to be freed first so reverse the order that SXRegister and gnc_sxtt_register are called in cashobjects_register: The list resulting from that function is traversed from the bottom up.	5 years ago
John Ralls	901fea158f	Merge Simon Arlott's 'xml-locking-fixes' into maint.	5 years ago
John Ralls	38cd06e54a	Remove the lock-file-link-count test from the XML backend. ... This was an effort of somewhat dubious value to detect if a process on another ocmputer had a hsrd-link to a lockfile on an NFS share. NFS is rarely used now and SMB doesn't support hard links so this check adds complexity with no real value.	5 years ago
John Ralls	079a900300	Bug 798298 - Re-imported transactions no longer ignored ... Merges Jean Laroche's '798298_reimport_ofx' into maint.	5 years ago
Mike Alexander	068a5d2fa8	Fix xaccSplitGetOtherSplit which was broken by 028bf9826, don't ... count splits that aren't really in the transaction. The rewrite left out one test. This was most obvious in the dummy transaction used to enter a new transaction into an account. xaccSplitGetOtherSplit never returned an "other split" for this transaction. It turns out the old code was broken too, but it worked for this case by coincidence.	5 years ago
jean	4e9fe0a4d1	Add missing function to mock account	5 years ago
John Ralls	00c2e99d2e	Convert the Scheme RelativeDatePeriod lookup table to a std::vector. ... From a Scheme alist. The vector can be used to find the scheme symbol as a direct lookup, which isn't possible with an alist, and can be searched for the Scheme symbol match more quickly than an alist can.	5 years ago
Christopher Lam	8d502fcdd8	Merge branch 'maint'	5 years ago
Christopher Lam	1eb6709331	[test-lots.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	323182c9f7	[utest-Account.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	8a37c4c019	[utest-Invoice.c] add kvp getter/setter tests	5 years ago
Christopher Lam	9ec670f828	[test-commodities.cpp] add kvp setter/getter test	5 years ago
Christopher Lam	d4c8b36f9f	[utest-Transaction.cpp] add kvp setter/getter tests ... wasn't tested before	5 years ago
Christopher Lam	c3b50f0b58	[gnc-lot.c] fix - cache value properly	5 years ago
Christopher Lam	595e126a34	[account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr ... - will remove a second call to g_strstrip (g_strdup (str))	5 years ago
Christopher Lam	c5a6383b43	[account.cpp] fix - incomplete #1117 ... - init struct members properly to: is_unset and TriState::Unset - test acct kvp "equity-type" for "opening-balance" instead of "true" - cached account->color/sort_order/notes/filter gets strstripped similarly to previous behavior	5 years ago
John Ralls	bed44f404f	Remove the always questionable Scheme generation and parsing code. ... It's more reasonable to do that in Scheme than in C++.	5 years ago
Christopher Lam	001b34616f	[Transaction.c] GValue string must be unset	5 years ago
Christopher Lam	a47bee97d6	[Split.c] GValue string must be unset	5 years ago
Christopher Lam	0ecbcb4ef1	[gnc-lot.c] GValue string must be unset	5 years ago
Christopher Lam	ac2afc7e13	[gncInvoice.c] GValue string must be unset	5 years ago
Christopher Lam	3bf49ed8d7	[Account.cpp] GValue string must be unset	5 years ago
Christopher Lam	e3af2f22f9	[gnc-commodity.c] cache user_symbol into commodity struct ... Continuation of ff2ceb111 which introduced issue whereby user_symbol returned could become stale, leading to invalid read fixed with c398bef59. There are likely other user_symbol pointers becoming stale without this commit. This change will save the user_symbol into the commodity struct, avoids gchar* becoming stale.	5 years ago
John Ralls	a487ca3f98	Improve template conditional readability with custom traits values.	5 years ago
John Ralls	57f73d70c7	Merge Yordan Miladinov's denom_lcd into maint.	5 years ago
Christopher Lam	c6d8333811	Merge branch 'maint'	5 years ago
Christopher Lam	c55ab50349	[gnc-budget.c] gnc_budget_get_account_period_note to be freed by the caller	5 years ago
Christopher Lam	9ddb9e8215	[gnc-module.c] free a GList* properly ... g_list_free (current) was a NOP because current became NULL after the preceding GList traversal.	5 years ago