724 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)

Author	SHA1	Message	Date
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
John Ralls	f24f29830b	[options] Change std::cerr stream output to PWARN. ... Remove temporary diagnostic.	4 years ago
Christopher Lam	3e02859277	Merge branch 'maint'	4 years ago
Christopher Lam	b7a3652de7	[date-utilities] avoid report crash if start>end date	4 years ago
John Ralls	087501d316	Bug 798262 - Scheduled transactions with blank amounts do not get created. ... Handle template transactions that don't have any splits with empty credit and debit strings and those having no set transaction account. Set the concrete transaction commodity to the first found of: The template transaction's commodity The commodity of the first split with a credit or debit string The commodity of the first split.	4 years ago
John Ralls	410db42df0	Test case where the template txn doesn't have a set currency.	4 years ago
John Ralls	229f6f5e85	Fix gdate adjustments.	4 years ago
Simon Arlott	4c1fc1d555	Bug 798262 - Add test case for basic scheduled transactions ... Test these scheduled transactions: * 2 splits with fixed amounts "123" * 2 splits with fixed amounts "0" * 2 splits with empty amounts "" Verify that automatically created scheduled transactions exist.	4 years ago
Christopher Lam	6ba912ee0d	Merge branch 'maint'	4 years ago
Christopher Lam	de7a63082b	[gnc-sx-instance-model] leaks: free temporal_state ... it's a simple struct containing GDate and int	4 years ago
Christopher Lam	ad27be333e	[gnc-sx-instance-model] prepend GList loops instead of append	4 years ago
John Ralls	8b07ac88cd	[options] Add "key" to the register-option documentation blocks.	4 years ago
John Ralls	e29ab5336f	[options] Remove key and doc_string from gnc_register_query_option. ... It's always used as an internal option with no UI component so it doesn't use them.	4 years ago
John Ralls	6faaf3b427	[options] Provide a const char* value flavor for register_commodity ... And register_currency_option	4 years ago
John Ralls	1ff844c195	[options] Fix implementation of gnc_register_owner_option ... To take an owner-type parameter and to set the UIType accordingly.	4 years ago
John Ralls	aa0b0921f4	[options] Add a function to check if an option is internal. ... Instead of relying on the legacy underscore-section-name hack.	4 years ago
John Ralls	da0eff2cac	[options] Implement widget-changed callbacks. ... Enables full functionality for complex-boolean and multichoice-callback options. Note that setter-function callback isn't used in any GnuCash code so it is not implemented and is not present in the register-callback functions.	4 years ago
John Ralls	552aa438ff	[options] Implement gnc_register_internal_option.	4 years ago
John Ralls	0e9ed8cf0a	[options] Provide float variants to gnc_register_plot_size_option.	4 years ago
John Ralls	0213787a2f	[options] Enable registering an absolute date option.	4 years ago
John Ralls	cf2870b71a	[options] Change RelativeDate and Multichoice index type to uint16_t. ... From size_t because clang thinks that std::is_same_v<size_t, time64> is true and we need to differentiate the handling of the two.	4 years ago
John Ralls	0b2d14ee72	Fix distribution for expressions target.	4 years ago
Christopher Lam	b94440b16a	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	ea56d67797	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	bfa0fd1819	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	f0ac8d69b2	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	67a1b7a873	[gnc-sx-instance-model] free GHashTable keys when destroying	4 years ago
Christopher Lam	ebf3439558	[gnc-sx-instance-model] free some GHashTable keys & Values	4 years ago
Christopher Lam	7c2a249511	[gnc-sx-instance-model.c] refactor Scrub function ... This scrubbing function calls xaccTransRollbackEdit which is leaky. Instead of trying to fix xaccTransRollbackEdit which requires superhuman skills, it's easiest to track the changes separately in a GList, and use xaccTransBeginEdit/xaccTransCommitEdit only if necessary.	4 years ago
Christopher Lam	c16840b840	more leaks because qof_instance_get returns a new char*	4 years ago
John Ralls	f4c27d4494	Move gnc_ui_account_get_tax_info_string to gnc-locale-tax.c ... To prevent a circular dependency between libgnc-app-utils and libgnucash-guile.	4 years ago
John Ralls	3e2f7bc66a	Create separate shared library for expression parser and SX instance model. ... These functions depend on both libgnc-app-utils and libgnucash-guile, creating a circular dependency when the app-utils bindings are added to libgnucash-guile.	4 years ago
John Ralls	47904a858e	Fix distcheck in master. ... Several gnc-optiondb dependencies left out of tarball.	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	564d73a553	Bug 798531 - Selecting "Print" from the file menu on a report... ... crashes gnucash Ensure that every call to gnc_prefs_get_string correctly handles both a NULL or empty string return value without crashing or leaking.	4 years ago
Christopher Lam	a5cae6c5eb	Don't export undefined functions	4 years ago
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos ... With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit a8e6a59	4 years ago
Robert Fewell	db6a8f809b	Tax Tables combo does not set the active one ... Fixed by correcting spelling of tax table qof type, should 'gncTaxTable'. Also fixed setting tax table combo to 'none' when page reset button used.	4 years ago
Robert Fewell	0b67a91217	Fix the option GncOptionRangeValue ... The GncOptionRangeValue can be used with integers or doubles, the default being doubles. When used for setting the plot width/height, integers are used so all ValueTypes need to be integers other wise the when create_range_spinner is used you end up with the upper_bound value being G_MAXDOUBLE, a 309 character wide spin button. To differentiate the two, use 'set_alternate(true)' for integers.	4 years ago
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting ... The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. ... Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. ... In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes ... For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Robert Fewell	ae220b86a4	[C++options] Fix Ubuntu test failure.	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	29bdd9b526	[C++options] Fix Ubuntu test failure.	4 years ago
John Ralls	1fddf70e21	[C++options] Fix previous month and previous quarter at the end of March ... . Because March has more days than February the previous month offset was getting normalized back to the current month--th 29 February this year is really 1 March, so normalizing before setting the day caused begin/end previous month to return the begin/end of the current month. That probably happened on the 31st of May, July, October, and December as well, I just hadn't managed to test on those days. Switching the normalization to after calculating the day of the month broke the previous quarter calculation because now the month was out of range, so normalize month & year first.	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. ... No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. ... For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
Christopher Lam	cf1282501e	Use original guile variable names changed in #1073 ... The changes 09296dfb96, 1373233cd0 and 189db58e6 had caused inconsistencies. Best restore original guile variable names using underscore, bound to strings instead of functions returning strings.	4 years ago
Christopher Lam	5993ebf4d4	Merge branch 'maint'	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. ... Xcode-13.3 errors without it.	4 years ago
John Ralls	572cb6b1d1	Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp. ... Puts it closer to its points of use and removes it with its Scheme dependency from libgnucash.	4 years ago
John Ralls	e63baa6270	Merge Bob Fewell's 'rtl' into maint.	4 years ago
Robert Fewell	f8fc796c95	Bug797501 - Currency symbols in Hebrew (RTL) language ... When Gnucash is run in Hebrew which is a RTL language, on the accounts page the tree view is displaying the required number as the following... TreeView entry is '1,500.00 ₪' or '-1,500.00 ₪' TreeModel string is '₪ 1,500.00‬' or '₪ 1,500.00-‬' This seems to be down to the GTK 'Unicode Bidirectional Text Algorithm' which is changing the representation of the model string based on the first strongly typed character, in this case the Israeli shekel sign. To fix this, when creating the displayed monetary amount insert a BiDi ltr isolate uni-character at the start of the string.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. ... Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	09296dfb96	Drop commodity-table.scm, no longer required after adjusting qif-dialog-utils	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. ... Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	65bd860249	Fix relative_date_to_time64 calculations. ... Where the date requested extends beyond the start or end of the year.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. ... That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	11225d9741	c++options: Remove gnc:options-data	4 years ago
John Ralls	16dc15964c	c++options: Remove the callback registration functions.	4 years ago
John Ralls	759376eb13	c++options: Fix multicolumn report	4 years ago
John Ralls	18edc17541	c++options remove stray debugging comment.	4 years ago
John Ralls	b5d0c42505	c++options: Put copyright and FSF header comment on gnc-optiondb.i.	4 years ago
John Ralls	a700701cd3	c++options: Remove three unused test functions. ... Scheme serialization is now tested in test-option-gnc-scheme-output.scm.	4 years ago
John Ralls	eb0bd4f998	c++options: Remove unneeded C++20 header and resolve ambiguous call.	4 years ago
John Ralls	a3f50586df	c++options: More thorough testing of scheme serialization.	4 years ago
John Ralls	6cd88c230c	c++options: Create bool or string internal options when possible. ... There's no need to save internal options as SCM when we support the underlying type in C++.	4 years ago
John Ralls	e9b850cca5	c++options: Correct Scheme serialization of type bool.	4 years ago
John Ralls	66f9fc81c7	c++options: Implement serialization for GncOwner.	4 years ago
John Ralls	0ce841d4ce	c++options Fix Scheme bindings for QofQuery options.	4 years ago
John Ralls	216b483e26	c++options SCM bindings Rewrite save_scm_value to branch on type. ... Instead of GncOptionUIType, mostly. We still need to do that to tell apart commodities and currencies from other QofInstances. Allows compile-time dispatch for most types.	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	947c061989	C++options: Create QofQueryValue trait.	4 years ago
John Ralls	f26014a04e	c++options: QofInstanceValue: Protect against crashes when m_value is nullptr.	4 years ago
John Ralls	95b973f792	Bug 798352 - Decimal Precision when Entering Mutual Fund Transaction ... Let xaccParseAmount parse up to 12 decimal places instead of 8.	4 years ago
Christopher Lam	33b6dfc6ce	[options.scm] addendum ca6604c93 gnc:make-budget-option ... selection-budget changed from budget object to guid, handle other uses as appropriate.	4 years ago
Christopher Lam	ca6604c93c	[options.scm] Addon previous commit... need to initialize with guid	4 years ago
Christopher Lam	5a812ca1eb	[options.scm] gnc:make-budget-option stores guid instead of object ... because object may become stale if UI is used to delete it, leading to stale pointer and segfault. storing guid is safer, and will return null if budget is deleted.	4 years ago
Christopher Lam	91b1d291a5	[3/3][gnc-ui-util.c] Remove unused functions ... These functions were used to (optionally) reverse amounts according to whether the feature GNC_FEATURE_BUDGET_UNREVERSED was set. They are now obsolete because code will now assume feature is set for all loaded datafiles.	4 years ago
John Ralls	269249378f	c++options fix setting account-selection widget from option.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. ... And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
John Ralls	dd7feb9988	options.scm: Remove second license comment.	4 years ago
John Ralls	74fd716afb	Clarify gnc_relative_date_to_time64 helper functions.	4 years ago
John Ralls	f6c9e63e3d	Fix PR comments so far. ... Except for gnc-option-date's normalize_tm and set_day_and_time.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	96b09ded9f	Doxygen documentation for new options classes.	5 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. ... The saved option files being Scheme executables.	5 years ago