659 Commits (00a982d97d6a628d2750611fe8a5b533cb682535)

Author	SHA1	Message	Date
John Ralls	76b0001cbe	Remove option-util.	5 years ago
John Ralls	e2c87f23c3	Convert optiondb users in gnome and gnome-utils to C++. ... To enable using std::unique_ptr<GncObjectDB> and avoid memory management problems.	5 years ago
John Ralls	7dab089d49	Fix miscalculation of prev_quarter_end for the first quarter. ... If the current quarter ends June 30 backing up 3 months from there gets March 30, one day off. Back up first and calculate the end of the actual quarter of interest. Changed pre_quarter_start for consistency, it doesn't matter.	5 years ago
John Ralls	28438e3126	Rewire gnome and gnome-utils to use GncOptionDB.	5 years ago
John Ralls	67508ea039	Reimplement dialog-options for C++.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. ... Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	d2535fe21b	KvpValue: Use boost::typeindex::type_id instead of buildtin typeid. ... Under some build conditions boost::typeindex will use an internal type identifier that's different from the C++ builtin. In that case type equality tests to C++ typeid in boost::variant will fail, breaking it. Using boost::typeindex::type_id ensures that the comparisons always work.	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
Hong Xu	0fd0aca531	Explain out what AsOfDate means in the doc ... As discussed at https://lists.gnucash.org/pipermail/gnucash-user/2021-June/096893.html	5 years ago
John Ralls	601eb51361	Improve transaction sorting on effective num field. ... Inspired by PR #983. Transaction sorting on num broke down if the user had a non-numeric string or a number larger than an int in the effective num field (might be split-action if the option is set). The comparison first tries to use strtoull on the two strings and compares the results. If they're both nonzero and different then the numeric order is returned. If they're both nonzero but the same the unconverted parts of each are passed to g_utf8_collate; if either is 0 then the whole strings are passed to g_utf8_collate. strtoull will return 0 for a negative number.	5 years ago
John Ralls	985a6420fc	Bug 798196 - not building with Boost 1.76	5 years ago
John Ralls	6aa35ea7fb	Better fix for bug 798204, doesn't break trading account selection.	5 years ago
John Ralls	9eeff5dd7e	Bug 798204 - Creation of Imbalance Accounts ... Search recursively when getting account by name.	5 years ago
John Ralls	68ec80e68d	Bug 798203 - g_assert fault while reversing transaction ... * Re-commit the original transaction to ensure that there aren't any stray trading splits. * If the original and cloned transactions have a different number of splits don't leak the cloned transaction. * Check that the cloned transaction isn't NULL before trying to invert it.	5 years ago
John Ralls	80d6749989	Bug 787813 - Price change from editing a transaction not reflected... ... in pricedb. Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.	5 years ago
Christopher Lam	321b5efabc	Merge branch 'maint-leaks' into maint #1019	5 years ago
John Ralls	42213c597c	Bug 798199 - Pasting invalid value in date column crashes GnuCash ... Catch boost::gregorian::bad_year in LDT_from_struct_tm and rethrow std::invalid_argument for C wrappers to catch and handle.	5 years ago
Christopher Lam	b095d1e7da	Revert "[qofquery] q->terms g_list members must be freed" ... This reverts commit a3e3823ee7. Already freed earlier in the same function.	5 years ago
Christopher Lam	c8a7b9edb3	[Account] g_value_unset	5 years ago
Christopher Lam	bfdec74a48	[qof-backend] gchar * gnc_path_get_pkglibdir must be g_freed	5 years ago
Christopher Lam	f6a9be45ba	[Split] g_value_unset	5 years ago
Christopher Lam	36901c5751	[gncJob] g_value_unset	5 years ago
Christopher Lam	1824a30bd0	[gncinvoice] g_value_unset	5 years ago
Christopher Lam	badd976e11	[gnc-lot] g_value_unset	5 years ago
Christopher Lam	c9565abe8b	[gnc-commodity] g_value_unset	5 years ago
Christopher Lam	302020fcb7	[gnc-budget] g_value_unset	5 years ago
Christopher Lam	ceeb1dff7a	[scrub.c] g_value_unset	5 years ago
Christopher Lam	92cd437562	[Transaction.c] g_value_unset to release GValue string	5 years ago
Christopher Lam	3353d3950b	[gnc-budget] g_value_unset GValue	5 years ago
Christopher Lam	a3e3823ee7	[qofquery] q->terms g_list members must be freed	5 years ago
Christopher Lam	8a6413342d	[SchedXaction] free GList*	5 years ago
Christopher Lam	c5585ebe2c	[gncInvoice] free GList*	5 years ago
Christopher Lam	d611538ae7	[gncTaxtable] free GSList*	5 years ago
Christopher Lam	b3101c9385	[gnc-pricedb.c] plug GList leak	5 years ago
Christopher Lam	8a56a00313	Modify documentation for gncEntryComputeValue ... Modify documentation for be19b489e	5 years ago
Christopher Lam	b25a444140	Merge branch 'maint'	5 years ago
John Ralls	da3c511b6c	Remove trading splits instead of trying to adjust them.	5 years ago
John Ralls	4f030aac6e	Bug 798093 - Changing the symbol/abbreviation of a security... ... after the trading account was created breaks GnuCash. Revisited. The original changeset looked for a top level trading account and a namespace account in the transaction currency; if either of those accounts had been created in a different currency it would duplicate them. This commit will accept any such account regardless of commodity. If more than one exists it will prefer the one in the root currency if there is one, otherwise it will select the first one found.	5 years ago
John Ralls	18c72baddf	Don't bother scrubbing for orphans if there's no transaction currency. ... If it found one it would try to create an orphan account with no currency which will crash later.	5 years ago
John Ralls	2b48fd375d	Revert "Fix duplicate trading accounts." ... This reverts commit ed486a58a4.	5 years ago
Hong Xu	888676eb31	from_price and to_price may be uninitialized in extract_comon_prices ... Fix the compilation error on gcc 10: gnucash/libgnucash/engine/gnc-pricedb.c: In function ‘extract_common_prices’: gnucash/libgnucash/engine/gnc-pricedb.c:2469:40: error: to_price may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^ gnucash/libgnucash/engine/gnc-pricedb.c:2469:20: error: ‘from_price’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^	5 years ago
Christopher Lam	ae7eb9b3ad	[gnc-pricedb] extract common code into get_nearest_price ... Extracts common code in: * gnc_pricedb_get_nearest_before_price * gnc_pricedb_get_nearest_price * gnc_pricedb_get_latest_price	5 years ago
Christopher Lam	a2f5223148	[gnc-pricedb] use g_list_find and plug memory leak ... found_coms was not being freed.	5 years ago
John Ralls	ed486a58a4	Fix duplicate trading accounts. ... In many cases GnuCash would create a new trading account hierarchy when one already existed because gnc_account_lookup_by_type_and_commodity didn't check the account presented and didn't recurse down the account hierarchy correctly.	5 years ago
John Ralls	2258e7a44e	xaccAccountTypes was backwards ... vs. the documentation. The unit tests and dialog-account were similarly backwards, but the use in gnucash/import-export/ofx followed the docs.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
Robert Fewell	e535ba5411	Change some functions to use const gnc_commodity for gnc_pricedb	5 years ago
Robert Fewell	e75308e684	Rename a couple of gnc-pricedb functions that have not been used. ... To be more consistent change gnc_pricedb_lookup_latest_before_t64 and gnc_pricedb_lookup_latest_before_any_currency_t64 to be of the form '_nearest_before_' and add a missing utest.	5 years ago
Robert Fewell	d3bd7fda61	Add unit tests for new gnc-pricedb functions	5 years ago
Robert Fewell	4a491f7cde	Change a couple of docbook definitions in gnc-pricdb.h	5 years ago