From f893b046fb81447cc92dbce16166c22c79bd59a6 Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Sun, 21 Dec 2025 12:45:55 +0800 Subject: [PATCH] [io-gncxml-v2.cpp] xmlGetProp must be xmlFreed --- libgnucash/backend/xml/io-gncxml-v2.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libgnucash/backend/xml/io-gncxml-v2.cpp b/libgnucash/backend/xml/io-gncxml-v2.cpp index 3265ae2929..9d6e23764e 100644 --- a/libgnucash/backend/xml/io-gncxml-v2.cpp +++ b/libgnucash/backend/xml/io-gncxml-v2.cpp @@ -1103,8 +1103,10 @@ write_pricedb (FILE* out, QofBook* book, sixtp_gdv2* gd) We do it this way instead of just calling xmlElemDump so that we can increment the progress bar as we go. */ - if (fprintf (out, "<%s version=\"%s\">\n", parent->name, - xmlGetProp (parent, BAD_CAST "version")) < 0) + auto version_str = xmlGetProp (parent, BAD_CAST "version"); + auto res = fprintf (out, "<%s version=\"%s\">\n", parent->name, version_str); + xmlFree (version_str); + if (res < 0) return FALSE; /* We create our own output buffer so we can call xmlNodeDumpOutput to get