From f0ecc0e2ebd33f7286d22adf1b12c77f45fba771 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Thu, 5 Aug 2021 15:41:03 -0700 Subject: [PATCH] std::string(char*) crashes if it's given a nullptr. --- gnucash/gnome-utils/dialog-options.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnucash/gnome-utils/dialog-options.cpp b/gnucash/gnome-utils/dialog-options.cpp index bc632648b1..03aa010697 100644 --- a/gnucash/gnome-utils/dialog-options.cpp +++ b/gnucash/gnome-utils/dialog-options.cpp @@ -2320,8 +2320,11 @@ public: { auto string = gtk_file_chooser_get_filename(GTK_FILE_CHOOSER(get_widget())); DEBUG("filename %s", string ? string : "(null)"); - option.set_value(std::string{string}); - g_free(string); + if (string) + { + option.set_value(std::string{string}); + g_free(string); + } } };