From eb6addb0586e5838e76cbc6b2a437442de346712 Mon Sep 17 00:00:00 2001 From: Simon Arlott Date: Sat, 24 Jun 2023 12:58:52 +0100 Subject: [PATCH] Fix memory leak in gnc_main_window_update_menu_and_toolbar() The function could return after allocating a new GncMenuModelSearch without freeing it. Move the allocation later so that this doesn't happen. --- gnucash/gnome-utils/gnc-main-window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnucash/gnome-utils/gnc-main-window.cpp b/gnucash/gnome-utils/gnc-main-window.cpp index 25eb9460bc..e5b5f0929a 100644 --- a/gnucash/gnome-utils/gnc-main-window.cpp +++ b/gnucash/gnome-utils/gnc-main-window.cpp @@ -3751,7 +3751,6 @@ gnc_main_window_update_menu_and_toolbar (GncMainWindow *window, const gchar *menu_qualifier; GMenuModel *menu_model_part; - GncMenuModelSearch *gsm = g_new0 (GncMenuModelSearch, 1); #ifdef MAC_INTEGRATION auto theApp{static_cast(g_object_new(GTKOSX_TYPE_APPLICATION, nullptr))}; #endif @@ -3792,6 +3791,7 @@ gnc_main_window_update_menu_and_toolbar (GncMainWindow *window, gnc_menubar_model_remove_items_with_attrib (priv->menubar_model, GNC_MENU_ATTRIBUTE_TEMPORARY); + GncMenuModelSearch *gsm = g_new0 (GncMenuModelSearch, 1); for (gint i = 0; ui_updates[i]; i++) { gchar *menu_name;