From e27338b004d9dc4f1cb501bdec6755a1048af37a Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Sat, 2 Nov 2019 18:25:44 +0800 Subject: [PATCH] [html-utilities] more deprecations * gnc:html-table-append-ruler/at! was flawed - the empty-cell defined as '() would lead to invalid html-table element. it was never used because colskip was always 0. inline and deprecate function. --- gnucash/report/report-system/html-utilities.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gnucash/report/report-system/html-utilities.scm b/gnucash/report/report-system/html-utilities.scm index 5f9ab1ebbb..805cfeca6d 100644 --- a/gnucash/report/report-system/html-utilities.scm +++ b/gnucash/report/report-system/html-utilities.scm @@ -132,6 +132,8 @@ ;; colspan at, optionally, the specified column. (define (gnc:html-table-append-ruler/at! table colskip colspan) (define empty-cell '()) + (issue-deprecation-warning + "gnc:html-table-append-ruler/at! is deprecated.") (gnc:html-table-append-row! table (append (make-list colskip empty-cell) @@ -141,6 +143,8 @@ (define (gnc:html-table-append-ruler/at/markup! table markup colskip colspan) (define empty-cell "") + (issue-deprecation-warning + "gnc:html-table-append-ruler/at/markup! is deprecated.") (gnc:html-table-append-row/markup! table markup @@ -150,7 +154,9 @@ 1 colspan (gnc:make-html-text (gnc:html-markup-hr))))))) (define (gnc:html-table-append-ruler! table colspan) - (gnc:html-table-append-ruler/at! table 0 colspan)) + (gnc:html-table-append-row! + table (list (gnc:make-html-table-cell/size + 1 colspan (gnc:make-html-text (gnc:html-markup-hr)))))) (define (gnc:html-table-append-ruler/markup! table markup colspan) (issue-deprecation-warning