From cfd37c91028268c8a8b4199bc7bc3b60ade03099 Mon Sep 17 00:00:00 2001
From: Christopher Lam <christopher.lck@gmail.com>
Date: Mon, 19 Sep 2022 09:31:21 +0800
Subject: [PATCH] [assistant-stock-transaction] fix stock split creation
 algorithm

* stock_amount was reduced as a previous bugfix attempt
* remove references to Stock Split Assistant
---
 gnucash/gnome/assistant-stock-transaction.cpp        | 6 ++----
 gnucash/gtkbuilder/assistant-stock-transaction.glade | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/gnucash/gnome/assistant-stock-transaction.cpp b/gnucash/gnome/assistant-stock-transaction.cpp
index 788d7b01aa..2d6734c0bc 100644
--- a/gnucash/gnome/assistant-stock-transaction.cpp
+++ b/gnucash/gnome/assistant-stock-transaction.cpp
@@ -263,7 +263,7 @@ reinvested must be subsequently recorded as a regular stock purchase.")
         N_("Company redeems units, thereby increasing the stock price by a \
 multiple, while keeping the total monetary value of the overall investment \
 constant.\n\nIf the reverse split results in a cash in lieu for remainder \
-units, please record the sale using the Stock Split Assistant first, then \
+units, please record the sale using the Stock Transaction Assistant first, then \
 record the reverse split.")
     }
 };
@@ -369,7 +369,7 @@ static const TxnTypeVec short_types
         N_("Company redeems units, thereby increasing the stock price by \
 a multiple, while keeping the total monetary value of the overall investment \
 constant.\n\nIf the reverse split results in a cash in lieu for remainder \
-units, please record the cover buy using the Stock Split Assistant first, \
+units, please record the cover buy using the Stock Transaction Assistant first, \
 then record the reverse split.")
     }
 };
@@ -1099,8 +1099,6 @@ stock_assistant_finish (GtkAssistant *assistant, gpointer user_data)
         gae_amount (info->stock_amount_edit) : gnc_numeric_zero ();
     auto stock_value = info->txn_type->stock_value != FieldMask::DISABLED ?
         gae_amount (info->stock_value_edit) : gnc_numeric_zero ();
-    if (info->txn_type->input_new_balance)
-        stock_amount = gnc_numeric_sub_fixed (stock_amount, info->balance_at_date);
     create_split (trans, info->txn_type->stock_amount | info->txn_type->stock_value,
                   NC_ ("Stock Assistant: Action field", "Stock"),
                   info->acct, account_commits, info->stock_memo_edit,
diff --git a/gnucash/gtkbuilder/assistant-stock-transaction.glade b/gnucash/gtkbuilder/assistant-stock-transaction.glade
index b219301320..c28e6d7b62 100644
--- a/gnucash/gtkbuilder/assistant-stock-transaction.glade
+++ b/gnucash/gtkbuilder/assistant-stock-transaction.glade
@@ -6,7 +6,7 @@
     <property name="can-focus">False</property>
     <property name="halign">start</property>
     <property name="border-width">12</property>
-    <property name="title" translatable="yes">Stock Split Assistant</property>
+    <property name="title" translatable="yes">Stock Transaction Assistant</property>
     <property name="window-position">center</property>
     <property name="default-width">500</property>
     <signal name="cancel" handler="stock_assistant_cancel" swapped="no"/>