Fix failure to pass accounts list to gnc:make-account-list-option

The Scheme way of generating options is somehow able to obtain the
account-list even when running the generator before creating the account
tree. The C++ options object doesn't have that ability so one must make
sure to run the account creation first in a let* statement.

gnucash/report/reports/standard/test/test-equity-statement.scm

@@ -51,8 +51,8 @@
   (gnc:options->sxml uuid options "test-equity-statement" test-title))
 
 (define (test-equity-statement)
-  (let* ((options (gnc:make-report-options uuid))
-         (account-alist (create-test-data))
+  (let* ((account-alist (create-test-data))
+         (options (gnc:make-report-options uuid))
          (gbp-bank (assoc-ref account-alist "GBP Bank"))
          (usd-bank (assoc-ref account-alist "Bank"))
          (expense (assoc-ref account-alist "Expenses"))

gnucash/report/reports/standard/test/test-portfolios.scm

@@ -97,8 +97,8 @@
 
 (define (advanced-tests)
   (test-group-with-cleanup "advanced-portfolio-tests"
-    (let ((account-alist (create-stock-test-data))
-          (options (gnc:make-report-options advanced-uuid)))
+    (let* ((account-alist (create-stock-test-data))
+           (options (gnc:make-report-options advanced-uuid)))
       (let ((sxml (options->sxml advanced-uuid options "basic average")))
         (test-equal "advanced: average basis"
           '("AAPL" "AAPL" "NASDAQ" "42.00" "$6.0000" "$484.88" "$252.00" "$800.00"

gnucash/report/reports/standard/test/test-register.scm

@@ -51,8 +51,8 @@
   (gnc:options->sxml uuid options "test-register" test-title))
 
 (define (test-register)
-  (let* ((options (gnc:make-report-options uuid))
-         (account-alist (create-test-data))
+  (let* ((account-alist (create-test-data))
+         (options (gnc:make-report-options uuid))
          (bank (cdr (assoc "Bank" account-alist))))
 
     (gnc-commodity-set-user-symbol

gnucash/report/reports/standard/test/test-trial-balance.scm

@@ -51,8 +51,8 @@
   (gnc:options->sxml uuid options "test-trial-balance" test-title))
 
 (define (test-trial-balance)
-  (let* ((options (gnc:make-report-options uuid))
-         (account-alist (create-test-data))
+  (let* ((account-alist (create-test-data))
+         (options (gnc:make-report-options uuid))
          (gbp-bank (assoc-ref account-alist "GBP Bank"))
          (usd-bank (assoc-ref account-alist "Bank"))
          (expense (assoc-ref account-alist "Expenses"))