From a700701cd3dcb9f37aa17b85d8cf7f2d0147f87d Mon Sep 17 00:00:00 2001 From: John Ralls Date: Tue, 14 Dec 2021 11:11:51 -0800 Subject: [PATCH] c++options: Remove three unused test functions. Scheme serialization is now tested in test-option-gnc-scheme-output.scm. --- libgnucash/app-utils/gnc-option-impl.hpp | 1 - .../app-utils/test/gtest-gnc-option.cpp | 41 ------------------- 2 files changed, 42 deletions(-) diff --git a/libgnucash/app-utils/gnc-option-impl.hpp b/libgnucash/app-utils/gnc-option-impl.hpp index 702d62fbe8..3adb3f634e 100644 --- a/libgnucash/app-utils/gnc-option-impl.hpp +++ b/libgnucash/app-utils/gnc-option-impl.hpp @@ -56,7 +56,6 @@ extern "C" #include "gnc-option-uitype.hpp" -static const char* commodity_scm_intro{"'(commodity-scm "}; #ifndef SWIG size_t constexpr classifier_size_max{50}; size_t constexpr sort_tag_size_max{10}; diff --git a/libgnucash/app-utils/test/gtest-gnc-option.cpp b/libgnucash/app-utils/test/gtest-gnc-option.cpp index e2e01e132d..0582979c64 100644 --- a/libgnucash/app-utils/test/gtest-gnc-option.cpp +++ b/libgnucash/app-utils/test/gtest-gnc-option.cpp @@ -306,25 +306,6 @@ static inline std::string make_commodity_str(gnc_commodity* com) return com_str; } -static inline std::string make_currency_SCM_str(gnc_commodity* cur) -{ - std::string cur_str{gnc_commodity_get_mnemonic(cur)}; - cur_str.insert(0, "\""); - cur_str += "\""; - return cur_str; -} - -static inline std::string make_commodity_SCM_str(gnc_commodity* com) -{ - std::string com_str{commodity_scm_intro}; - com_str += "\""; - com_str += gnc_commodity_get_namespace(com); - com_str += "\" \""; - com_str += gnc_commodity_get_mnemonic(com); - com_str += "\")"; - return com_str; -} - TEST_F(GncOptionCommodityTest, test_currency_out) { auto option = make_currency_option("foo", "bar", "baz", "Phony Option", @@ -740,28 +721,6 @@ TEST_F(GncOptionAccountTest, test_account_list_in) EXPECT_EQ(acclist[1], sel_option.get_value()[0]); } -static inline std::string -make_account_list_SCM_str(const GncOptionAccountList& acclist) -{ - std::string retval{"'("}; - bool first = true; - for (auto acc : acclist) - { - if (first) - { - first = false; - retval += '"'; - } - else - retval += " \""; - retval += gnc::GUID{*qof_instance_get_guid(acc)}.to_string(); - retval += '"'; - } - retval += ')'; - return retval; -} - - using KT = GncOptionMultichoiceKeyType; class GncOptionMultichoiceTest : public ::testing::Test {