From 4c8f822c12ee57208d735da4a366251b86793309 Mon Sep 17 00:00:00 2001 From: Di Mang Date: Sat, 14 Jul 2018 21:45:28 +0200 Subject: [PATCH 1/2] Increase of MAX_TAB_COUNT to change appearance of dialog "Book Options" in german language. The dialog "Book Options" looks in german different, because it has 5 tabs: four standard tabs and additionaly one tab for tax settings, which appears only for german language. The 1 to 4 tabs appearance on top (horizontal mode). The appearance switchs to vertical mode (with tabs on the left side) for 5 and more tabs. Here the setting MAX_TAB_COUNT is increased to 5. This change should make the dialog similar in german and other languages. --- gnucash/gnome-utils/dialog-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnucash/gnome-utils/dialog-options.c b/gnucash/gnome-utils/dialog-options.c index f981c5b087..88c3a6ffcf 100644 --- a/gnucash/gnome-utils/dialog-options.c +++ b/gnucash/gnome-utils/dialog-options.c @@ -74,7 +74,7 @@ static QofLogModule log_module = GNC_MOD_GUI; * Point where preferences switch control method from a set of * notebook tabs to a list. */ -#define MAX_TAB_COUNT 4 +#define MAX_TAB_COUNT 5 /* A pointer to the last selected filename */ #define LAST_SELECTION "last-selection" From 697d2a166fb83823dd723d5565940e5cf08ed269 Mon Sep 17 00:00:00 2001 From: Di Mang Date: Wed, 18 Jul 2018 22:08:11 +0200 Subject: [PATCH 2/2] unify appearance in preferences dialog The reports and other windows based on GtkNotebooks have currently max. 6 tabs in preferences dialog. Changing the value MAX_TAB_COUNT to 6 will unify appearance in all such dialogs. But to consider future changes, it would be useful to add a few extra places for new tabs: MAX_TAB_COUNT = 8. --- gnucash/gnome-utils/dialog-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnucash/gnome-utils/dialog-options.c b/gnucash/gnome-utils/dialog-options.c index 88c3a6ffcf..d224a5214b 100644 --- a/gnucash/gnome-utils/dialog-options.c +++ b/gnucash/gnome-utils/dialog-options.c @@ -74,7 +74,7 @@ static QofLogModule log_module = GNC_MOD_GUI; * Point where preferences switch control method from a set of * notebook tabs to a list. */ -#define MAX_TAB_COUNT 5 +#define MAX_TAB_COUNT 8 /* A pointer to the last selected filename */ #define LAST_SELECTION "last-selection"