From 985f5918308dde01c408e07c7879e31d85e7cfd1 Mon Sep 17 00:00:00 2001
From: Christopher Lam <christopher.lck@gmail.com>
Date: Fri, 27 Jun 2025 21:50:25 +0800
Subject: [PATCH] [Transaction.cpp] small modification to xaccTransSetNotes

---
 libgnucash/engine/Transaction.cpp            | 9 +--------
 libgnucash/engine/test/utest-Transaction.cpp | 4 ++--
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/libgnucash/engine/Transaction.cpp b/libgnucash/engine/Transaction.cpp
index aa65820313..abd3e22b56 100644
--- a/libgnucash/engine/Transaction.cpp
+++ b/libgnucash/engine/Transaction.cpp
@@ -2080,15 +2080,8 @@ qofTransSetNotes (Transaction *trans, const char *notes)
 void
 xaccTransSetNotes (Transaction *trans, const char *notes)
 {
-    GValue v = G_VALUE_INIT;
     if (!trans || !notes) return;
-    g_value_init (&v, G_TYPE_STRING);
-    g_value_set_static_string (&v, notes);
-    xaccTransBeginEdit(trans);
-    qof_instance_set_kvp (QOF_INSTANCE (trans), &v, 1, trans_notes_str);
-    qof_instance_set_dirty(QOF_INSTANCE(trans));
-    g_value_unset (&v);
-    xaccTransCommitEdit(trans);
+    set_kvp_string_path (trans, {trans_notes_str}, notes);
 }
 
 void
diff --git a/libgnucash/engine/test/utest-Transaction.cpp b/libgnucash/engine/test/utest-Transaction.cpp
index 3dd81b1d06..e85d8d853d 100644
--- a/libgnucash/engine/test/utest-Transaction.cpp
+++ b/libgnucash/engine/test/utest-Transaction.cpp
@@ -1870,8 +1870,8 @@ test_xaccTransSetNotes (Fixture *fixture, gconstpointer pData)
     g_assert_cmpstr (frame->get_slot({trans_notes_str})->get<const char*>(), ==, "set");
 
     xaccTransSetNotes (trans, "");
-    g_assert_cmpstr (xaccTransGetNotes (trans), ==, "");
-    g_assert_cmpstr (frame->get_slot({trans_notes_str})->get<const char*>(), ==, "");
+    g_assert_cmpstr (xaccTransGetNotes (trans), ==, nullptr);
+    g_assert_null (frame->get_slot({trans_notes_str}));
 
     xaccTransSetNotes (trans, "reset");
     g_assert_cmpstr (xaccTransGetNotes (trans), ==, "reset");