From 8db81058508be9ec1d510237ce33d1eb3de03199 Mon Sep 17 00:00:00 2001
From: John Ralls <jralls@ceridwen.us>
Date: Tue, 14 Mar 2023 15:58:39 -0700
Subject: [PATCH] [c++options] Warn when an option variant type's set_value
 isn't found.

---
 libgnucash/engine/gnc-option.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libgnucash/engine/gnc-option.cpp b/libgnucash/engine/gnc-option.cpp
index 277491645e..56f3f8aa31 100644
--- a/libgnucash/engine/gnc-option.cpp
+++ b/libgnucash/engine/gnc-option.cpp
@@ -119,7 +119,7 @@ GncOption::set_value(ValueType value)
                    std::is_same_v<ValueType, time64> ||
                    std::is_same_v<ValueType, uint16_t>)))
                 option.set_value(value);
-            if constexpr (is_same_decayed_v<decltype(option),
+           else if constexpr (is_same_decayed_v<decltype(option),
                           GncOptionMultichoiceValue>)
             {
                 if constexpr (is_same_decayed_v<ValueType,
@@ -131,6 +131,9 @@ GncOption::set_value(ValueType value)
                      std::is_same_v<std::remove_cv<ValueType>, char*>)
                     option.set_value(value);
             }
+            else
+                PWARN("No set_value handler: get_value returns %s, value_type is %s",
+                      typeid(option.get_value()).name(), typeid(value).name());
         }, *m_option);
 }