From 815eeb496f183265cec84d69d14c17d6416354b4 Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Sat, 30 Jul 2022 23:16:24 +0800 Subject: [PATCH] [gnc-plugin-page-register] g_slist_free param_list If (reg->type == SEARCH_LEDGER) then the GSList* created by qof_query_build_param_list would not be freed. This reordering avoids allocating GSList altogether when not needed. --- gnucash/gnome/gnc-plugin-page-register.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gnucash/gnome/gnc-plugin-page-register.c b/gnucash/gnome/gnc-plugin-page-register.c index dce7893b3f..bfa0f671c0 100644 --- a/gnucash/gnome/gnc-plugin-page-register.c +++ b/gnucash/gnome/gnc-plugin-page-register.c @@ -2738,7 +2738,6 @@ static void gnc_ppr_update_status_query (GncPluginPageRegister* page) { GncPluginPageRegisterPrivate* priv; - GSList* param_list; Query* query; SplitRegister* reg; @@ -2762,9 +2761,9 @@ gnc_ppr_update_status_query (GncPluginPageRegister* page) reg = gnc_ledger_display_get_split_register (priv->ledger); /* Remove the old status match */ - param_list = qof_query_build_param_list (SPLIT_RECONCILE, NULL); - if (param_list && (reg->type != SEARCH_LEDGER)) + if (reg->type != SEARCH_LEDGER) { + GSList *param_list = qof_query_build_param_list (SPLIT_RECONCILE, NULL); qof_query_purge_terms (query, param_list); g_slist_free (param_list); } @@ -2802,7 +2801,6 @@ static void gnc_ppr_update_date_query (GncPluginPageRegister* page) { GncPluginPageRegisterPrivate* priv; - GSList* param_list; Query* query; SplitRegister* reg; @@ -2827,9 +2825,10 @@ gnc_ppr_update_date_query (GncPluginPageRegister* page) reg = gnc_ledger_display_get_split_register (priv->ledger); /* Delete any existing old date spec. */ - param_list = qof_query_build_param_list (SPLIT_TRANS, TRANS_DATE_POSTED, NULL); - if (param_list && (reg->type != SEARCH_LEDGER)) + if (reg->type != SEARCH_LEDGER) { + GSList *param_list = qof_query_build_param_list (SPLIT_TRANS, + TRANS_DATE_POSTED, NULL); qof_query_purge_terms (query, param_list); g_slist_free (param_list); }