Fix Edit/Assign payment in business plugin

gnucash/gnome/gnc-plugin-business.c

@@ -798,6 +798,10 @@ gnc_plugin_business_update_menus (GncPluginPage *plugin_page)
     if (!GNC_IS_MAIN_WINDOW(plugin_page->window))
         return;
 
+    // We are readonly - we have already set particular actions to inactive.
+    if (qof_book_is_readonly (gnc_get_current_book()))
+        return;
+
     is_txn_register = GNC_IS_PLUGIN_PAGE_REGISTER(plugin_page);
     simple_action_group = gnc_main_window_get_action_group (GNC_MAIN_WINDOW(plugin_page->window),
                                                             PLUGIN_ACTIONS_NAME);
@@ -813,12 +817,9 @@ gnc_plugin_business_update_menus (GncPluginPage *plugin_page)
     // Change visibility and also sensitivity according to whether we are in a txn register
     gnc_plugin_update_actions (simple_action_group, register_txn_actions,
                                "sensitive", is_txn_register && !is_bus_txn && !is_bus_doc);
-    gnc_plugin_update_actions (simple_action_group, register_txn_actions,
-                               "visible", is_txn_register && !is_bus_txn && !is_bus_doc);
+
     gnc_plugin_update_actions (simple_action_group, register_bus_txn_actions,
                                "sensitive", is_txn_register && is_bus_txn && !is_bus_doc);
-    gnc_plugin_update_actions (simple_action_group, register_bus_txn_actions,
-                               "visible", is_txn_register && is_bus_txn && !is_bus_doc);
 }
 
 
@@ -827,8 +828,8 @@ gnc_plugin_business_main_window_page_changed (GncMainWindow *window,
                                               GncPluginPage *page,
                                               gpointer user_data)
 {
-    gnc_plugin_business_update_menus(page);
     update_inactive_actions(page);
+    gnc_plugin_business_update_menus(page);
 }