fix corruption/crasher bug where we free a transaction's guid without authority.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@15687 57a11ea4-9604-0410-9ed3-97b8803252fd

src/doc/sx.rst

@@ -56,7 +56,7 @@ TODO
 
 ! - [ ] with SLR open (with instances), add variables to SX; only newly-created instances will have appropriate variable tables.
 
-  - [ ] created/review txns disappear, eventual crash [ve20070303]_
+  - [x] created/review txns disappear, eventual crash [ve20070303]_
 
 ! - [x] auto-create (+notify) txns not in review list. [ve20070209]_
 
@@ -105,7 +105,7 @@ TODO
   - [#] type+ui-type -> type
 
 - use Recurrence instead of FreqSpec
-  - [ ] sx-from-trans, <http://bugzilla.gnome.org/show_bug.cgi?id=412633>
+! - [ ] sx-from-trans, <http://bugzilla.gnome.org/show_bug.cgi?id=412633>
 ! - [x] XML migration, handling
     - xml:freqSpec -> obj:Recurrence
       - [x] none (Recurrence doesn't support)

src/gnome/dialog-sx-since-last-run.c

@@ -1071,10 +1071,8 @@ dialog_response_cb(GtkDialog *dialog, gint response_id, GncSxSinceLastRunDialog
     if (gtk_toggle_button_get_active(app_dialog->review_created_txns_toggle)
         && g_list_length(app_dialog->created_txns) > 0)
     {
-
         _show_created_transactions(app_dialog, app_dialog->created_txns);
     }
-    g_list_foreach(app_dialog->created_txns, (GFunc)guid_free, NULL);
     g_list_free(app_dialog->created_txns);
     app_dialog->created_txns = NULL;