From 3e4e3349440106c66356f47abcf103a568eadffe Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Sun, 30 Nov 2025 20:47:54 +0800 Subject: [PATCH] [guid.cpp] string->guid: parse into uuid data, avoids memcpy --- libgnucash/engine/guid.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libgnucash/engine/guid.cpp b/libgnucash/engine/guid.cpp index 0fd36fd3d7..bebd4b8ae4 100644 --- a/libgnucash/engine/guid.cpp +++ b/libgnucash/engine/guid.cpp @@ -368,13 +368,8 @@ GUID::from_string (const char* str) if (!str) throw guid_syntax_exception {}; - uint8_t bytes[16]; - if (fast_string_to_guid(str, bytes)) - { - boost::uuids::uuid u; - std::memcpy(u.data, bytes, 16); - return GUID{u}; - } + if (boost::uuids::uuid u; fast_string_to_guid(str, u.data)) + return u; try { static boost::uuids::string_generator strgen;