From 353eee58cbf6510682cc511b651273a0d363220c Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Mon, 20 Aug 2018 10:34:39 +0800 Subject: [PATCH] [transaction] convert collector map to for-each collectors are accumulator-type objects, being mutated with each call, rather than functional objects. (map) is meant for functional constructs, returning a list to current continuation. We're not using the (map) output, so, change it to (for-each) to emphasise this. --- .../report/standard-reports/transaction.scm | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/gnucash/report/standard-reports/transaction.scm b/gnucash/report/standard-reports/transaction.scm index 694e648591..dbe2df6650 100644 --- a/gnucash/report/standard-reports/transaction.scm +++ b/gnucash/report/standard-reports/transaction.scm @@ -1605,23 +1605,23 @@ be excluded from periodic reporting.") (add-split-row othersplits calculated-cells def:alternate-row-style #f)) (delete current (xaccTransGetSplitList (xaccSplitGetParent current))))) - (map (lambda (collector value) - (if value - (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) - primary-subtotal-collectors - split-values) - - (map (lambda (collector value) - (if value - (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) - secondary-subtotal-collectors - split-values) - - (map (lambda (collector value) - (if value - (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) - total-collectors - split-values) + (for-each + (lambda (collector value) + (if value + (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) + primary-subtotal-collectors split-values) + + (for-each + (lambda (collector value) + (if value + (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) + secondary-subtotal-collectors split-values) + + (for-each + (lambda (collector value) + (if value + (collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value)))) + total-collectors split-values) (if (and primary-subtotal-comparator (or (not next)