From 1e1e9220813ee04a833b345512efce8ce945fba5 Mon Sep 17 00:00:00 2001 From: Simon Arlott Date: Sat, 24 Jun 2023 16:14:39 +0100 Subject: [PATCH] Fix null pointer dereference in gnc_split_register_save_to_copy_buffer() If the "transfer" cell has been changed while cutting or copying a split then it'll dereference the NULL "ft" value. Check that "ft" is not NULL. This is equivalent to the original behaviour before cb273b13a1269cf089c27e21192da444297fe3ae when the number of splits would have been determined to be 0 for the SCM_UNDEFINED value of "trans_scm". --- gnucash/register/ledger-core/split-register.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnucash/register/ledger-core/split-register.c b/gnucash/register/ledger-core/split-register.c index e26671098d..fef26495bd 100644 --- a/gnucash/register/ledger-core/split-register.c +++ b/gnucash/register/ledger-core/split-register.c @@ -1593,7 +1593,7 @@ gnc_split_register_save_to_copy_buffer (SplitRegister *reg, if (!other_fs) { - if (g_list_length (ft->m_splits) == 1) + if (ft && g_list_length (ft->m_splits) == 1) { Split* temp_split;