From 1d92071cd8d6260790168e80638d562e1c98ee6f Mon Sep 17 00:00:00 2001 From: Chris Shoemaker Date: Tue, 27 Dec 2005 19:14:07 +0000 Subject: [PATCH] Update patch submitting instructions. git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@12186 57a11ea4-9604-0410-9ed3-97b8803252fd --- README.patches | 24 ++++++++++++++++++------ README.svn | 6 +++--- make-gnucash-patch.in | 6 ++++-- 3 files changed, 25 insertions(+), 11 deletions(-) diff --git a/README.patches b/README.patches index 95d6fd2cbe..c69f49eb35 100644 --- a/README.patches +++ b/README.patches @@ -14,15 +14,27 @@ Submitting a Patch: Once you have done some work that you would like to submit, you need to send a patch. There are two ways to submit a patch. First, if - you're using CVS and only made changes to existing CVS files you + you're using SVN and only made changes to existing SVN files you can generate the patch using: - cvs -q diff -u > /tmp/mypatch + svn diff > /tmp/mypatch - and send /tmp/mypatch into the developers. Note that this ONLY WORKS - if you have NOT added any new files to the source tree. If you've - added new files then you should use a script called "make-gnucash-patch" - to help you create the patch for submission. + and send /tmp/mypatch to gnucash-devel@gnucash.org with `[PATCH]' + prefixed to the Subject: of the email. Note that this + ONLY WORKS if you have NOT added any new files to the source tree. + + If your patch adds new files, use the `-N' flag to diff between a + clean directory and your development directory. E.g. + + $ diff -urN {gnucash-pristine} {gnucash-mydevel} > /tmp/mypatch + +******************************************************************* +NOTE: The rest of this file describes an out-of-date utility that has +not been adapted to SVN. Don't use it. +******************************************************************* + + If you've added new files then you should use a script called + "make-gnucash-patch" to help you create the patch for submission. The script make-gnucash-patch is a perl script provided with the gnucash distribution that you can use to create your patch. The diff --git a/README.svn b/README.svn index 51a3bf3d9f..a04cb4b838 100644 --- a/README.svn +++ b/README.svn @@ -45,12 +45,12 @@ When making changes to GnuCash and trying to commit to the repository: to ask. But when in doubt, ask. Even if your change is correct, somebody may know a better way to do things. - If you want other people to review your code before it goes in, - you can submit your changes as a patch to gnucash-patches@gnucash.org. + Since you want other people to review your code before it goes in, + you can submit your changes as a patch to gnucash-devel@gnucash.org. See README.patches for details. If you are making changes to gnucash SVN, you should be subscribed - to gnucash-devel@gnucash.org and to gnucash-patches@gnucash.org. + to gnucash-devel@gnucash.org and to gnucash-changes@gnucash.org. (Subscription address: http://www.gnucash.org/en/lists.phtml) gnucash-devel@gnucash.org is a good place to ask about intended changes. diff --git a/make-gnucash-patch.in b/make-gnucash-patch.in index 887f925d2b..b6cc3f102d 100644 --- a/make-gnucash-patch.in +++ b/make-gnucash-patch.in @@ -3,8 +3,8 @@ # # This perl script is used to make a patch for your GnuCash # development work. All patches should be submitted to the -# mailing list gnucash-patches@gnucash.org. For more info -# consult the README. +# mailing list gnucash-devel@gnucash.org. For more info +# consult README.patches # # WARNING: By default, this script will checkout an entire # up to date copy of the source tree in ../tmp/gnucash/. @@ -27,6 +27,8 @@ $::ask_description = 1; $::should_uuencode = 1; $::diffcmd = "diff -up"; +die "This utility has not been updated to use SVN. Sorry, just use diff(1)."; + my $rcfile = $ENV{"HOME"} . "/.gnucash-patch.rc"; if (-f $rcfile) {