boundary

History

Jeff Mitchell 602bbcc43e Fix intermittent startup issues on slow systems (#3803 ) With a suitably slow system -- say, if you're waiting on a Windows Terminal to output text inside a virtual machine -- the expected order of things can be thrown off. One specific way this can happen is that the worker can attempt to dial and have its dial fail because of the slowness causing the dial context to time out. If, because of the slowness, we also haven't released the log gate yet, then the event with the failure information will be queued, along with the context that was used. Unfortunately, in some of these error cases, the context that was used was the dial context instead of the system base context. In many other places in the function it was the system base context so this is just a mismatch, probably from code written at different times. Normally this wouldn't be a problem as we'd fall back to the underlying logger, but when we release the log gate, things happen differently: it's a synchronous function and on error it causes us to abandon system startup entirely. This commit fixes the issue with using the incorrect context. It's an open question whether we should change the behavior around errors when replaying queued events, falling back to the underlying logger instead of erroring.		2 years ago
..
common	[COMPLIANCE] License changes (#3567 )	3 years ago
internal/metric	[COMPLIANCE] License changes (#3567 )	3 years ago
proxy	[COMPLIANCE] License changes (#3567 )	3 years ago
session	refact(event): move observability/event to event (#3704 )	3 years ago
addressreceiver.go	[COMPLIANCE] License changes (#3567 )	3 years ago
auth_rotation.go	refact(event): move observability/event to event (#3704 )	3 years ago
auth_rotation_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
config.go	[COMPLIANCE] License changes (#3567 )	3 years ago
controller_connection.go	Fix intermittent startup issues on slow systems (#3803 )	2 years ago
controller_connection_test.go	feat: Worker Connectivity Health Check (#3650 )	3 years ago
countingconn.go	[COMPLIANCE] License changes (#3567 )	3 years ago
countingconn_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
handler.go	refact(event): move observability/event to event (#3704 )	3 years ago
health.go	feat: Worker Connectivity Health Check (#3650 )	3 years ago
health_test.go	feat: Worker Connectivity Health Check (#3650 )	3 years ago
listeners.go	fix (events): convert multierror to stdlib error (#3743 )	3 years ago
listeners_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
package_registration.go	[COMPLIANCE] License changes (#3567 )	3 years ago
rpc_registration.go	[COMPLIANCE] License changes (#3567 )	3 years ago
rpc_registration_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
status.go	feat(worker): allow hcp cluster id to be sourced from env var (#3709 )	3 years ago
status_test.go	refact(event): move observability/event to event (#3704 )	3 years ago
testing.go	refact(event): move observability/event to event (#3704 )	3 years ago
testing_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
worker.go	pass storage an empty context so it can close cleanly (#3653 )	3 years ago
worker_proxy_service.go	[COMPLIANCE] License changes (#3567 )	3 years ago
worker_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago
workerdisconnect_test.go	[COMPLIANCE] License changes (#3567 )	3 years ago