mirror of https://github.com/hashicorp/boundary
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
423 lines
12 KiB
423 lines
12 KiB
package target
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/boundary/internal/db"
|
|
dbassert "github.com/hashicorp/boundary/internal/db/assert"
|
|
"github.com/hashicorp/boundary/internal/errors"
|
|
"github.com/hashicorp/boundary/internal/host/static"
|
|
"github.com/hashicorp/boundary/internal/iam"
|
|
"github.com/hashicorp/boundary/internal/kms"
|
|
"github.com/hashicorp/boundary/internal/oplog"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
func TestRepository_CreateTcpTarget(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
_, proj := iam.TestScopes(t, iam.TestRepo(t, conn, wrapper))
|
|
|
|
cats := static.TestCatalogs(t, conn, proj.PublicId, 1)
|
|
hsets := static.TestSets(t, conn, cats[0].GetPublicId(), 2)
|
|
var sets []string
|
|
for _, s := range hsets {
|
|
sets = append(sets, s.PublicId)
|
|
}
|
|
|
|
type args struct {
|
|
target *TcpTarget
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantHostSets []string
|
|
wantErr bool
|
|
wantIsError error
|
|
}{
|
|
{
|
|
name: "valid-org",
|
|
args: args{
|
|
target: func() *TcpTarget {
|
|
target, err := NewTcpTarget(proj.PublicId,
|
|
WithName("valid-org"),
|
|
WithDescription("valid-org"),
|
|
WithDefaultPort(uint32(22)))
|
|
require.NoError(t, err)
|
|
return target
|
|
}(),
|
|
opt: []Option{WithHostSets(sets)},
|
|
},
|
|
wantErr: false,
|
|
wantHostSets: sets,
|
|
},
|
|
{
|
|
name: "nil-target",
|
|
args: args{
|
|
target: nil,
|
|
},
|
|
wantErr: true,
|
|
wantIsError: errors.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "nil-target-store",
|
|
args: args{
|
|
target: func() *TcpTarget {
|
|
target := &TcpTarget{}
|
|
return target
|
|
}(),
|
|
},
|
|
wantErr: true,
|
|
wantIsError: errors.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "public-id-not-empty",
|
|
args: args{
|
|
target: func() *TcpTarget {
|
|
target, err := NewTcpTarget(proj.PublicId, WithName("valid-org"), WithDescription("valid-org"), WithDefaultPort(uint32(22)))
|
|
require.NoError(t, err)
|
|
id, err := newTcpTargetId()
|
|
require.NoError(t, err)
|
|
target.PublicId = id
|
|
return target
|
|
}(),
|
|
},
|
|
wantErr: true,
|
|
wantIsError: errors.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "empty-scope-id",
|
|
args: args{
|
|
target: func() *TcpTarget {
|
|
target := allocTcpTarget()
|
|
target.Name = "empty-scope-id"
|
|
require.NoError(t, err)
|
|
return &target
|
|
}(),
|
|
},
|
|
wantErr: true,
|
|
wantIsError: errors.ErrInvalidParameter,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
target, hostSets, err := repo.CreateTcpTarget(context.Background(), tt.args.target, tt.args.opt...)
|
|
if tt.wantErr {
|
|
assert.Error(err)
|
|
assert.Nil(target)
|
|
if tt.wantIsError != nil {
|
|
assert.True(errors.Is(err, tt.wantIsError))
|
|
}
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
assert.NotNil(target.GetPublicId())
|
|
gotIds := make([]string, 0, len(hostSets))
|
|
for _, s := range hostSets {
|
|
gotIds = append(gotIds, s.PublicId)
|
|
}
|
|
assert.Equal(tt.wantHostSets, gotIds)
|
|
|
|
foundTarget, foundHostSets, err := repo.LookupTarget(context.Background(), target.GetPublicId())
|
|
assert.NoError(err)
|
|
assert.True(proto.Equal(target.(*TcpTarget), foundTarget.(*TcpTarget)))
|
|
assert.Equal(hostSets, foundHostSets)
|
|
|
|
err = db.TestVerifyOplog(t, rw, target.GetPublicId(), db.WithOperation(oplog.OpType_OP_TYPE_CREATE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.NoError(err)
|
|
|
|
// TODO (jimlambrt 9/2020) - unfortunately, we can currently
|
|
// test to make sure that the oplog entry for a target host sets
|
|
// create exist because the db.TestVerifyOplog doesn't really
|
|
// support that level of testing and the previous call to
|
|
// CreateTcpTarget would create an oplog entry for the
|
|
// create on the target even if no host sets were added. Once
|
|
// TestVerifyOplog supports the appropriate granularity, we should
|
|
// add an appropriate assert.
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_UpdateTcpTarget(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
id := testId(t)
|
|
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
_, proj := iam.TestScopes(t, iamRepo)
|
|
pubId := func(s string) *string { return &s }
|
|
|
|
type args struct {
|
|
name string
|
|
description string
|
|
port uint32
|
|
fieldMaskPaths []string
|
|
opt []Option
|
|
ScopeId string
|
|
PublicId *string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
newScopeId string
|
|
newName string
|
|
newTargetOpts []Option
|
|
args args
|
|
wantRowsUpdate int
|
|
wantErr bool
|
|
wantErrMsg string
|
|
wantIsError error
|
|
wantDup bool
|
|
}{
|
|
{
|
|
name: "valid",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: false,
|
|
wantRowsUpdate: 1,
|
|
},
|
|
{
|
|
name: "valid-no-op",
|
|
args: args{
|
|
name: "valid-no-op" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
newName: "valid-no-op" + id,
|
|
wantErr: false,
|
|
wantRowsUpdate: 1,
|
|
},
|
|
{
|
|
name: "not-found",
|
|
args: args{
|
|
name: "not-found" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
PublicId: func() *string { s := "1"; return &s }(),
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: update: lookup after write: record not found",
|
|
wantIsError: errors.ErrRecordNotFound,
|
|
},
|
|
{
|
|
name: "null-name",
|
|
args: args{
|
|
name: "",
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
newName: "null-name" + id,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: update: failed: pq: null value in column ",
|
|
},
|
|
{
|
|
name: "null-description",
|
|
args: args{
|
|
name: "null-description",
|
|
fieldMaskPaths: []string{"Description"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
newTargetOpts: []Option{WithDescription("null-description" + id)},
|
|
wantErr: false,
|
|
wantRowsUpdate: 1,
|
|
},
|
|
{
|
|
name: "empty-field-mask",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: []string{},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: empty field mask",
|
|
wantIsError: errors.ErrEmptyFieldMask,
|
|
},
|
|
{
|
|
name: "nil-fieldmask",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: nil,
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: empty field mask",
|
|
wantIsError: errors.ErrEmptyFieldMask,
|
|
},
|
|
{
|
|
name: "read-only-fields",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: []string{"CreateTime"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: field: CreateTime: invalid field mask",
|
|
wantIsError: errors.ErrInvalidFieldMask,
|
|
},
|
|
{
|
|
name: "unknown-fields",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: []string{"Alice"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantRowsUpdate: 0,
|
|
wantErrMsg: "update tcp target: field: Alice: invalid field mask",
|
|
wantIsError: errors.ErrInvalidFieldMask,
|
|
},
|
|
{
|
|
name: "no-public-id",
|
|
args: args{
|
|
name: "valid" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
PublicId: pubId(""),
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantErrMsg: "update tcp target: missing target public id invalid parameter",
|
|
wantIsError: errors.ErrInvalidParameter,
|
|
wantRowsUpdate: 0,
|
|
},
|
|
{
|
|
name: "proj-scope-id-no-mask",
|
|
args: args{
|
|
name: "proj-scope-id" + id,
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantErrMsg: "update tcp target: empty field mask",
|
|
wantIsError: errors.ErrEmptyFieldMask,
|
|
},
|
|
{
|
|
name: "empty-scope-id-with-name-mask",
|
|
args: args{
|
|
name: "empty-scope-id" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: "",
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: false,
|
|
wantRowsUpdate: 1,
|
|
},
|
|
{
|
|
name: "dup-name",
|
|
args: args{
|
|
name: "dup-name" + id,
|
|
fieldMaskPaths: []string{"Name"},
|
|
ScopeId: proj.PublicId,
|
|
},
|
|
newScopeId: proj.PublicId,
|
|
wantErr: true,
|
|
wantDup: true,
|
|
wantErrMsg: " already exists in scope " + proj.PublicId,
|
|
wantIsError: errors.ErrNotUnique,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
require, assert := require.New(t), assert.New(t)
|
|
if tt.wantDup {
|
|
_ = TestTcpTarget(t, conn, proj.PublicId, tt.args.name)
|
|
}
|
|
|
|
testCats := static.TestCatalogs(t, conn, proj.PublicId, 1)
|
|
hsets := static.TestSets(t, conn, testCats[0].GetPublicId(), 5)
|
|
testHostSetIds := make([]string, 0, len(hsets))
|
|
for _, hs := range hsets {
|
|
testHostSetIds = append(testHostSetIds, hs.PublicId)
|
|
}
|
|
tt.newTargetOpts = append(tt.newTargetOpts, WithHostSets(testHostSetIds))
|
|
name := tt.newName
|
|
if name == "" {
|
|
name = testId(t)
|
|
}
|
|
target := TestTcpTarget(t, conn, tt.newScopeId, name, tt.newTargetOpts...)
|
|
updateTarget := allocTcpTarget()
|
|
updateTarget.PublicId = target.PublicId
|
|
if tt.args.PublicId != nil {
|
|
updateTarget.PublicId = *tt.args.PublicId
|
|
}
|
|
updateTarget.ScopeId = tt.args.ScopeId
|
|
updateTarget.Name = tt.args.name
|
|
updateTarget.Description = tt.args.description
|
|
updateTarget.DefaultPort = tt.args.port
|
|
|
|
targetAfterUpdate, hostSets, updatedRows, err := repo.UpdateTcpTarget(context.Background(), &updateTarget, target.Version, tt.args.fieldMaskPaths, tt.args.opt...)
|
|
if tt.wantErr {
|
|
assert.Error(err)
|
|
if tt.wantIsError != nil {
|
|
assert.True(errors.Is(err, tt.wantIsError))
|
|
}
|
|
assert.Nil(targetAfterUpdate)
|
|
assert.Equal(0, updatedRows)
|
|
assert.Contains(err.Error(), tt.wantErrMsg)
|
|
err = db.TestVerifyOplog(t, rw, target.PublicId, db.WithOperation(oplog.OpType_OP_TYPE_UPDATE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.Error(err)
|
|
assert.True(errors.Is(errors.ErrRecordNotFound, err))
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
require.NotNil(targetAfterUpdate)
|
|
assert.Equal(tt.wantRowsUpdate, updatedRows)
|
|
afterUpdateIds := make([]string, 0, len(hostSets))
|
|
for _, hs := range hostSets {
|
|
afterUpdateIds = append(afterUpdateIds, hs.PublicId)
|
|
}
|
|
assert.Equal(testHostSetIds, afterUpdateIds)
|
|
|
|
switch tt.name {
|
|
case "valid-no-op":
|
|
assert.Equal(target.UpdateTime, targetAfterUpdate.(*TcpTarget).UpdateTime)
|
|
default:
|
|
assert.NotEqual(target.UpdateTime, targetAfterUpdate.(*TcpTarget).UpdateTime)
|
|
}
|
|
foundTarget, _, err := repo.LookupTarget(context.Background(), target.PublicId)
|
|
assert.NoError(err)
|
|
assert.True(proto.Equal(targetAfterUpdate.((*TcpTarget)), foundTarget.((*TcpTarget))))
|
|
dbassert := dbassert.New(t, conn.DB())
|
|
if tt.args.description == "" {
|
|
assert.Equal(foundTarget.GetDescription(), "")
|
|
dbassert.IsNull(foundTarget, "description")
|
|
}
|
|
err = db.TestVerifyOplog(t, rw, target.PublicId, db.WithOperation(oplog.OpType_OP_TYPE_UPDATE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.NoError(err)
|
|
})
|
|
}
|
|
}
|