mirror of https://github.com/hashicorp/boundary
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
764 lines
22 KiB
764 lines
22 KiB
package target
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"sort"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/boundary/internal/db"
|
|
"github.com/hashicorp/boundary/internal/host/static"
|
|
"github.com/hashicorp/boundary/internal/iam"
|
|
"github.com/hashicorp/boundary/internal/kms"
|
|
"github.com/hashicorp/boundary/internal/oplog"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
func TestNewRepository(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
type args struct {
|
|
r db.Reader
|
|
w db.Writer
|
|
kms *kms.Kms
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *Repository
|
|
wantErr bool
|
|
wantErrString string
|
|
}{
|
|
{
|
|
name: "valid",
|
|
args: args{
|
|
r: rw,
|
|
w: rw,
|
|
kms: testKms,
|
|
},
|
|
want: &Repository{
|
|
reader: rw,
|
|
writer: rw,
|
|
kms: testKms,
|
|
defaultLimit: db.DefaultLimit,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "nil-kms",
|
|
args: args{
|
|
r: rw,
|
|
w: rw,
|
|
kms: nil,
|
|
},
|
|
want: nil,
|
|
wantErr: true,
|
|
wantErrString: "error creating db repository with nil kms",
|
|
},
|
|
{
|
|
name: "nil-writer",
|
|
args: args{
|
|
r: rw,
|
|
w: nil,
|
|
kms: testKms,
|
|
},
|
|
want: nil,
|
|
wantErr: true,
|
|
wantErrString: "error creating db repository with nil writer",
|
|
},
|
|
{
|
|
name: "nil-reader",
|
|
args: args{
|
|
r: nil,
|
|
w: rw,
|
|
kms: testKms,
|
|
},
|
|
want: nil,
|
|
wantErr: true,
|
|
wantErrString: "error creating db repository with nil reader",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
got, err := NewRepository(tt.args.r, tt.args.w, tt.args.kms)
|
|
if tt.wantErr {
|
|
require.Error(err)
|
|
assert.Equal(err.Error(), tt.wantErrString)
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
assert.Equal(tt.want, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_ListTargets(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
const testLimit = 10
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
_, proj := iam.TestScopes(t, iamRepo)
|
|
rw := db.New(conn)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
repo.defaultLimit = testLimit
|
|
|
|
type args struct {
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
createCnt int
|
|
createScopeId string
|
|
createScopeId2 string
|
|
grantUserId string
|
|
args args
|
|
wantCnt int
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "tcp-target",
|
|
createCnt: 5,
|
|
createScopeId: proj.PublicId,
|
|
args: args{
|
|
opt: []Option{WithTargetType(TcpTargetType), WithScopeId(proj.PublicId)},
|
|
},
|
|
wantCnt: 5,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no-limit",
|
|
createCnt: testLimit + 1,
|
|
createScopeId: proj.PublicId,
|
|
args: args{
|
|
opt: []Option{WithLimit(-1), WithScopeId(proj.PublicId)},
|
|
},
|
|
wantCnt: testLimit + 1,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "default-limit",
|
|
createCnt: testLimit + 1,
|
|
createScopeId: proj.PublicId,
|
|
args: args{
|
|
opt: []Option{WithScopeId(proj.PublicId)},
|
|
},
|
|
wantCnt: testLimit,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "custom-limit",
|
|
createCnt: testLimit + 1,
|
|
createScopeId: proj.PublicId,
|
|
args: args{
|
|
opt: []Option{WithLimit(3), WithScopeId(proj.PublicId)},
|
|
},
|
|
wantCnt: 3,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "bad-org",
|
|
createCnt: 1,
|
|
createScopeId: proj.PublicId,
|
|
args: args{
|
|
opt: []Option{WithScopeId("bad-id")},
|
|
},
|
|
wantCnt: 0,
|
|
wantErr: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
require.NoError(conn.Where("1=1").Delete(allocTcpTarget()).Error)
|
|
testGroups := []*TcpTarget{}
|
|
for i := 0; i < tt.createCnt; i++ {
|
|
switch {
|
|
case tt.createScopeId2 != "" && i%2 == 0:
|
|
testGroups = append(testGroups, TestTcpTarget(t, conn, tt.createScopeId2, strconv.Itoa(i)))
|
|
default:
|
|
testGroups = append(testGroups, TestTcpTarget(t, conn, tt.createScopeId, strconv.Itoa(i)))
|
|
}
|
|
}
|
|
assert.Equal(tt.createCnt, len(testGroups))
|
|
got, err := repo.ListTargets(context.Background(), tt.args.opt...)
|
|
if tt.wantErr {
|
|
require.Error(err)
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
assert.Equal(tt.wantCnt, len(got))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_DeleteTarget(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
_, proj := iam.TestScopes(t, iamRepo)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
|
|
type args struct {
|
|
target Target
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantRowsDeleted int
|
|
wantErr bool
|
|
wantErrMsg string
|
|
}{
|
|
{
|
|
name: "valid",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "valid"),
|
|
},
|
|
wantRowsDeleted: 1,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no-public-id",
|
|
args: args{
|
|
target: func() Target {
|
|
target := allocTcpTarget()
|
|
return &target
|
|
}(),
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
wantErrMsg: "delete target: missing public id invalid parameter",
|
|
},
|
|
{
|
|
name: "not-found",
|
|
args: args{
|
|
target: func() Target {
|
|
id, err := newTcpTargetId()
|
|
require.NoError(t, err)
|
|
target := allocTcpTarget()
|
|
target.PublicId = id
|
|
return &target
|
|
}(),
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
wantErrMsg: "delete target: failed record not found for ",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
deletedRows, err := repo.DeleteTarget(context.Background(), tt.args.target.GetPublicId(), tt.args.opt...)
|
|
if tt.wantErr {
|
|
assert.Error(err)
|
|
assert.Equal(0, deletedRows)
|
|
assert.Contains(err.Error(), tt.wantErrMsg)
|
|
err = db.TestVerifyOplog(t, rw, tt.args.target.GetPublicId(), db.WithOperation(oplog.OpType_OP_TYPE_DELETE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.Error(err)
|
|
assert.True(errors.Is(db.ErrRecordNotFound, err))
|
|
return
|
|
}
|
|
assert.NoError(err)
|
|
assert.Equal(tt.wantRowsDeleted, deletedRows)
|
|
foundGroup, _, err := repo.LookupTarget(context.Background(), tt.args.target.GetPublicId())
|
|
assert.NoError(err)
|
|
assert.Nil(foundGroup)
|
|
|
|
err = db.TestVerifyOplog(t, rw, tt.args.target.GetPublicId(), db.WithOperation(oplog.OpType_OP_TYPE_DELETE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.NoError(err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_AddTargetHostSets(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
staticOrg, staticProj := iam.TestScopes(t, iamRepo)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
|
|
createHostSetsFn := func(orgs, projects []string) []string {
|
|
results := []string{}
|
|
for _, publicId := range orgs {
|
|
cats := static.TestCatalogs(t, conn, publicId, 1)
|
|
hsets := static.TestSets(t, conn, cats[0].GetPublicId(), 1)
|
|
results = append(results, hsets[0].PublicId)
|
|
}
|
|
for _, publicId := range projects {
|
|
cats := static.TestCatalogs(t, conn, publicId, 1)
|
|
hsets := static.TestSets(t, conn, cats[0].GetPublicId(), 1)
|
|
results = append(results, hsets[0].PublicId)
|
|
}
|
|
return results
|
|
}
|
|
|
|
type args struct {
|
|
targetVersion uint32
|
|
wantTargetIds bool
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantErr bool
|
|
wantErrIs error
|
|
}{
|
|
{
|
|
name: "valid",
|
|
args: args{
|
|
targetVersion: 1,
|
|
wantTargetIds: true,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "bad-version",
|
|
args: args{
|
|
targetVersion: 1000,
|
|
wantTargetIds: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "zero-version",
|
|
args: args{
|
|
targetVersion: 0,
|
|
wantTargetIds: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "no-host-sets",
|
|
args: args{
|
|
targetVersion: 1,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
require.NoError(conn.Where("1=1").Delete(allocTargetHostSet()).Error)
|
|
require.NoError(conn.Where("1=1").Delete(allocTcpTarget()).Error)
|
|
|
|
projTarget := TestTcpTarget(t, conn, staticProj.PublicId, "static-proj")
|
|
|
|
var hostSetIds []string
|
|
origTarget, origHostSet, err := repo.LookupTarget(context.Background(), projTarget.PublicId)
|
|
require.NoError(err)
|
|
require.Equal(0, len(origHostSet))
|
|
|
|
if tt.args.wantTargetIds {
|
|
hostSetIds = createHostSetsFn([]string{staticOrg.PublicId}, []string{staticProj.PublicId})
|
|
}
|
|
|
|
gotTarget, gotHostSets, err := repo.AddTargetHostSets(context.Background(), projTarget.PublicId, tt.args.targetVersion, hostSetIds, tt.args.opt...)
|
|
if tt.wantErr {
|
|
require.Error(err)
|
|
if tt.wantErrIs != nil {
|
|
assert.Truef(errors.Is(err, tt.wantErrIs), "unexpected error %s", err.Error())
|
|
}
|
|
// test to see of the target version update oplog was not created
|
|
err = db.TestVerifyOplog(t, rw, projTarget.PublicId, db.WithOperation(oplog.OpType_OP_TYPE_UPDATE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.Error(err)
|
|
|
|
// TODO (jimlambrt 9/2020) - unfortunately, we can currently
|
|
// test to make sure that the oplog entry for a target create
|
|
// doesn't exist because the db.TestVerifyOplog doesn't really
|
|
// support that level of testing and the previous call to
|
|
// TestTcpTarget would create an oplog entry for the
|
|
// create on the target. Once TestVerifyOplog supports the
|
|
// appropriate granularity, we should add an appropriate assert.
|
|
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
gotHostSet := map[string]*TargetSet{}
|
|
for _, s := range gotHostSets {
|
|
gotHostSet[s.PublicId] = s
|
|
}
|
|
|
|
// TODO (jimlambrt 9/2020) - unfortunately, we can currently
|
|
// test to make sure that the oplog entry for a target create
|
|
// doesn't exist because the db.TestVerifyOplog doesn't really
|
|
// support that level of testing and the previous call to
|
|
// TestTcpTarget would create an oplog entry for the
|
|
// create on the target. Once TestVerifyOplog supports the
|
|
// appropriate granularity, we should add an appropriate assert.
|
|
|
|
// test to see of the target version update oplog was created
|
|
err = db.TestVerifyOplog(t, rw, projTarget.PublicId, db.WithOperation(oplog.OpType_OP_TYPE_UPDATE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.NoError(err)
|
|
|
|
foundHostSets, err := fetchSets(context.Background(), rw, projTarget.PublicId)
|
|
require.NoError(err)
|
|
for _, s := range foundHostSets {
|
|
assert.NotEmpty(gotHostSet[s.PublicId])
|
|
}
|
|
|
|
target, ths, err := repo.LookupTarget(context.Background(), projTarget.PublicId)
|
|
require.NoError(err)
|
|
assert.Equal(tt.args.targetVersion+1, target.GetVersion())
|
|
assert.Equal(origTarget.GetVersion(), target.GetVersion()-1)
|
|
assert.Equal(gotHostSets, ths)
|
|
assert.True(proto.Equal(gotTarget.(*TcpTarget), target.(*TcpTarget)))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_DeleteTargetHosts(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
_, proj := iam.TestScopes(t, iamRepo)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
|
|
type args struct {
|
|
target Target
|
|
targetIdOverride *string
|
|
targetVersionOverride *uint32
|
|
createCnt int
|
|
deleteCnt int
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantRowsDeleted int
|
|
wantErr bool
|
|
wantIsErr error
|
|
}{
|
|
{
|
|
name: "valid",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "valid"),
|
|
createCnt: 5,
|
|
deleteCnt: 5,
|
|
},
|
|
wantRowsDeleted: 5,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid-keeping-some",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "valid-keeping-some"),
|
|
createCnt: 5,
|
|
deleteCnt: 2,
|
|
},
|
|
wantRowsDeleted: 2,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no-deletes",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "no-deletes"),
|
|
createCnt: 5,
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
wantIsErr: db.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "not-found",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "not-found"),
|
|
targetIdOverride: func() *string { id := testId(t); return &id }(),
|
|
createCnt: 5,
|
|
deleteCnt: 5,
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "missing-target-id",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "missing-target-id"),
|
|
targetIdOverride: func() *string { id := ""; return &id }(),
|
|
createCnt: 5,
|
|
deleteCnt: 5,
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
wantIsErr: db.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "zero-version",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "zero-version"),
|
|
targetVersionOverride: func() *uint32 { v := uint32(0); return &v }(),
|
|
createCnt: 5,
|
|
deleteCnt: 5,
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
wantIsErr: db.ErrInvalidParameter,
|
|
},
|
|
{
|
|
name: "bad-version",
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "bad-version"),
|
|
targetVersionOverride: func() *uint32 { v := uint32(1000); return &v }(),
|
|
createCnt: 5,
|
|
deleteCnt: 5,
|
|
},
|
|
wantRowsDeleted: 0,
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
hsIds := make([]string, 0, tt.args.createCnt)
|
|
if tt.args.createCnt > 0 {
|
|
for i := 0; i < tt.args.createCnt; i++ {
|
|
cats := static.TestCatalogs(t, conn, proj.PublicId, 1)
|
|
hsets := static.TestSets(t, conn, cats[0].GetPublicId(), 1)
|
|
hsIds = append(hsIds, hsets[0].PublicId)
|
|
}
|
|
}
|
|
_, addedHostSets, err := repo.AddTargetHostSets(context.Background(), tt.args.target.GetPublicId(), 1, hsIds, tt.args.opt...)
|
|
require.NoError(err)
|
|
assert.Equal(tt.args.createCnt, len(addedHostSets))
|
|
|
|
deleteHostSets := make([]string, 0, tt.args.deleteCnt)
|
|
for i := 0; i < tt.args.deleteCnt; i++ {
|
|
deleteHostSets = append(deleteHostSets, hsIds[i])
|
|
}
|
|
var targetId string
|
|
switch {
|
|
case tt.args.targetIdOverride != nil:
|
|
targetId = *tt.args.targetIdOverride
|
|
default:
|
|
targetId = tt.args.target.GetPublicId()
|
|
}
|
|
var targetVersion uint32
|
|
switch {
|
|
case tt.args.targetVersionOverride != nil:
|
|
targetVersion = *tt.args.targetVersionOverride
|
|
default:
|
|
targetVersion = 2
|
|
}
|
|
deletedRows, err := repo.DeleteTargeHostSets(context.Background(), targetId, targetVersion, deleteHostSets, tt.args.opt...)
|
|
if tt.wantErr {
|
|
assert.Error(err)
|
|
assert.Equal(0, deletedRows)
|
|
if tt.wantIsErr != nil {
|
|
assert.Truef(errors.Is(err, tt.wantIsErr), "unexpected error %s", err.Error())
|
|
}
|
|
// TODO (jimlambrt 9/2020) - unfortunately, we can currently
|
|
// test to make sure that the oplog entry for a target update
|
|
// doesn't exist because the db.TestVerifyOplog doesn't really
|
|
// support that level of testing and the previous call to
|
|
// repo.AddTargetHostSets() would create an oplog entry for the
|
|
// update to the target. Once TestVerifyOplog supports the
|
|
// appropriate granularity, we should add an appropriate assert.
|
|
|
|
err = db.TestVerifyOplog(t, rw, tt.args.target.GetPublicId(), db.WithOperation(oplog.OpType_OP_TYPE_DELETE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.Error(err)
|
|
assert.True(errors.Is(db.ErrRecordNotFound, err))
|
|
return
|
|
}
|
|
require.NoError(err)
|
|
assert.Equal(tt.wantRowsDeleted, deletedRows)
|
|
|
|
// TODO (jimlambrt 9/2020) - unfortunately, we can currently
|
|
// test to make sure that the oplog entry for a target update
|
|
// doesn't exist because the db.TestVerifyOplog doesn't really
|
|
// support that level of testing and the previous call to
|
|
// repo.AddTargetHostSets() would create an oplog entry for the
|
|
// update to the target. Once TestVerifyOplog supports the
|
|
// appropriate granularity,, we should add an appropriate assert.
|
|
|
|
// we should find the oplog for the delete of target host sets
|
|
err = db.TestVerifyOplog(t, rw, tt.args.target.GetPublicId(), db.WithOperation(oplog.OpType_OP_TYPE_DELETE), db.WithCreateNotBefore(10*time.Second))
|
|
assert.NoError(err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepository_SetTargetHostSets(t *testing.T) {
|
|
t.Parallel()
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
rw := db.New(conn)
|
|
wrapper := db.TestWrapper(t)
|
|
testKms := kms.TestKms(t, conn, wrapper)
|
|
repo, err := NewRepository(rw, rw, testKms)
|
|
require.NoError(t, err)
|
|
|
|
iamRepo := iam.TestRepo(t, conn, wrapper)
|
|
_, proj := iam.TestScopes(t, iamRepo)
|
|
|
|
testCats := static.TestCatalogs(t, conn, proj.PublicId, 1)
|
|
hsets := static.TestSets(t, conn, testCats[0].GetPublicId(), 5)
|
|
testHostSetIds := make([]string, 0, len(hsets))
|
|
for _, hs := range hsets {
|
|
testHostSetIds = append(testHostSetIds, hs.PublicId)
|
|
}
|
|
|
|
createHostSetsFn := func() []string {
|
|
results := []string{}
|
|
for i := 0; i < 10; i++ {
|
|
cats := static.TestCatalogs(t, conn, proj.PublicId, 1)
|
|
hsets := static.TestSets(t, conn, cats[0].GetPublicId(), 1)
|
|
results = append(results, hsets[0].PublicId)
|
|
}
|
|
return results
|
|
}
|
|
|
|
setupFn := func(target Target) []*TargetSet {
|
|
hs := createHostSetsFn()
|
|
_, created, err := repo.AddTargetHostSets(context.Background(), target.GetPublicId(), 1, hs)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 10, len(created))
|
|
return created
|
|
}
|
|
type args struct {
|
|
target Target
|
|
targetVersion uint32
|
|
hostSetIds []string
|
|
addToOrigHostSets bool
|
|
opt []Option
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
setup func(Target) []*TargetSet
|
|
args args
|
|
wantAffectedRows int
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "clear",
|
|
setup: setupFn,
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "clear"),
|
|
targetVersion: 2, // yep, since setupFn will increment it to 2
|
|
hostSetIds: []string{},
|
|
},
|
|
wantErr: false,
|
|
wantAffectedRows: 10,
|
|
},
|
|
{
|
|
name: "no-change",
|
|
setup: setupFn,
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "no-change"),
|
|
targetVersion: 2, // yep, since setupFn will increment it to 2
|
|
hostSetIds: []string{},
|
|
addToOrigHostSets: true,
|
|
},
|
|
wantErr: false,
|
|
wantAffectedRows: 0,
|
|
},
|
|
{
|
|
name: "add-sets",
|
|
setup: setupFn,
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "add-sets"),
|
|
targetVersion: 2, // yep, since setupFn will increment it to 2
|
|
hostSetIds: []string{testHostSetIds[0], testHostSetIds[1]},
|
|
addToOrigHostSets: true,
|
|
},
|
|
wantErr: false,
|
|
wantAffectedRows: 2,
|
|
},
|
|
{
|
|
name: "add host sets with zero version",
|
|
setup: setupFn,
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "add host sets with zero version"),
|
|
targetVersion: 0,
|
|
hostSetIds: []string{testHostSetIds[0], testHostSetIds[1]},
|
|
addToOrigHostSets: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "remove existing and add users and grps",
|
|
setup: setupFn,
|
|
args: args{
|
|
target: TestTcpTarget(t, conn, proj.PublicId, "remove existing and add users and grps"),
|
|
targetVersion: 2, // yep, since setupFn will increment it to 2
|
|
hostSetIds: []string{testHostSetIds[0], testHostSetIds[1]},
|
|
addToOrigHostSets: false,
|
|
},
|
|
wantErr: false,
|
|
wantAffectedRows: 12,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
var origHostSets []*TargetSet
|
|
if tt.setup != nil {
|
|
origHostSets = tt.setup(tt.args.target)
|
|
}
|
|
if tt.args.addToOrigHostSets {
|
|
origIds := make([]string, 0, len(origHostSets))
|
|
for _, s := range origHostSets {
|
|
origIds = append(origIds, s.PublicId)
|
|
}
|
|
tt.args.hostSetIds = append(tt.args.hostSetIds, origIds...)
|
|
}
|
|
origTarget, lookedUpHs, err := repo.LookupTarget(context.Background(), tt.args.target.GetPublicId())
|
|
require.NoError(err)
|
|
assert.Equal(len(origHostSets), len(lookedUpHs))
|
|
|
|
got, affectedRows, err := repo.SetTargetHostSets(context.Background(), tt.args.target.GetPublicId(), tt.args.targetVersion, tt.args.hostSetIds, tt.args.opt...)
|
|
if tt.wantErr {
|
|
require.Error(err)
|
|
t.Log(err)
|
|
return
|
|
}
|
|
t.Log(err)
|
|
require.NoError(err)
|
|
assert.Equal(tt.wantAffectedRows, affectedRows)
|
|
assert.Equal(len(tt.args.hostSetIds), len(got))
|
|
|
|
var wantIds []string
|
|
wantIds = append(wantIds, tt.args.hostSetIds...)
|
|
sort.Strings(wantIds)
|
|
|
|
var gotIds []string
|
|
if len(got) > 0 {
|
|
gotIds = make([]string, 0, len(got))
|
|
for _, s := range got {
|
|
gotIds = append(gotIds, s.PublicId)
|
|
}
|
|
}
|
|
sort.Strings(gotIds)
|
|
assert.Equal(wantIds, gotIds)
|
|
|
|
foundTarget, _, err := repo.LookupTarget(context.Background(), tt.args.target.GetPublicId())
|
|
require.NoError(err)
|
|
if tt.name != "no-change" {
|
|
assert.Equalf(tt.args.targetVersion+1, foundTarget.GetVersion(), "%s unexpected version: %d/%d", tt.name, tt.args.targetVersion+1, foundTarget.GetVersion())
|
|
assert.Equalf(origTarget.GetVersion(), foundTarget.GetVersion()-1, "%s unexpected version: %d/%d", tt.name, origTarget.GetVersion(), foundTarget.GetVersion()-1)
|
|
}
|
|
t.Logf("target: %v and origVersion/newVersion: %d/%d", foundTarget.GetPublicId(), origTarget.GetVersion(), foundTarget.GetVersion())
|
|
})
|
|
}
|
|
}
|