boundary

History

Jeff Mitchell 2c61bd4963 Fix recursive listing when the ingress scope lacks permissions (#1478 ) The existing logic was to ignore Forbidden errors when recursively listing in favor of looking for downstream scopes with appropriate permissions. The problem is that when there is actually no authentication token at all, what comes back is an Unauthenticated error. Therefore if you didn't have permissions on the ingress scope (e.g. the default of `global`) but did downstream for the anonymous user, you'd get back an error. I don't think there's any security issue with doing this; the user could always have simply started the search at a downstream scope to begin with so nothing more is being revealed, this just fixes behavior to match expectations in this case. A test was added for one of the services; the code is exactly the same across them. The reason that the existing tests that were added with the output fields testing didn't catch this is that even though they were specifying `u_anon` as the user, the disabled test context skipped the logic that would return a 401 in this case. It turns out that fixing this is very complicated because we don't have a great way in most tests of defining grants to put onto the generated scopes, so even if a true anonymous context was added each test would require the anonymous user to have list permissions on whatever resource was under test, requiring a lot of role and grant and principal finagling. This is probably a good longer-term TODO but not one that seemed worth it for this fix. Fixes ICU-2301		5 years ago
..
auth	Move API resource pbs to new location (#1484 )	5 years ago
common	Move API resource pbs to new location (#1484 )	5 years ago
handlers	Fix recursive listing when the ingress scope lacks permissions (#1478 )	5 years ago
config.go	The name. The name. The name!	6 years ago
controller.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
cors_test.go	Fix bug causing CORS to accept all origins by default (#1134 )	5 years ago
handler.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
handler_noui.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
handler_test.go	Integrate with Vault to retrieve and manage per session credentials (#1308 )	5 years ago
handler_ui.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
handler_ui_test.go	See how Boundary would look with gofumpt applied (#853 )	5 years ago
intercepting_listener.go	Events: convert from hclog to events (#1409 )	5 years ago
listeners.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
multi_test.go	Add new OIDC auth method. (#1090 )	5 years ago
session_cleanup_job.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
session_cleanup_job_test.go	Remove unneeded hclog dependencies as we move forward with events (#1433 )	5 years ago
testing.go	Fix recursive listing when the ingress scope lacks permissions (#1478 )	5 years ago
testing_test.go	Add TestController (#50 )	6 years ago
tickers.go	Events: ongoing clean up of eventing (#1448 )	5 years ago
worker_tls_config.go	Simplify worker->controller connection (#601 )	5 years ago