boundary

Commit Graph

Author	SHA1	Message	Date
Elim Tsiagbey	ed7bc7cc4d	chore: Add missing for summary interfaces (#3438 ) Add missing `Errors` Getter & Setter for Session & Connection Summary interfaces	3 years ago
Elim Tsiagbey	fd3091d8dc	feat: Decode Summary File (#3408 ) * feat: Decode Summary File - Add support for decoding BSR session, connection and channel summary file - Introduce base summary interfaces that other protocols can extend - Add new SSH register allocation function for getting SSH Channel Summary Type	3 years ago
Irena Rindos	0fcf0e21d9	chore(server): Update worker auth repository to handle dupe nodes (#3410 ) * chore(server): Update worker auth repository to use nodee DuplicateRecordError	3 years ago
Michael Milton	8527f0305d	Fix issue where snapshot conflicts weren't being handled (#3406 ) * fix issue where conflicts weren't being handled * Instead of using on collision, alter the daily_range * move tests to appropriate file * Apply suggestions from code review Co-authored-by: Michael Gaffney <mike@gaffney.cc> --------- Co-authored-by: Michael Gaffney <mike@gaffney.cc>	3 years ago
Irena Rindos	a8e363888a	bug(workerAuth): allow duplicate workerAuth inserts if records match (#3389 ) * bug(workerAuth): allow duplicate workerAuth inserts if records match	3 years ago
Michael Milton	23c40a0bc3	Update census to run less frequently (#3346 ) * update census to run less frequently * Update internal/census/census_job.go Co-authored-by: Michael Gaffney <mike@gaffney.cc> * change nextrunin duration --------- Co-authored-by: Michael Gaffney <mike@gaffney.cc>	3 years ago
Todd	8d9222bec3	Add credential and libraries to session recording resource (#3374 )	3 years ago
Irena Rindos	be074ecbb3	chore: fix op for end chunk (#3370 )	3 years ago
Jim	474afe4671	fix: allow ldap managed grps to be set and removed as principals… (#3363 )	3 years ago
Jim	84cc3a5988	fix(ldap managed grp): allow ldap managed grps to be added as principals (#3361 )	3 years ago
Johan Brandhorst-Satzkorn	2ae007d61e	cmd: fix session recording download flag help (#3351 ) When using an alias, we automatically add a little blurb to the end of the flag help. When not terminating the flag help with a full stop, this looks a bit odd. Add full stops to all the download flags for consistency.	3 years ago
Jim	fabcb8eeeb	fix: update recursive auth-method listing test (#3348 ) Recently, we made the initial dev ldap auth-method active-public, so it now shows up in listings. This simply fixes the tests to reflect that change.	3 years ago
Johan Brandhorst-Satzkorn	9474b373b8	api: remove create from auth-tokens help (#3341 ) The auth-tokens help command included a reference to a non-existent auth-tokens create command. Replace the default help and also add a helpful pointer to the authenticate command.	3 years ago
Elim Tsiagbey	103b1e78aa	docs: update NormalizeSetData comments (#3343 ) * docs: update NormalizeSetData comments Update comments for `NormalizeSetData` to include when `NormalizeSetData` could be useful and the non-obvious consequences of using it.	3 years ago
Jim	723dbdfedf	fix (boundary dev): make the LDAP auth method active-public (#3344 )	3 years ago
Elim Tsiagbey	15e7bbe816	fix: add plugin normalization for onCreate methods (#3338 ) onUpdate for host catalog & host set make a call to the plugin to normalize attributes based in. This behavior was introduced [PR-2376](https://github.com/hashicorp/boundary/pull/2376) but was only applied on onUpdate. This created different data structures for onCreate calls and onUpdate calls.	3 years ago
Jeff Mitchell	3a9903a836	Don't attempt session teardown if the session is expired (#3312 ) This avoids a situation where teardown results in an error due to the worker not accepting the connection (since the credentials are invalid). Teardown is a best-effort way to avoid sessions that have long lifetimes ending up having to wait for expiration before cleanup, but if we're near expiration it doesn't really matter. Fixes ICU-9633	3 years ago
Jeff Mitchell	8322916fb4	Remove all deprecated Err/Wrap/E calls (#3286 )	3 years ago
Jeff Mitchell	feb3aea38f	Support multiple IDs in grants (#3263 ) This allows specifying multiple IDs in grants via an `ids` field, which will eventually become the normal way to specify IDs. Internally, each grant with multiple IDs turns into multiple ACL grants each with a single ID; to make this distinction clearer and allow for better separation of concerns an AclGrant type has been introduced, so really multiple IDs in a Grant turn into multiple AclGrants. The nice thing about doing it this way is that it becomes purely a parsing concern; no actual validation logic has changed. For backwards compatibility with grants already stored in roles, we do not error out if `id` is specified. However, eventually we will simply not support grants with `id` coming via the API; they will fail API validation, such that new grants will require the use of the updated `ids` field. A follow-on PR will plumb this through the service handlers/API/CLI, but I decided to do it in separate chunks to make reviewing easier, given that they are easily separable into the internal and external aspects of the change. * Add CLI/API checks around using ID in grants (#3264) * Plumb through some contexts to remove a lot of deprecated errors (#3268)	3 years ago
Timothy Messier	837734b745	test(bsr/fstest): Add new FS for testing out of space errors (#3305 ) This provides a new storage.FS implementation that expands the on fstest.MemFS by allowing tests to mark the filesystem as out of space. When this happens any write/create operation will start returning an error indicating that the filesystem is out of space.	3 years ago
Dharini Jeeva	f7823d3f71	ui changes (#3304 )	3 years ago
Michael Milton	7820af3924	rename optout to lurEnabled for clarity (#3303 )	3 years ago
Jeff Mitchell	929ede1c18	Modify some tests to expose error cases that weren't being exposed (#3302 )	3 years ago
Johan Brandhorst-Satzkorn	e4f49e1bb0	api: add classification to session recordings (#3300 )	3 years ago
Todd	8980143278	Allow kms purpose "downstream-worker-auth" (#3299 )	3 years ago
Jeff Mitchell	74e8491f85	Disallow updates on all types of KMS workers (#3295 ) This also slightly changes delete logic and ensures authorized actions match what is allowable.	3 years ago
Johan Brandhorst-Satzkorn	ebcd6d2828	api: remove connection ID (#3298 ) Removing this until we figure out why it's sometimes missing. May add it back again later.	3 years ago
Timothy Messier	fe7c87dc82	feat(bsr/ssh): Add open failure details to ChannelSummary (#3297 )	3 years ago
Cameron Perera	eaaaae5cce	chore: bump ui commit (#3296 )	3 years ago
Todd	5a68d789ec	Initialize base context when creating New worker and not at start (#3294 )	3 years ago
Timothy Messier	f7386a5d53	Merge pull request #3280 from hashicorp/tmessi-fix-session-list fix(session): List performance with large number of session connections This includes the backported migration and a migration to ensure the next release has the correct view.	3 years ago
Michael Milton	fbf56793c6	Add snapshot job (#3282 ) * snapshot job * update census to include context, controller to include snapshot registry * no need to export runFn in snapshot	3 years ago
Timothy Messier	603642f271	fix(session): List performance with large number of session connections (#3288 ) As part of the performance improvements for listing sessions for v0.9.0, the view used to retrieve sessions for listing was updated to no longer include a join on session_connection. However, a later migration that was adding additional columns to this view inadvertently re-added the join and session_connection columns. This resulted in requests to list sessions performing this join, and returning additional rows for each connection in a session. The application would ignore this additional data, since it is no longer returned via the API. This would be particularly impactful in cases where there are a large number of connections per session, as this would greatly increase the amount of data returned by the database. This fix removes the session_connection join from this view, which should restore the original performance improvements even in cases where there is a large number of session connections per session. See: https://github.com/hashicorp/boundary/pull/2160 Ref: `32070678dc` Fixes: `1e3c941be1` (cherry picked from commit `7aef341682`)	3 years ago
Timothy Messier	876f9bb07f	fix(session): List performance with large number of session connections As part of the performance improvements for listing sessions for v0.9.0, the view used to retrieve sessions for listing was updated to no longer include a join on session_connection. However, a later migration that was adding additional columns to this view inadvertently re-added the join and session_connection columns. This resulted in requests to list sessions performing this join, and returning additional rows for each connection in a session. The application would ignore this additional data, since it is no longer returned via the API. This would be particularly impactful in cases where there are a large number of connections per session, as this would greatly increase the amount of data returned by the database. This fix removes the session_connection join from this view, which should restore the original performance improvements even in cases where there is a large number of session connections per session. See: https://github.com/hashicorp/boundary/pull/2160 Ref: `32070678dc` Fixes: `1e3c941be1`	3 years ago
Timothy Messier	7e094d824f	feat(bsr/convert): Remove asciicast minimum window size (#3287 ) This removes the minimum on width and height, instead it will just used the largest width, height seen as the initial size for the asciicast. This also provides the ability to still set a minimum via options to convert.ToAsciicast if the caller has a known minimum size. Also note that in cases where there is no size information, ie if there was no pty request, this will still pick a default size of 80x24.	3 years ago
Michael Gaffney	99a8777866	fix(db): Add index to session connection table This index improves the performance for two queries on the `session_connection` table. The execution time for the first query went from 40.105 ms to 1.405 ms. The execution time for the second query went from 13.808 ms to 0.217 ms. Query 1 explain plan before index: Update on session_connection (cost=6465.17..6557.68 rows=11 width=50) (actual time=38.868..39.147 rows=3 loops=1) -> Nested Loop (cost=6465.17..6557.68 rows=11 width=50) (actual time=38.471..38.506 rows=3 loops=1) -> HashAggregate (cost=6464.75..6464.86 rows=11 width=40) (actual time=38.447..38.450 rows=3 loops=1) Group Key: (session_connection_1.public_id)::text Batches: 1 Memory Usage: 24kB -> Nested Loop Semi Join (cost=0.42..6464.72 rows=11 width=40) (actual time=29.184..38.434 rows=3 loops=1) -> Seq Scan on session_connection session_connection_1 (cost=0.00..6329.38 rows=16 width=20) (actual time=15.744..38.014 rows=23 loops=1) Filter: ((worker_id)::text = 'w__________k'::text) Rows Removed by Filter: 163607 -> Index Scan using session_connection_state_connection_id_end_time_key on session_connection_state (cost=0.42..8.45 rows=1 width=20) (actual time=0.016..0.016 rows=0 loops=23) Index Cond: (((connection_id)::text = (session_connection_1.public_id)::text) AND (end_time IS NULL)) Filter: ((state = ANY ('{authorized,connected}'::text[])) AND (start_time < (CURRENT_TIMESTAMP - '00:00:05'::interval))) Rows Removed by Filter: 1 -> Index Scan using session_connection_pkey on session_connection (cost=0.42..8.44 rows=1 width=20) (actual time=0.016..0.016 rows=1 loops=3) Index Cond: ((public_id)::text = (session_connection_1.public_id)::text) Planning Time: 0.793 ms Trigger immutable_columns: time=0.474 calls=3 Trigger update_connection_state_on_closed_reason: time=0.159 calls=3 Trigger update_time_column: time=0.034 calls=3 Trigger update_version_column: time=0.041 calls=3 Trigger wh_update_session_connection: time=0.688 calls=3 Execution Time: 40.105 ms Query 1 explain plan after index: Update on session_connection (cost=152.71..219.87 rows=8 width=50) (actual time=0.497..0.683 rows=3 loops=1) -> Nested Loop (cost=152.71..219.87 rows=8 width=50) (actual time=0.266..0.292 rows=3 loops=1) -> HashAggregate (cost=152.29..152.37 rows=8 width=40) (actual time=0.256..0.258 rows=3 loops=1) Group Key: (session_connection_1.public_id)::text Batches: 1 Memory Usage: 24kB -> Nested Loop Semi Join (cost=4.94..152.27 rows=8 width=40) (actual time=0.199..0.251 rows=3 loops=1) -> Bitmap Heap Scan on session_connection session_connection_1 (cost=4.51..50.76 rows=12 width=20) (actual time=0.017..0.035 rows=10 loops=1) Recheck Cond: ((worker_id)::text = 'w__________k'::text) Heap Blocks: exact=9 -> Bitmap Index Scan on session_connection_worker_id_closed_reason_ix (cost=0.00..4.51 rows=12 width=0) (actual time=0.011..0.011 rows=10 loops=1) Index Cond: ((worker_id)::text = 'w__________k'::text) -> Index Scan using session_connection_state_connection_id_end_time_key on session_connection_state (cost=0.42..8.45 rows=1 width=20) (actual time=0.021..0.021 rows=0 loops=10) Index Cond: (((connection_id)::text = (session_connection_1.public_id)::text) AND (end_time IS NULL)) Filter: ((state = ANY ('{authorized,connected}'::text[])) AND (start_time < (CURRENT_TIMESTAMP - '00:00:05'::interval))) Rows Removed by Filter: 1 -> Index Scan using session_connection_pkey on session_connection (cost=0.42..8.44 rows=1 width=20) (actual time=0.010..0.010 rows=1 loops=3) Index Cond: ((public_id)::text = (session_connection_1.public_id)::text) Planning Time: 0.614 ms Trigger immutable_columns: time=0.279 calls=3 Trigger update_connection_state_on_closed_reason: time=0.185 calls=3 Trigger update_time_column: time=0.027 calls=3 Trigger update_version_column: time=0.032 calls=3 Trigger wh_update_session_connection: time=0.450 calls=3 Execution Time: 1.405 ms Query 2 explain plan before index: Limit (cost=1002.40..6147.94 rows=1 width=253) (actual time=12.244..13.726 rows=1 loops=1) -> Nested Loop Left Join (cost=1002.40..6147.93 rows=1 width=253) (actual time=12.243..13.724 rows=1 loops=1) Join Filter: ((w.public_id)::text = (session_connection.worker_id)::text) CTE worker_config_tags -> GroupAggregate (cost=1.71..2.26 rows=22 width=59) (actual time=0.044..0.082 rows=22 loops=1) Group Key: ct_1.worker_id, ct_1.source -> Sort (cost=1.71..1.77 rows=22 width=49) (actual time=0.031..0.034 rows=22 loops=1) Sort Key: ct_1.worker_id, ct_1.source Sort Method: quicksort Memory: 27kB -> Seq Scan on server_worker_tag ct_1 (cost=0.00..1.22 rows=22 width=49) (actual time=0.007..0.010 rows=22 loops=1) -> Nested Loop Left Join (cost=0.14..9.28 rows=1 width=245) (actual time=0.106..0.108 rows=1 loops=1) Join Filter: ((w.public_id)::text = (ct.worker_id)::text) -> Nested Loop Left Join (cost=0.14..8.72 rows=1 width=213) (actual time=0.103..0.104 rows=1 loops=1) Join Filter: ((w.public_id)::text = (wt.worker_id)::text) -> Index Scan using server_worker_pkey on server_worker w (cost=0.14..8.15 rows=1 width=181) (actual time=0.012..0.012 rows=1 loops=1) Index Cond: ((public_id)::text = 'w__________k'::text) -> CTE Scan on worker_config_tags wt (cost=0.00..0.55 rows=1 width=64) (actual time=0.090..0.090 rows=0 loops=1) Filter: (((worker_id)::text = 'w__________k'::text) AND (source = 'api'::text)) Rows Removed by Filter: 22 -> CTE Scan on worker_config_tags ct (cost=0.00..0.55 rows=1 width=64) (actual time=0.001..0.002 rows=1 loops=1) Filter: (((worker_id)::text = 'w__________k'::text) AND (source = 'configuration'::text)) Rows Removed by Filter: 8 -> GroupAggregate (cost=1000.00..6136.36 rows=1 width=21) (actual time=12.133..13.610 rows=0 loops=1) Group Key: session_connection.worker_id -> Gather (cost=1000.00..6136.35 rows=1 width=13) (actual time=12.132..13.608 rows=0 loops=1) Workers Planned: 2 Workers Launched: 2 -> Parallel Seq Scan on session_connection (cost=0.00..5136.25 rows=1 width=13) (actual time=9.012..9.012 rows=0 loops=3) Filter: ((closed_reason IS NULL) AND ((worker_id)::text = 'w__________k'::text)) Rows Removed by Filter: 54544 Planning Time: 0.398 ms Execution Time: 13.808 ms Query 2 explain plan after index: Limit (cost=2.82..20.03 rows=1 width=253) (actual time=0.132..0.134 rows=1 loops=1) -> Nested Loop Left Join (cost=2.82..20.02 rows=1 width=253) (actual time=0.131..0.133 rows=1 loops=1) Join Filter: ((w.public_id)::text = (session_connection.worker_id)::text) CTE worker_config_tags -> GroupAggregate (cost=1.71..2.26 rows=22 width=59) (actual time=0.046..0.086 rows=22 loops=1) Group Key: ct_1.worker_id, ct_1.source -> Sort (cost=1.71..1.77 rows=22 width=49) (actual time=0.033..0.035 rows=22 loops=1) Sort Key: ct_1.worker_id, ct_1.source Sort Method: quicksort Memory: 27kB -> Seq Scan on server_worker_tag ct_1 (cost=0.00..1.22 rows=22 width=49) (actual time=0.007..0.011 rows=22 loops=1) -> Nested Loop Left Join (cost=0.14..9.28 rows=1 width=245) (actual time=0.120..0.120 rows=1 loops=1) Join Filter: ((w.public_id)::text = (ct.worker_id)::text) -> Nested Loop Left Join (cost=0.14..8.72 rows=1 width=213) (actual time=0.117..0.118 rows=1 loops=1) Join Filter: ((w.public_id)::text = (wt.worker_id)::text) -> Index Scan using server_worker_pkey on server_worker w (cost=0.14..8.15 rows=1 width=181) (actual time=0.011..0.012 rows=1 loops=1) Index Cond: ((public_id)::text = 'w__________k'::text) -> CTE Scan on worker_config_tags wt (cost=0.00..0.55 rows=1 width=64) (actual time=0.104..0.105 rows=0 loops=1) Filter: (((worker_id)::text = 'w__________k'::text) AND (source = 'api'::text)) Rows Removed by Filter: 22 -> CTE Scan on worker_config_tags ct (cost=0.00..0.55 rows=1 width=64) (actual time=0.002..0.002 rows=1 loops=1) Filter: (((worker_id)::text = 'w__________k'::text) AND (source = 'configuration'::text)) Rows Removed by Filter: 8 -> GroupAggregate (cost=0.42..8.45 rows=1 width=21) (actual time=0.010..0.010 rows=0 loops=1) Group Key: session_connection.worker_id -> Index Only Scan using session_connection_worker_id_closed_reason_ix on session_connection (cost=0.42..8.44 rows=1 width=13) (actual time=0.010..0.010 rows=0 loops=1) Index Cond: ((worker_id = 'w__________k'::text) AND (closed_reason IS NULL)) Heap Fetches: 0 Planning Time: 0.544 ms Execution Time: 0.217 ms Closes #3281	3 years ago
Johan Brandhorst-Satzkorn	610df9892b	all: propagate more history metadata (#3279 ) A few target and host properties were missed when reading historical data from the history tables.	3 years ago
Jim	2b3e50ebdd	fix (listing): return all resources from listing requests (#3278 )	3 years ago
Michael Gaffney	8159ddb08e	feat(db): Add function to update billing snapshot table This adds the `update_sessions_pending_daily_snapshot` SQL function which updates the `sessions_pending_daily_snapshot` table by inserting values for any days missing from the table. This also adds a check constraint to the `sessions_pending_daily_snapshot` table along with a `comment on table`. This also removes the hcp daily billing views since they are no longer needed. Ref: `ace2def49d`	3 years ago
Michael Gaffney	41bdfb4406	fix(db): Fix time zone consistency issues in monthly billing views The hcp monthly billing views build a range of buckets using the `generate_series` and the `now()` functions along with relative offsets like `+ 1 month`. The calculated start and end times for these views can vary depending on the time zone setting of the PostgreSQL server. This adds 3 table functions that call their respective views with the time zone set to UTC. Calling these functions instead of their underlying views directly prevents the returned values from varying when the server's time zone is not set to UTC. This also drops support for PostgreSQL 11. The included tests use the `date_trunc(field, source [, time_zone ])` function added in PostgreSQL 12. Fixes: `41b1b5b4b7`	3 years ago
Michael Gaffney	47ddd2e40a	fix(db): Fix generated series to yield consistent results The hcp billing `_all` views built a range of buckets using the `generate_series` function using the minimum value of the `session_pending_time` column from the `wh_session_accumulating_fact` table as the start time and `now()` as the end time. It then truncated values in the series using the `date_trunc` function. This allowed the generated series of buckets returned to vary and could result in one additional bucket being included in the series depending on the current time and the start time. As an illustrative example, the `hourly_all` query used: select date_trunc('hour',time) from generate_series( (select min(session_pending_time) -- start time from wh_session_accumulating_fact), now(), '1 hour'::interval ) as time; Substituting the start time with a hard coded value to show the issue: -- Show current time, where the minutes portion is 55 select now(); now ------------------------------- 2023-05-22 14:55:40.567605+00 (1 row) -- generate series with start time's minutes portion at 57 select date_trunc('hour',time) from generate_series( '2023-05-22 01:57:00'::timestamptz, now(), '1 hour'::interval ) as time; date_trunc ------------------------ 2023-05-22 01:00:00+00 2023-05-22 02:00:00+00 2023-05-22 03:00:00+00 2023-05-22 04:00:00+00 2023-05-22 05:00:00+00 2023-05-22 06:00:00+00 2023-05-22 07:00:00+00 2023-05-22 08:00:00+00 2023-05-22 09:00:00+00 2023-05-22 10:00:00+00 2023-05-22 11:00:00+00 2023-05-22 12:00:00+00 2023-05-22 13:00:00+00 (13 rows) -- Wait a few minutes select now(); now ------------------------------ 2023-05-22 14:58:48.75287+00 (1 row) -- Now run again and get an extra result, even though still -- within the same hour select date_trunc('hour',time) from generate_series( '2023-05-22 01:57:00'::timestamptz, now(), '1 hour'::interval ) as time; date_trunc ------------------------ 2023-05-22 01:00:00+00 2023-05-22 02:00:00+00 2023-05-22 03:00:00+00 2023-05-22 04:00:00+00 2023-05-22 05:00:00+00 2023-05-22 06:00:00+00 2023-05-22 07:00:00+00 2023-05-22 08:00:00+00 2023-05-22 09:00:00+00 2023-05-22 10:00:00+00 2023-05-22 11:00:00+00 2023-05-22 12:00:00+00 2023-05-22 13:00:00+00 2023-05-22 14:00:00+00 (14 rows) To fix this, we call the `generate_series` function truncating the start time argument to the bucket size: -- Hourly select bucket from generate_series( date_trunc('hour', select min(session_pending_time) from wh_session_accumulating_fact)), now(), '1 hour'::interval ) as bucket; -- Monthly select bucket from generate_series( date_trunc('month', select min(session_pending_time) from wh_session_accumulating_fact)), now(), '1 month'::interval ) as bucket; Fixes: `41b1b5b4b7`	3 years ago
Jim	5029be9999	fix: allow responses larger than the default 4194304 recv msg size (#3276 )	3 years ago
Michael Gaffney	053e74f66c	feat(db): Add table for census upload job status	3 years ago
Michael Gaffney	8bf80e0544	test(db): Conditionally skip monthly billing view tests Certain tests fail when run on the first day of the month because of edge cases in the setup of test data. This adds conditional logic to skip those tests when run on the first day of a month.	3 years ago
Dharini Jeeva	9f5e2020ba	Chore UI bump (#3271 ) * ui changes * ui changes	3 years ago
Todd	2d102a61c5	HcpbWorkers no longer must be KMS workers for LookupHcpbWorkers (#3269 )	3 years ago
Jeff Mitchell	1b0330ad8e	Update dev worker auth flag names (#3265 ) This brings it in line with the updated names that have been settled on in light of deprecating the old KMS method.	3 years ago
Louis Ruch	281f217dcc	feat(plugins): Refactor host plugins to boundary plugins (#3262 )	3 years ago
Johan Brandhorst-Satzkorn	97977f1995	update perms table for session recordings and storage buckets (#3253 )	3 years ago
Cameron Perera	5a64946f9d	chore: bump ui commit (#3261 )	3 years ago

1 2 3 4 5 ...

1977 Commits (c8ee312ae2e145afdc28ac4abb16d68d1ac2000d)