1116 Commits (7f69e935bfdd58c53dd254bf776f853de4471adf)

Author	SHA1	Message	Date
Hugo Vieira	3564776517	feat(worker): Implement proxy handler websocket instrumentation ... Add metrics on read/written bytes and active worker websocket connections.	4 years ago
Louis Ruch	e6b7b7f60a	feat(db): Suppress not found events during db lookups (#1979)	4 years ago
Johan Brandhorst-Satzkorn	f2fa1142d3	fix(test): Remove uses of t.FailNow in goroutines (#1978) ... It is documented as illegal to use t.FailNow in a goroutine. Uses of require assertions call t.FailNow. This may have led to inconsistent test results as some assertions were subject to undefined behavior. Note that it is still allowed to call assert assertions in goroutines. See: https://pkg.go.dev/testing#T.FailNow	4 years ago
Jeff Mitchell	1be55b50c7	Pull up Server to top level of Init command (#1959) ... * Pull up Server to top level of Init command Init was using a local server variable but not passing in the existing command, resulting in the context being lost. This caused the command to fail to run since the changes to add logging to KMS plugins were introduced. This also fixes a couple of places that were not using the global const value for config KMS. * Fix test compilation	4 years ago
Jim	0ca86c8a2c	chore: remove unneeded ref to gorm.DB (#1971)	4 years ago
Todd	fb068341a4	Update naming for initializing collectors and tweak some comments. (#1968)	4 years ago
Johan Brandhorst-Satzkorn	b1d6a1da9a	Switch to buf for protobuf generation (#1944) ... * Install buf with go install This reduces the impact of using buf on our dependency closure, which was significant. It also avoids potential issues with building buf given our own internal dependency constraints. This has caused issues (including crashes!) in the past. See https://github.com/cockroachdb/cockroach/issues/67216#issuecomment-874176186 for more discussion on using tool dependencies generally, and https://github.com/bufbuild/buf/issues/52 for an example of where this sort of thing caused an issue for a user. * Upgrade buf version We should migrate to v1 sooner rather than later, as it has some breaking changes from v0. * Change buf lint/breaking commands These commands were moved up one level for v1 * Migrate to buf.yaml to v1 * Remove unused imports These were uncovered by using "buf lint". * Use buf v1.3.1 * Depend on googleapis and grpc-gateway via BSR * Switch to buf for proto generation * Remove third party dependency * Remove unused tools and scripts * Move local protos up one level * Temporarily don't fail on breaking changes * Generate CI config * Fix generation of controller.json * Replace use of deprecated flag * Remove unused import, regenerate files * Remove temporary skipping over breaking check	4 years ago
Jeff Mitchell	58a448fc6a	Put session ID in ALPN (#1966) ... This allows us to use SNI for actual host (e.g. routing) information. We don't have the client cert yet so we can't look at that, so this provides a way for us to convey the information needed to look up that session's TLS stack. Using SNI for hosts means we also run into the fact that we don't have automatic agreement in terms of SANs. So when generating the certs we now also pass worker address information to the function to be encoded in the cert. Finally, there is a change in how the websocket dialing happens, because http.RoundTripper tries to be too clever for its own good and overwrites NextProtos on a whim.	4 years ago
Haotian	62f0d18885	Initialize and provide handler for proxy worker http metrics (#1961) ... *feat(metrics): implement prometheus handler for proxy worker http requests and record metric for header write duration	4 years ago
Todd	20e6c0ce6c	Add collector updating interceptor to the controller cluster grpc server (#1964)	4 years ago
Jeff Mitchell	07dc3db974	Remove ALPN Muxer (#1965) ... We never ended up using this and it makes it much harder to reason about the listeners. An explanation: for the moment I separated out all of the listeners in the struct, even though one should suffice, because when I did it that way first I was hitting some really weird and hard to find intermittent behavior where it seemed like the listeners were getting crossed. So I re-did it this way with each listener very explicitly referenced. I'm happy to make a follow-up PR that attempts to combine them all into a single listener without hitting the issues I did, if desired, but at least doing it via a separate PR means that it won't be something with removing the ALPN muxer that is at fault.	4 years ago
A-440Hz	95e1fe8df0	typo(metrics) changing response size to request size	4 years ago
Todd	3eb22b073a	Defines the controller api metrics and registers them at controller startup (#1917) ... Co-authored-by: Hugo Vieira <hugoamvieira@users.noreply.github.com>	4 years ago
Hugo Vieira	aae944be37	test(worker): Remove test-only hooks from actual code ... This change introduces a `nonceFn` field that can be changed by a test but at runtime is transparent to the code that calls it. The current nonce-generating logic defaults to a test-only field which opens us up to this value inadvertently being set. With this change, the default behavior becomes using `base62` to generate a random nonce, and any tests have to explicitly change that.	4 years ago
Hugo Vieira	61e310998f	refactor(worker): Decouple listeners/servers shutdown ... This change is the Worker-side counterpart to the change in eebdfb88dc.	4 years ago
Hugo Vieira	657b099440	refactor(worker): Ensure `startListeners` consistency with controller ... Implements changes on Worker's `startListeners` func to be consistent with the changes on the Controller's side done in b5ef468d33.	4 years ago
Hugo Vieira	1ebd7deccf	refactor(worker): Validate listener configuration in New ... With this change, the Worker is now aware of its own listeners in a more codified and structured way. These changes have already been made in the controller on 8d48a8515c. They're now made on the worker for similar reasons.	4 years ago
Hugo	244237cd2f	feat(controller): Add health endpoint (#1882) ... * feat(controller): New health service and server This change also implements a new listener purpose, `ops`. `ops` (short for operations) is a new listener purpose that is responsible for serving Boundary's operations endpoints, like health and possibly metrics. At Startup: `ops` listeners get configured as late as possible to catch any errors with the startup process; At Shutdown: If the health endpoint has been set-up, we introduce a configurable delay in the process. This is to enable the health endpoint to report unhealthy for that amount of time. `ops` listeners are also the last listeners to be shutdown.	4 years ago
Hugo Vieira	eebdfb88dc	refact(controller): Decouple listeners/servers shutdown from Worker ... In general, these changes were introduced in the same vein of the changes to controller `startListeners`. Specifically, these changes also decouple the Controller and the Worker shutdown processes. Currently, a call to `stopListeners` on an instance that is running as both a Controller and a Worker would stop the listeners for both. Lastly, we also add unit/integration tests to the shutdown code.	4 years ago
Hugo	d438a6d2dd	Merge pull request #1907 from hashicorp/hugoamvieira-controller-start-listeners ... refactor(controller): `startListeners` improvements	4 years ago
Jeff Mitchell	c99907c6c5	Update keyring deps to remove deprecation warnings (#1924)	4 years ago
Hugo Vieira	b5ef468d33	refact(controller): Ensure deterministic listeners start order ... Previously, we initialized the listeners on the order they were provided to us on the config file. In the future, we'll want to add new listener purposes that depend on existing ones, so the init order needs to be deterministic. With this change, we'll initialize components in this order: 1. gRPC Server for Controller API. 2. All `api` HTTP Servers & gRPC Gateway Muxes. 3. `cluster` gRPC Server. This commit introduces some renames for the sake of clarity as well as improved test coverage: - Removes `gatewayMux` reference from Controller object. This object was misleading and is now uneeded. - Removed uneeded `context.Context` arguments. - Separates gRPC Server and gRPC Gateway concerns, both in functionality and in naming. These two were conflated before. - Added unit tests on `startListeners`.	4 years ago
Hugo Vieira	8d48a8515c	refact(controller): Validate listener configuration in New ... With this change, the Controller is now aware of its own listeners in a more codified and structured way. The reasoning behind these changes are as follows: 1. Currently, we're iterating over these listeners in multiple spots along this initialization flow to check each listeners' purpose. By doing this once when we create a Controller and essentially storing the result, we can clean up the downstream code to use those results. 2. Initial effort to centralize Controller validation. At the moment, we are doing a lot of validation all over the `cmd` and `config` packages. From a conceptual perspective, Controller-related validation should be performed in the function that is responsible for constructing the Controller object itself. This enables any developer to look in a single place for all the constraints that we place on creating a Controller.	4 years ago
Lars Lehtonen	b6ee5dc9cc	internal/session: fix dropped test errors (#1928)	4 years ago
irenarindos	0eb70b7942	bug(worker): create error and handle session cancel with no tofu token	4 years ago
Jeff Mitchell	e596daf34d	Add hclog adapter and gating to eventer (#1915) ... This contains to related things: 1. An adapter allowing an hclog interface to take in information and send them to the eventer 2. A gate on the eventer, which is the analogue to the behavior prior to eventing where we'd ensure logs were not printed prior to the startup information. Without this, plugin logs using the hclog adapter will start showing up too early.	4 years ago
Jeff Mitchell	7eb29261b2	Update to go-kms-wrapping version 2, and plugin-based KMS (#1901)	4 years ago
Johan Brandhorst-Satzkorn	89273a2f3e	Update references to "make dev" (#1920) ... "make dev" has been replaced with "make install" since b53e4d4c3e.	4 years ago
Timothy Messier	9aa2d4cd84	test(session): Speed up some tests around dead worker cleanup ... This removes or reduces the time that is waited in a number of tests by allowing the grace period time be a configuration option on the connection repository.	4 years ago
Timothy Messier	79670180a7	refact(session): Move domain logic of Worker Status into domain service ... This creates a domain service function `session.WorkerStatusReport`. The service performs two functions: 1. Checks the status for all of the reported sessions, returning a report of the sessions that are in a "non-active" state, i.e. "cacneling" or "terminated". 2. Looks for any "orphaned" session connections, i.e. connections that are active but were not reported by the worker. These connections are marked as closed. This also removes the "ShouldCloseConnectionsOnWorker" logic, as this was determined to not be a possible state, and was unnecessary.	4 years ago
Timothy Messier	cdb035f5fc	test(worker_service): Add baseline tests for Status ... This adds tests for the Status method of the WorkerService grpc service that is exposed by controller.	4 years ago
Timothy Messier	4de6464978	refact(session): Make CloseDeadConnectionsForWorker more testable ... The query for CloseDeadConnectionsForWorker includes a time comparison to exclude results that are too close to the current time. This is done to account for a delay in reporting by the worker. However, since the delay was hardcoded in the query, it made it difficult to test. This moves the delay duration into a parameter that is set on the repository. The amount of the delay can be set at repository creation time using the new WithWorkerStateDelay option. This defaults to the previously hardcoded amount. This will allow tests to control the delay to exercise this functionality fully.	4 years ago
Timothy Messier	e0603534c0	lint(session): Whitespace and missing ; in sql queries	4 years ago
irenarindos	32132d6bc1	refactor(session connections): Refactor connection closure	4 years ago
irenarindos	3482f91a17	refactor(connections): Move connect connect to the Connection repo	4 years ago
irenarindos	ac9fb8016f	refactor(session connections): Worker only closes connections in memory on grace period expiration	4 years ago
Irena Rindos	5a2c0db586	fix(session connections): Create session connection repository	4 years ago
Louis Ruch	f8b27645d9	fix(scheduler): Update job run query to not error on running conflict (#1914)	4 years ago
Irena Rindos	bc6689fb16	docs(permissions): break permissions into sections (#1893) ... * docs(permissions): break permissions into sections * fixup! docs(permissions): break permissions into sections	4 years ago
Timothy Messier	bdb98d508e	fix(genapi): Sort slice in removeDups template function (#1889) ... The removeDups template function converts a slice into a map and back into a slice in order to leverage the map keys to remove duplicates. However, since the iteration order over a map is not specified it would be possible to get different orders for multiple runs of `make api`. While this would not have an impact on any functionality, it is causing sporadic failures for the new make-gen-deltas CI job. See: https://go.dev/ref/spec#For_statements Ref: d57603022a	4 years ago
Justen Walker	8279397dbb	fix(connect): do not panic on multiple `--` args (#1858) ... Passthrough args looks for the an instance of -- and re-slices the arg list to pass through those args to the underlying connect exec command. However such commands may also need to parse their own '--', such as kubectl exec. This change updates the logic so that boundary arg parser only considers the first instance of '--' when deciding which args to pass to the -exec= commands. Fixes: #1857	4 years ago
Carlos Alcaide Corvo	b529f4af44	Bump ui version (#1868)	4 years ago
Louis Ruch	4ed4575802	chore(fmt): make fmt	4 years ago
Todd	7ee1f74388	fix(hostsets/plugin): Only delete preferred endpoints when there are preferred endpoints to delete. (#1865)	4 years ago
Carlos Alcaide Corvo	360ff9cf2b	Update changelog with latest changes in the UI (#1866) ... * Update changelog with latest changes in the UI * Change to lowercase for consistency * Bump UI version	4 years ago
Todd	e4d1e501cf	fix(warehouse): Handle duplicate addresses when migrating into wh_network_address_dimension (#1860)	4 years ago
Irena Rindos	c6c10cbec7	Merge pull request #1859 from hashicorp/irindos-remove-terminate-session ... refactor(session): Remove dead session termination code	4 years ago
Irena Rindos	5d6aa3b729	refactor(session): Remove dead session termination code	4 years ago
Todd	11ce54f8fb	Add DW network address dimension tables (#1855)	4 years ago
Louis Ruch	8cab9a4315	feat(scheduler): Update job description on conflict (#1852)	4 years ago