70 Commits (5fe40bc7bd200788e34d8bcf4ce1dfd1da5bbad2)

Author	SHA1	Message	Date
Louis Ruch	4cdce29a84	fix(connect): Remove erroneous event error message (#1500) ... When a session is terminated by the user, the cancel session path is triggered, in this path the websocket connection is closed. If the connection is already closed, an EOF is returned. In this situation an EOF is expected and should not be logged to the user. Example log line: { "id": "ezqk6w9dOQ", "source": "https://hashicorp.com/boundary/dev-controller/boundary-dev", "specversion": "1.0", "type": "error", "data": { "error": "failed to close WebSocket: failed to read frame header: EOF", "error_fields": {}, "id": "e_n60YPsDkaj", "version": "v0.1", "op": "worker.(Worker).handleProxy", "info": { "msg": "error closing client connection" } }, "datacontentype": "text/plain", "time": "2021-09-02T10:05:46.587513-07:00" }	5 years ago
Louis Ruch	db8e9bb0c6	refactor(worker): refactors the proxy handler to use endpoint scheme (#1491)	5 years ago
Jeff Mitchell	b13975cb6a	Move API resource pbs to new location (#1484) ... This moves the generated pb files to the `sdk` module. This allows third parties to make use of them if desired (e.g. in upcoming plugins) and moves away from the `gen` nomenclature in the directory, since we are going to be adding some extra interface functions to the messages.	5 years ago
Louis Ruch	31af49e76d	refactor(worker): Move tcp_proxy into its own package (#1458) ... * refactor(worker): Move tcp_proxy into its own package This refactors: - the tcp_proxy.go into worker/proxy/tcp - add a missing unit test for the HandleTcpProxyV1 - refactors session.go into worker/session, needed to avoid import cycle - adds a baseline for a mock controller session client - go lint fixes * Add sleep between spinning listener goroutine and dialing Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>	5 years ago
Jim	477b541bf0	Events: ongoing clean up of eventing (#1448)	5 years ago
Jeff Mitchell	c75c97a872	Normalize event configuration (#1444) ... * Normalize event configuration This updates event configuration stanzas to more closely match behavior for listeners and kmses: * Singular "sink" instead of "sinks" (probably not the most correct option, but a consistent option, and one that makes sense for HCL) * Allows sinks to have the type defined at the start of the block * Moves type-specific configuration to a specific named block Co-authored-by: Jim <jlambert@hashicorp.com>	5 years ago
s-christoff	00ada3c578	update op (#1442)	5 years ago
Jim	137729b0c0	Event log adpaters (#1434)	5 years ago
Jim	68dd2a66ba	Remove unneeded hclog dependencies as we move forward with events (#1433)	5 years ago
Chris Marchesi	a15961e461	Close connections on worker on shutdown, add force shutdown (#1354) ... This adds functionality to ensure that connections are closed on a worker when the server is shut down or reloaded. Connections are closed, and then the shutdown process waits for the next report to the controller to go through, waiting the grace period that was added in #1330. The rest of shutdown is then proceeded with. Listener shutdown has been moved to the start of the process to ensure that new connections can't be made while we are shutting down. Additionally, functionality has been added to force shut down servers after a second interrupt has been received after the first one. This takes the form of code in both the server and dev mode code paths that just performs an os.Exit if another shutdown is received during the normal shutdown process. Additionally, the commit also includes some refactoring to tests so that we could use some of the new E2E testing code to test session connections during shutdown and reload. Additionally, this fixes a panic in worker startup when there are no controllers defined. Looks like the shutdown call was attempting to call into the controller, not the worker. Finally, this also removes the extra shutdown within the outer worker startup. Shutdown is actually handled within the inner StartWorker(), attempting shutdown on errors was actually leading to potential use of an uninitialized worker, which is leading to panics in testing.	5 years ago
Jim	70ad081e39	Events: convert from hclog to events (#1409)	5 years ago
Jim	11124794bf	Events: add node for formatting/filtering cloudevents (#1390)	5 years ago
Chris Marchesi	1ebb8efab6	Apply extra review feedback from #1340 (#1400) ... * internal/servers/controller: refactor WaitForNextWorkerStatusUpdate * internal/servers/worker: use connId instead of conn.GetConnectionId() * internal/servers/worker: remove Worker.logClose * internal/session: complement versus inclusive state search * internal/session: use ScanRows instead of Scan * internal/session: make closeConnectionsForDeadServersCte results gormable * internal/tests/cluster: rename TestWorkerSessionCleanup to TestSessionCleanup * Simplify SQL query for CloseConnectionsForDeadWorkers (#1410) Co-authored-by: Michael Gaffney <mgaffney@users.noreply.github.com>	5 years ago
Chris Marchesi	aae0c29f88	internal/servers/worker: fix TestWorkerWaitForNextSuccessfulStatusUpdate (#1402) ... This fixes this test which was failing intermittently. * Ups the grace period timeout to 2s. * Re-positions the testify require.New() so that incorrect code path warnings are not given.	5 years ago
Jeff Mitchell	ed6c59a053	Update the rest of the shared libs locations	5 years ago
Jeff Mitchell	44329d4ff9	Repoint mlock import	5 years ago
Jeff Mitchell	140c54e319	Repoint base62 import	5 years ago
Chris Marchesi	5a70875726	internal/servers/controller: Worker failure connection cleanup (#1340) ... This commit adds the support to do the following: * Mark connections for non-reporting workers as closed. This is the controller counterpart to the worker functionality (see #1330). This is written as a scheduled job that does the work DB-side in a single atomic query. * Works to reconcile states if such a broken controller-worker connection resumes and a worker reports a connection as connected that should be disconnected. In this case, the controller will send an update request, and the worker will honor it and terminate the connection. * Further refinement of the grace period setting has been added here. We have converged on the current server "liveness" setting as our default here, which is half of the previous 30s (15 seconds, in other words). Additionally, this is now configurable on the controller and worker side, with the caveat that it's currently impossible to do so in config as the setting has been untagged in HCL. This is exposed so that we can run some sophisticated testing scenarios where we skew the grace period to either the controller or worker to ensure the aforementioned reconciliation works. * Some repository functions have been added to support the new functionality, in addition to some test code to the worker to allow querying of session state while testing. * Finally, we've added some add timestamp subtraction functions as well, basically serving as the opposite of the addition functions.	5 years ago
Jeff Mitchell	2cbcf9a563	Update usage of shared-secure-libs (#1393)	5 years ago
Jim	1daa3ebefe	integrate events into the servers (#1355)	5 years ago
Jeff Mitchell	7c3d5be4f6	Update format of secret to return both raw and decoded when possible (#1372)	5 years ago
Chris Marchesi	77bafcab71	internal/servers/worker: actually return when aborting closeConnections (#1371) ... This adds a return when aborting from closeConnections, which should have happened as a part of #1369. Note that it's currently inconsequential that it's not happening right now, save some misleading log entries. setCloseTimeForResponse will effectively no-op on empty or nil input maps.	5 years ago
Chris Marchesi	48e55f156a	worker: ensure connections are closed in local state on controller fail (#1369) ... This backports some test work that is being added in #1340 to assert that the worker is actually marking connections closed in its *local* state on a failure to contact the controller. This was missed in #1357 during some late-stage refactoring. Summary of the changes: * If we can't actually contact the controller during connection closure to mark the connections as closed, we actually construct a "fake" response that just simply includes a closed state for all connections requested. This is then used to update the local connection state. * Added a 3 second timeout to the CloseConnection request to the controller to ensure the call to close connections completed in a timely manner and did not hang indefinitely. Testing enhancements: * Added a new helper in TestHelper called LookupSession that allows the lookup of a session from the worker's internal session state. * This is used in the new ExpectConnectionStateOnWorker check in the E2E test, which is part of a larger amount of enhancements to the E2E test that are coming in #1340. * Added a ConnectionStatusFromProtoVal helper function to the session package to allow the conversion of protobuf connection status values to their higher-level counterparts; essentially it is a reverse of ConnectionStatus.ProtoVal. This is used in some of our tests (with more coming in #1340) to just help with keeping things more idiomatic. Finally, there is some minor error refactoring, and we also change the timeout on internal status and connection close requests to the controller to 5 seconds.	5 years ago
Jim	3820503979	"make fmt" updates	5 years ago
Chris Marchesi	9f9acce972	[Merge to main] internal/servers/worker: Controller failure connection cleanup (#1330) (#1357) ... This commit adds some rudimentary functionality for cleaning up connections on controller failure, or more specifically, a failure to communicate with the controllers. In this scenario, when a status cannot be sent for any reason for longer than 30 seconds, the worker will close all connections that are normally not cleaned up (so for sessions that currently are *not* in the progress of being canceled or terminated). Status requests now time out after 10 seconds if they are not made successfully. Session status is not touched during this process, but natural cleanup or connectionless sessions will still occur. This should be okay, as the session should be added on re-connect if need be. A few other changes are made to cancelConnections: first, error logging has been moved to the function so that we can handle errors requesting cancellation directly within the function; this entails simply just locally marking these connections as closed with a warning. Second, there was a minor logging bug where closed connections were not properly being noted in the last trace log, this has been fixed. Additional changes: * Circle: Set acceptance test no_output_timeout to 30m	5 years ago
Jeff Mitchell	7ee8ddba6a	True up some spelling	5 years ago
Jeff Mitchell	6f34da8923	Add cleanup of dead connections no longer reported by a worker (#1220)	5 years ago
Jeff Mitchell	6c48f6ea77	Use pointers for any Uber atomic values (#1044) ... BK clued me into the fact that for some types, similar alignment problems exist as with the normal atomic package (e.g. 64-bit types on 32-bit architectures) if they are not pointer values. So change the few places they weren't pointers to pointers. None of these are 64-bit, but it feels like best practice for using the library and should just standardize on it.	5 years ago
Jeff Mitchell	4738ceee5d	Add TLS certificate and worker tag reloading on SIGHUP (ICU-1142) (ICU-1143) (#959)	5 years ago
Jeff Mitchell	717a3b52ee	Add worker tagging (#862) ... This allows workers to have tags assigned to them, which can then be filtered to control which targets they are allowed to serve.	5 years ago
Michael Gaffney	94cb79bbdd	See how Boundary would look with gofumpt applied (#853) ... * See how Boundary would look with https://github.com/mvdan/gofumpt applied Results of running `gofumpt -w -s .` * Update tools file and Makefile for gofumpt Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>	5 years ago
Jeff Mitchell	a6cca576a3	Attempt canceling sessions by the client (#831) ... * Attempt canceling sessions by the client In some circumstances (like a Ctrl-C), the client knows it's shutting down and the TOFU token will be lost. In this case it makes sense to cancel the session rather than have it time out. This introduces a command enum to the handshake message which can be used for the client to send commands to the worker -- in this case the only specified command is to cancel the session. It doesn't occur if the session is already timed out or if we can't authorize connections as this generally means the session is already invalid.	5 years ago
Jeff Mitchell	18ea39b237	Remove usage of manual.GenerateAndRegisterManualResolver (#810) ... This has been removed in latest grpc.	5 years ago
Jeff Mitchell	e2e4631929	Add ability to set public cluster address (#761)	6 years ago
Jeff Mitchell	1f48d97327	Support for Unix domain socket listeners (#705) ... The client already supports protocol-agnostic transport so handles unix:/// schemes.	6 years ago
Jeff Mitchell	4833fbba23	Simplify worker->controller connection (#601) ... Go's TLS stack doesn't need a separate CA cert and in fact for sessions we don't use this. So simplify the worker connection to remove an unnecessary extra key generation.	6 years ago
Jeff Mitchell	8615d21a1f	Remove connection from worker if in terminated state and all conns are closed, not just in canceling state	6 years ago
Jeff Mitchell	61a0ae02c1	Bring go-alpnmux in house for now	6 years ago
Jeff Mitchell	e86c11db62	Add session lifecycle info to controller's INFO log. (#431) ... This required some plumbing, but nothing major.	6 years ago
Christian Frichot	3940842c4d	Remove legacy references to Vault's API (#426)	6 years ago
Jeff Mitchell	262ff06042	Add public address config option (#405)	6 years ago
Jeff Mitchell	f25186f78a	Standardize on one spelling of "canceled" (#399)	6 years ago
Todd Knight	21f5cc274f	Don't return nil, nil for API service methods. Add tests for updating w/ wrong version. (#396)	6 years ago
Jeff Mitchell	27d728875c	Cleanup session state enum (#394) ... It's up to the worker to understand what a change in state means, so there was no functional difference between simply sending a state change request and a cancel request.	6 years ago
Jeff Mitchell	fcdaf129a3	Add missing continue in close function	6 years ago
Jeff Mitchell	33b0021547	Add Sessions CLI command and add session cleanup to worker (#388)	6 years ago
Jeff Mitchell	bb6ece69b6	Remove unused struct member	6 years ago
Jeff Mitchell	9cbc7b5c3d	Add connection close call from worker to controller (#387)	6 years ago
Jeff Mitchell	7ff4b7f106	Send connected RPC to controller (#386)	6 years ago
Jeff Mitchell	4669c95999	Pass more session info around, make proxy UX nicer (#385)	6 years ago