247 Commits (jeff-migrate-debugging)

 

All Branches   

Search

Author	SHA1	Message	Date
Jim	ed60cac7fe	add listing for groups and roles (#130)	6 years ago
Jim	1974e355c8	delete all users at the start of each test. (#129)	6 years ago
Jim	c413e013bd	get oplog Ticket before writing data (#127)	6 years ago
Jim	342bef7767	listing projects and organizations (#124)	6 years ago
Jim	d9073a03d5	listing users (#118)	6 years ago
Todd Knight	6ea448a7f3	Adding Groups API endpoint and SDK (#122) ... * feat: Add group grpc handler. * feat: Add group sdk hooks. * fix: Adding forgotten generated group sdk file. * fix: Fix a copy/paste error in test msg. * fix: Correct assert error msg. * fix: Remove unused proto imports.	6 years ago
Jim	ffddf24f86	iam roles (#116)	6 years ago
Todd Knight	1637403624	fix: Removing unused imports and proto files. (#119)	6 years ago
Michael Gaffney	2d650b241d	Fix down migrations (#120) ... * Fix iam down migrations * Fix '03_db' down migrations * Fix oplog down migrations * Fix domain down migrations * Run make gen	6 years ago
Jim	cc5114bdef	refactor scopes to conform to public id usage and repo error msgs (#117)	6 years ago
Jim	5c2cff3ad2	iam groups (#112)	6 years ago
Michael Gaffney	4f30983c14	Bump deps and run make gen (#115)	6 years ago
Jeff Mitchell	f41bf6e31e	Add permission grant string parsing and validation and ACL implementation (#109) ... This adds parsing and validation for grant strings along with the ability to create canonical JSON and text strings from a grant. It also adds an ACL implementation, allowing a collection of grant strings to then be checked against a resource/action tuple and indicate if it's allowed. Note that only specific sets of provided data in grant strings is allowed. This vastly simplifies logic. Test coverage is 100%. A future update will consolidate and migrate types between this and IAM but I didn't want to mix that in with this.	6 years ago
Jim	10e08e90f0	cleanup tests: properly use require, catch defer errors, use testing functions (#113)	6 years ago
Michael Gaffney	ce166c0bdf	Use dbassert package (#114) ... Removes direct dependency on gorm in tests.	6 years ago
Jim Lambert	0a2e1c3946	minor changes to remove a line of dead code and update a comment	6 years ago
Jim	2d18177c9d	oplog support for null field updates (#107)	6 years ago
Jim	c70847fbac	refactor delete test to be table driven. (#102)	6 years ago
Todd Knight	df6ca5289f	Create User Service Handler and SDK (#106) ... * Create user handler stuff. * Fixing Not Found errors from DB. * Fixing param names. * Update the proto's go package generation. * Generate the user resource. * Adding SDK methods for users. * Fix the base type of Users and add tests. * Connect user service to the controller handler. * Attach the default org to the Test Controller's client. * Take into account the provided request paths when the client builds the org/project path prefix. * Adding comments to the API. * rename repo function to repoFn. * Fix typo in update mask errors. * Clean up tests. * Remove special checks for request url content in the api client and fix CORS test.	6 years ago
Todd Knight	2c3fbe3024	Invalid Argument errors provide per field details. (#110) ... * Invalid Argument errors now return a per field error message. * Creating an API error struct. * SDK uses field error details proto. * Adding tests specifically for handler helper error messages resulting in expected API output. * Inlining the error checks into the table driven tests. Use protocmp for assertions to make printing out diffs easier to parse. * Aggregate the invalid argument fields detected to be wrong. * Make the returned order of fields deterministic in the error details.. * Fixing formatting issue in errors_test.go. * Test to confirm unimplemented results in a 405 and not 404.	6 years ago
Jeff Mitchell	5333482ff8	Fix gorm newlines issue (#108) ... Even if you made a custom formatter for gorm, it would blithely println anything returned, including nils, resulting in lots of new lines when we were ignoring output. This also creates a custom logger that doesn't do anything when newlines are found.	6 years ago
Todd Knight	6804c98b0b	Applying Host Catalog comments to Projects (#105) ... * NewService for the project service now returns a non pointer and an error. * Replacing t.Fatal calls with require.NoError calls. * Initialize empty slices following the recommended way. * Don't inline the prefix strings when validating requests. * Check error when cleaning up the test. * Add check that update updates the time. * Use google.golang.org/protobuf where possible instead of github.com/golang/protobuf. * Shorten the validateX function names. * Inline API responses. * Change test cleanup error logging to t.Errorf. * Remove unneeded creation of an extra project. * Inline regex check for invalid id. * Build the pb.Project inline when converting from db to wire proto. * Change stored repos into repo creating functions. * Using iam.TestScopes instead of creating them myself. * Remove out of date comments. * Update name to match go test naming standards. * Adding project service comments. * Using scopeType's new prefix method inside scope.go * Setting test project's name and desc to default to pass tests. * Change host catalog to project in test. * Fixing merge errors. * Fixing some more merge errors. * Fix typo in comments. * Fix typos in project_service.go. * Update error indicating provided id and the expected prefix. * Make the RepoFactory types in a common directory.	6 years ago
Jeff Malnick	b016498d96	docs: update readme with quickstart section for local build (#104)	6 years ago
Todd Knight	d374ac6d4c	Handler hostcatalogs sdk (#103) ... * Created host catalog service. * Fixing uri generation for create. * Use newly submitted static host catalog. * Copying over tests from projects. * Fix UpdateHostCatalogRequest merging proto. * Properly use static host catalog prefixes in tests. * Correct test to verify the expected uri and id prefix is set. * Add test for unsetting descriptions. * Correct bad spelling in comment. * Tweaking variable names. * Adding Stringer to the catalog type and setting the type on the response. * Setting up the catalogType to contain more info regarding its type. * Validate the type field in requests. * Remove unused method. * Comment describing invariants around types. * Wiring in the repo into the static catalog handler. * feature: Add CRUD operations for host catalogs to the go api library. * Updated comments to the exported methods. * fix: return the result of handlers.NotFoundError instead of just calling it. * Fixing typos referencing just hosts instead of host catlogs. * Update NewService returns an error and a non pointer type. * Pull "org_id" and "project_id" into constants and the validation of them into the ValidateAncestors. * Check errors for all Register*HandlerServer calls. * fix: Remove left over reference that could cause a panic. * fix: Changing "x := []string{}" to "var x []string" * fix: Log errors in test cleanup. * Changing the code to use google.golang.org/protobuf instead of the older github based protobuf library. * Changing all t.Fatal checks to require.NoError calls. * Changing unrecognized prefixes to Invalid Argument instead of Not Found. * fix: toDbUpdateMask now returns error if it was unable to find any valid paths. * Define CreatedTime, UpdatedTime, and Type at initialization time in toProto. * Adding sdk test for unsetting a value. * Require that project is created correctly before testing the catalog. * Remove unused host catalog from test. * Change a t.Fatal to a require.NoError that I missed earlier. * Change shutdown error logging to t.Errorfs. * Shorten validateX function names. * Inline API responses. * Add todo to make a new repo per request. * Inline regex check for invalid id. * Change stored repos into repo creating functions which satisfies ICU-223. * Wrap proto comments to be under 80 characters long. * Remove the exception on the read only fields that can be set in an Update request. * Removing out of date comment. * Use iam.TestScopes instead of making the project myself. * Renaming files to be consistant with go test standards and resource naming standards. * Remove TODO related to a task completed in an earlier commit. * Fix the previous commit which removed the wrong TODO.	6 years ago
Todd Knight	7f6e78e66e	Handler hostcatalogs (#86) ... * Created host catalog service. * Fixing uri generation for create. * Use newly submitted static host catalog. * Copying over tests from projects. * Fix UpdateHostCatalogRequest merging proto. * Properly use static host catalog prefixes in tests. * Correct test to verify the expected uri and id prefix is set. * Add test for unsetting descriptions. * Correct bad spelling in comment. * Tweaking variable names. * Adding Stringer to the catalog type and setting the type on the response. * Setting up the catalogType to contain more info regarding its type. * Validate the type field in requests. * Remove unused method. * Comment describing invariants around types. * Wiring in the repo into the static catalog handler. * Updated comments to the exported methods. * fix: return the result of handlers.NotFoundError instead of just calling it. * Fixing typos referencing just hosts instead of host catlogs. * Update NewService returns an error and a non pointer type. * Pull "org_id" and "project_id" into constants and the validation of them into the ValidateAncestors. * Check errors for all Register*HandlerServer calls. * fix: Remove left over reference that could cause a panic. * fix: Changing "x := []string{}" to "var x []string" * fix: Log errors in test cleanup. * Changing the code to use google.golang.org/protobuf instead of the older github based protobuf library. * Changing all t.Fatal checks to require.NoError calls. * Changing unrecognized prefixes to Invalid Argument instead of Not Found. * fix: toDbUpdateMask now returns error if it was unable to find any valid paths. * Define CreatedTime, UpdatedTime, and Type at initialization time in toProto. * Remove unused host catalog from test. * Change a t.Fatal to a require.NoError that I missed earlier. * Change shutdown error logging to t.Errorfs. * Shorten validateX function names. * Inline API responses. * Add todo to make a new repo per request. * Inline regex check for invalid id. * Change stored repos into repo creating functions which satisfies ICU-223. * Wrap proto comments to be under 80 characters long. * Remove the exception on the read only fields that can be set in an Update request. * Removing out of date comment. * Use iam.TestScopes instead of making the project myself. * Renaming files to be consistant with go test standards and resource naming standards. * Remove TODO related to a task completed in an earlier commit. * Fix the previous commit which removed the wrong TODO.	6 years ago
Jim	7d4993fb61	iam users (#96)	6 years ago
Jim	e3fdb493b8	prevent primary key updates (#95) ... * prevent primary key updates * better error to return Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home>	6 years ago
Jim	1048673171	update dbassert dep (#100)	6 years ago
Jim	55be1f4931	Revert "updated dbassert dep (#98)" (#99) ... This reverts commit 628f98d344.	6 years ago
Jim	628f98d344	updated dbassert dep (#98)	6 years ago
Jim	9feb280536	wrapper for dbasserts (#94)	6 years ago
Michael Gaffney	cce06c2cc3	Do not explicitly call the embedded store.HostCatalog (#88)	6 years ago
Jeff Mitchell	c175fcde8d	Add a gorm log formatter to adapt to hclog (#93) ... This is also added in a test that otherwise output to stdout, which validates functionality.	6 years ago
Michael Gaffney	5bdd8a46ea	Extract timestamp scanners into reusable package (#91) ... * Refactor: move Timestamp from static/store to db/timestamp * Refactor: convert remaining Timestamps to timestamp.Timestamp * Use new db timestamp	6 years ago
Michael Gaffney	6a8fd56864	Fix after merging in #90	6 years ago
Michael Gaffney	9eaf8afb6f	Rename db.IsUnique to db.IsUniqueError (#90)	6 years ago
Michael Gaffney	4f3f9ed222	Check for nil in embedded HostCatalog (#89)	6 years ago
Jim	ef6edbd515	Null updates (#78)	6 years ago
Michael Gaffney	6d123d91bb	Fix comment for trigger (#92)	6 years ago
Michael Gaffney	be97e5cac8	Remove dead code	6 years ago
Jeff Mitchell	31ef4a65ac	Bump deps and make gen	6 years ago
Todd Knight	40c14d8232	Adding field names into the table driven test and removed zero values. (#85)	6 years ago
Michael Gaffney	0c7f6da936	Static Host Catalog (#51) ... * database: add wt_public_id domain type * static-hosts: add migrations * Rename migrations * migrations: add description column and fix foreign keys * Add protobuf for static host * Add HostCatalog and HostSet * Add Options * Add foreign key constraint * Add package doc * Add copied scanner code * Add NewHostCatalog with tests * Override default table name for static host catalog * WIP: save static host catalog to database * WIP: Print db url for debugging * Add iam test helper function * Make gorm default to null for names and descriptions * Add foreign key constraint from host catalog to scope * Names are not needed for the test org and project * Avoid an ordering dependency in down migrations * Use wt_timestamp * Add check constraint on host address column * Add Host * Add HostSet * Add HostSetMember * Test a HostSetMember can be written to the database * Move the getters and setters for table name to a new file The TableName methods are needed by gorm and the SetTableName methods are for oplog. Moving them to a new file so related functionality is in the same file. * Add repository * Add NewRepository * Close connection before cleanup of database * Add comments to protobuf file and regenerate * Define repository methods for HostCatalog * Assign PublicId when resource is inserted into the database * Wrap a nil parameter error * Add oplog tickets for static host types * WIP: first cut at CreateCatalog * CreateHostCatalog: more tests * Detect unique constraint violation * Use const for PublicId prefixes * Use PostgreSQL error name instead of error code * Add TODO comments * Fix comments * Use PublicId not PublicID * Refactor: move error variables from host/static to db The error variables defined in host/static are generic and can be reused by other packages. * Create a new repository for each test * Validate CreateCatalog returns a new HostCatalog * Do not modify the HostCatalog passed in * Implement UpdateCatalog * Minor cleanup to make folds work * Implement LookupCatalog * Refactor: extract allocCatalog function * Add comment * Refactor: extract newCatalogMetadata function * Make error strings more consistent * Move database specific error check to internal/db package * Change signature of DeleteCatalog and update docs * Implement DeleteCatalog * Make error strings more consistent * Add examples * Update docs * Add package level doc and example for repository * No need for using reflect.DeepEqual * Remove redundant comment * Clarify ErrMultipleRecords results in the transaction being rolled back * Remove redundant error checks * Remove unnecessary check * Return early instead of using nested 'else' statements * Update and Delete must return a row count * catch err on defers (#82) Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home> * Remove 'if assert' pattern * Use assert package in test helper function * Add test for updating a non existent catalog * Use a single assert when a specific error is expected * Use assert package when it clarifies the check * Catch errors in cleanup functions * Update comments in protobuf file * Update doc for UpdateCatalog to reflect the new behavior * Add common error values for field mask errors * Require a field mask when calling update methods * Add TODO for removing direct call to gorm * Export Public ID prefixes * Add db timestamp guards * Remove unused option Co-authored-by: Jim <jlambert@hashicorp.com> Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home>	6 years ago
Jim	aa64579a8c	db timestamp guards (#70)	6 years ago
Todd Knight	6dd083fa42	Change 501 errors to 405 (#80) ... * Unimplemented errors should result in a 405 instead of a 501.	6 years ago
Todd Knight	44152ae63e	Add API Error Handler (#74) ... * Add error handler that converts from rpc.Status errors to Watchtower API errors. * Better testing for ErrorHandler. * Rename testcase and remove empty default switch case. * Change the error status back to int64. * Converting everything to int32s. jsonpb wraps int64s as a string which we dont like. We'll figure out how to use values larger than int64s when it comes up. * Remove special casing for TraceId which isn't needed anymore. * Removing wrappers from error details since we never need to know when they are set or unset from the end user. * Using the helper error functions inside the project service. * Correct usage of hclog, replace panic with Error log. * Adding periods to all API returned errors, correct spelling, fix missed invalid argument error not using helper function. * Change our logged errors to Error instead of Warn. * Add TODO for defining and using our own defined API error codes. * Add TODO to remove internal error messages.	6 years ago
Jeff Mitchell	b718091419	Update signatures of generated files to match our tool versions	6 years ago
Jeff Mitchell	1e78d01c6b	Fix panic in handler test by providing empty config	6 years ago
Jeff Mitchell	374a3991a2	Add a passthrough directory feature. (#76) ... This is only compiled in when a `dev` build tag is specified (see #75) for safety. Attempting to use the flag without that tag at build time will fail. However, it is always available within the codebase itself so that tests can be written against this functionality in a programmatic way. Manual testing was performed; no plans to add automated ones as this isn't production-necessary nor exported functionality.	6 years ago
Jeff Mitchell	9fd86faf15	Adds a dev target to Makefile and ports over build script (#75) ... * Initial work on dev builds * Fix build script	6 years ago